Re: [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

Thank you to everyone for the discussion. To summarize, it appears there are no objections with moving forward with HADOOP-13603, which will remove the package line length checkstyle rule. Removing or expanding the 80 character line length limit globally will not be changed at this time. Suppress

Re: [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

Thanks for the clarification Akira, I'm fine with removing it for the package line too (and imports if that's a problem), +1. On Fri, Oct 21, 2016 at 2:02 AM, Akira Ajisaka wrote: > This discussion was split into two separate topics. > > 1) Remove line length checkstyle rule for package line > 2

Re: [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

This discussion was split into two separate topics. 1) Remove line length checkstyle rule for package line 2) Remove line length checkstyle rule for the entire source code 1) I'm +1 for removing the rule for package line. I can provide a trivial patch shortly in HADOOP-13603. 2) As Andrew sai

Re: [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

I don't think anything has really changed since we had this discussion in 2015 [1]. Github and gerrit and IDEs existed then too, and we decided to leave it at 80 characters due to split screens and readability. I personally still like 80 chars for these same reasons. [1] https://lists.apache.org/

Re: [DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

> On 19 Oct 2016, at 14:52, Shane Kumpf wrote: > > All, > > I would like to start a discussion on the possibility of removing the > package line length checkstyle rule (HADOOP-13603 > ). > > While working on various aspects of YARN container

[DISCUSS] HADOOP-13603 - Remove package line length checkstyle rule

All, I would like to start a discussion on the possibility of removing the package line length checkstyle rule (HADOOP-13603 ). While working on various aspects of YARN container runtimes, all of my pre-commit jobs would fail as the package line