> Date: Friday, July 6, 2018 at 10:59 AM
> > To: Vinod Kumar Vavilapalli
> > Cc: Anu Engineer , Arpit Agarwal <
> > aagar...@hortonworks.com>, "su...@apache.org" , "
> > yarn-...@hadoop.apache.org" , "
> > hdfs-..
ache.org" , "
> yarn-...@hadoop.apache.org" , "
> hdfs-...@hadoop.apache.org" , "
> common-...@hadoop.apache.org" , "
> mapreduce-dev@hadoop.apache.org"
> Subject: Re: [VOTE] reset/force push to clean up inadvertent merge c
oop.apache.org" , "
> hdfs-...@hadoop.apache.org" , "
> common-...@hadoop.apache.org" , "
> mapreduce-dev@hadoop.apache.org"
> Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit
> pushed to trunk
>
> Everything seems ok ex
o Fumarola
>> Date: Friday, July 6, 2018 at 10:59 AM
>> To: Vinod Kumar Vavilapalli
>> Cc: Anu Engineer , Arpit Agarwal <
>> aagar...@hortonworks.com>, "su...@apache.org" , "
>> yarn-...@hadoop.apache.org" , "
>> hdfs-...@hadoop.ap
ot;
> common-...@hadoop.apache.org" , "
> mapreduce-dev@hadoop.apache.org"
> Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit
> pushed to trunk
>
> Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451
ot;
> common-...@hadoop.apache.org" , "
> mapreduce-dev@hadoop.apache.org"
> Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit
> pushed to trunk
>
> Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451
>
g" , "
> yarn-...@hadoop.apache.org" , "
> hdfs-...@hadoop.apache.org" , "
> common-...@hadoop.apache.org" , "
> mapreduce-dev@hadoop.apache.org"
> Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit
> pushed to trunk
dfs-...@hadoop.apache.org" ,
"common-...@hadoop.apache.org" ,
"mapreduce-dev@hadoop.apache.org"
Subject: Re: [VOTE] reset/force push to clean up inadvertent merge commit
pushed to trunk
Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451 are
not anymore in
Yes these patches can be cherry-picked.
git cherry-pick 17262470246232d0f0651d627a4961e55b1efe6a
git cherry-pick 99febe7fd50c31c0f5dd40fa7f376f2c1f64f8c3
I will try this now and will compile.
- Sunil
On Fri, Jul 6, 2018 at 10:59 AM Giovanni Matteo Fumarola <
giovanni.fumar...@gmail.com> wrote:
Everything seems ok except the 3 commits: YARN-8435, YARN-7556, YARN-7451
are not anymore in trunk due to the revert.
Haibo/Robert if you can recommit your patches I will commit mine
subsequently to preserve the original order.
(My apology for the mess I did with the merge commit)
On Fri, Jul 6,
I will add that the branch also successfully compiles.
Let's just move forward as is, unblock commits and just fix things if anything
is broken.
+Vinod
> On Jul 6, 2018, at 10:30 AM, Anu Engineer wrote:
>
> Hi All,
>
> [ Thanks to Arpit for working offline and verifying that branch is indeed
Hi All,
[ Thanks to Arpit for working offline and verifying that branch is indeed good.]
I want to summarize what I know of this issue and also solicit other points of
view.
We reverted the commit(c163d1797) from the branch, as soon as we noticed it.
That is, we have made no other commits afte
-1 for the force push. Nothing is broken in trunk. The history looks ugly for
two commits and we can live with it.
The revert restored the branch to Giovanni's intent. i.e. only YARN-8435 is
applied. Verified there is no delta between hashes 0d9804d and 39ad989 (HEAD).
39ad989 2018-07-05 aengin
-1 (non-binding)
force pushes are extremely disruptive. there's no way to know who's
updated their local git repo to include these changes since the commit
went in. if a merge commit is so disruptive that we need to subject folks
to the inconvenience of a force push then we should have more toolin
+1.
-邮件原件-
发件人: Subru Krishnan [mailto:su...@apache.org]
发送时间: 2018年7月6日 5:59
收件人: Wei-Chiu Chuang
抄送: Rohith Sharma K S; Subramaniam Krishnan; yarn-...@hadoop.apache.org;
Hdfs-dev; Hadoop Common; mapreduce-dev@hadoop.apache.org
主题: Re: [VOTE] reset/force push to clean up inadvertent
Unfortunately since it was a merge commit, less straightforward to revert.
You can find the details in the original mail thread:
http://mail-archives.apache.org/mod_mbox/hadoop-yarn-dev/201807.mbox/%3CCAHqguubKBqwfUMwhtJuSD7X1Bgfro_P6FV%2BhhFhMMYRaxFsF9Q%40mail.gmail.com%3E
On Thu, Jul 5, 2018 at
I'm sorry I come to this thread late.
Anu commented on INFRA-16727 saying he reverted the commit. Do we still
need the vote?
Thanks
On Thu, Jul 5, 2018 at 2:47 PM Rohith Sharma K S
wrote:
> +1
>
> On 5 July 2018 at 14:37, Subru Krishnan wrote:
>
> > Folks,
> >
> > There was a merge commit acci
+1
On Fri, 6 Jul 2018 at 3:07 AM, Subru Krishnan wrote:
> Folks,
>
> There was a merge commit accidentally pushed to trunk, you can find the
> details in the mail thread [1].
>
> I have raised an INFRA ticket [2] to reset/force push to clean up trunk.
>
> Can we have a quick vote for INFRA sign-
+1
On 5 July 2018 at 14:37, Subru Krishnan wrote:
> Folks,
>
> There was a merge commit accidentally pushed to trunk, you can find the
> details in the mail thread [1].
>
> I have raised an INFRA ticket [2] to reset/force push to clean up trunk.
>
> Can we have a quick vote for INFRA sign-off to
+1 for this.
- Sunil
On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote:
> Folks,
>
> There was a merge commit accidentally pushed to trunk, you can find the
> details in the mail thread [1].
>
> I have raised an INFRA ticket [2] to reset/force push to clean up trunk.
>
> Can we have a quick
+1
On Thu, Jul 5, 2018 at 2:41 PM, Wangda Tan wrote:
> +1
>
> On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote:
>
> > Folks,
> >
> > There was a merge commit accidentally pushed to trunk, you can find the
> > details in the mail thread [1].
> >
> > I have raised an INFRA ticket [2] to reset/
+1
On Thu, Jul 5, 2018 at 2:37 PM Subru Krishnan wrote:
> Folks,
>
> There was a merge commit accidentally pushed to trunk, you can find the
> details in the mail thread [1].
>
> I have raised an INFRA ticket [2] to reset/force push to clean up trunk.
>
> Can we have a quick vote for INFRA sign-
Folks,
There was a merge commit accidentally pushed to trunk, you can find the
details in the mail thread [1].
I have raised an INFRA ticket [2] to reset/force push to clean up trunk.
Can we have a quick vote for INFRA sign-off to proceed as this is blocking
all commits?
Thanks,
Subru
[1]
http
23 matches
Mail list logo