[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182650#comment-15182650 ] Ray Chiang commented on MAPREDUCE-6622: --- Thanks Zhihai! > Add capability to set JHS job cache

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182528#comment-15182528 ] zhihai xu commented on MAPREDUCE-6622: -- Committed it to 2.8 also. > Add capability to set JHS

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182518#comment-15182518 ] zhihai xu commented on MAPREDUCE-6622: -- Committed it to both branch 2.6 and 2.7. > Add

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179080#comment-15179080 ] zhihai xu commented on MAPREDUCE-6622: -- Thanks for the confirmation [~rchiang]! I will back port

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172155#comment-15172155 ] Ray Chiang commented on MAPREDUCE-6622: --- Good observation, Zhihai. Since it's an optional

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170516#comment-15170516 ] zhihai xu commented on MAPREDUCE-6622: -- This patch also fixed a memory leak issue due to a race

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170289#comment-15170289 ] Hudson commented on MAPREDUCE-6622: --- FAILURE: Integrated in Hadoop-trunk-Commit #9380 (See

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170271#comment-15170271 ] Robert Kanter commented on MAPREDUCE-6622: -- +1 Will commit this shortly. The findbugs and

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170250#comment-15170250 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170129#comment-15170129 ] Karthik Kambatla commented on MAPREDUCE-6622: - Latest patch looks good to me. +1. Thanks

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170105#comment-15170105 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170093#comment-15170093 ] Karthik Kambatla commented on MAPREDUCE-6622: - The latest patch does fix the behavior,

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168563#comment-15168563 ] Ray Chiang commented on MAPREDUCE-6622: --- Ugh, never mind. Had two windows opened and one not

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168408#comment-15168408 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168216#comment-15168216 ] Karthik Kambatla commented on MAPREDUCE-6622: - Almost there. One comment: # Should we use

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168112#comment-15168112 ] Ray Chiang commented on MAPREDUCE-6622: --- RE: Failing unit test MAPREDUCE-6625 has been filed

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168062#comment-15168062 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163838#comment-15163838 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160149#comment-15160149 ] Karthik Kambatla commented on MAPREDUCE-6622: - Wouldn't the current patch log an error

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160100#comment-15160100 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159483#comment-15159483 ] Ray Chiang commented on MAPREDUCE-6622: --- In order to minimize impact, I didn't really do any

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158975#comment-15158975 ] Jason Lowe commented on MAPREDUCE-6622: --- Sorry for the delay in responding, as I was out on

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158438#comment-15158438 ] Karthik Kambatla commented on MAPREDUCE-6622: - Comments on the latest patch: # Unused

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158029#comment-15158029 ] Robert Kanter commented on MAPREDUCE-6622: -- LGTM +1 [~kasha], [~jlowe], any other comments?

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158010#comment-15158010 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157804#comment-15157804 ] Robert Kanter commented on MAPREDUCE-6622: -- Looks good overall, some minor things: - The

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157602#comment-15157602 ] Ray Chiang commented on MAPREDUCE-6622: --- RE: ASF license warnings ASF license issues not

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157570#comment-15157570 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154995#comment-15154995 ] Ray Chiang commented on MAPREDUCE-6622: --- For LinkedHashMap implementations, I have tried the

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151528#comment-15151528 ] Karthik Kambatla commented on MAPREDUCE-6622: - Sorry for the delay in getting to this.

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126860#comment-15126860 ] Ray Chiang commented on MAPREDUCE-6622: --- While I do have some doubts about general Guava library

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123276#comment-15123276 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123592#comment-15123592 ] Jason Lowe commented on MAPREDUCE-6622: --- Thanks for the patch, Ray! The documentation for the

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123892#comment-15123892 ] Ray Chiang commented on MAPREDUCE-6622: --- bq. The documentation for the existing property for

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124781#comment-15124781 ] Hadoop QA commented on MAPREDUCE-6622: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124791#comment-15124791 ] Ray Chiang commented on MAPREDUCE-6622: --- RE: ASF license warning Same set of files as earlier.

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123973#comment-15123973 ] Jason Lowe commented on MAPREDUCE-6622: --- My main point was that I don't think it would be hard

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124003#comment-15124003 ] Ray Chiang commented on MAPREDUCE-6622: --- bq. We should change if (loadedTasksCacheSize==-1) { to

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123999#comment-15123999 ] Ray Chiang commented on MAPREDUCE-6622: --- Oh, I see. I did try the simplest approach of

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123989#comment-15123989 ] Robert Kanter commented on MAPREDUCE-6622: -- If we add the -1, 0, and >0 for the cleanUp(),

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124151#comment-15124151 ] Karthik Kambatla commented on MAPREDUCE-6622: - If we do decide to continue with using the

[jira] [Commented] (MAPREDUCE-6622) Add capability to set JHS job cache to a task-based limit

[ https://issues.apache.org/jira/browse/MAPREDUCE-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124148#comment-15124148 ] Karthik Kambatla commented on MAPREDUCE-6622: - I have used the guava cache before (can't