Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Jeff McKenna
Ah I see your point, I will expand that point more in the RFC now... Your assumption is correct. Thanks Lars! -jeff On 2022-05-18 5:09 p.m., Jeff McKenna wrote: Thanks for the positive support Lars, your testing feedback is important, and merry Christmas ha. Regarding your question, pleas

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Jeff McKenna
Thanks for the positive support Lars, your testing feedback is important, and merry Christmas ha. Regarding your question, please see the section "3.3 Limitations" of the RFC which is supposed to handle your question. -jeff On 2022-05-18 4:07 p.m., Lars Schylberg wrote: Thanks, Björn and

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Lars Schylberg
Thanks, Björn and Jeff for the effort to do this.I am eager to start testing soon.As a user I feel that Santa is coming early this year. I also have one question.Is the native FlatGeobuf driver doing the reading without checks, like "VERIFY_BUFFERS" "NO" that you can set in the OGR driver? M

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Steve Lime
Nice work all - esp. Björn. Evan has a good point that sounds like it could be addressed. Couple of comments: 1. I'd like to see a security impact section added just so it's clear that it has been thought about. For example, what is behavior if a corrupt, invalid or truncated file is acce

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Tom Kralidis
+1 ..Tom >> On May 18, 2022, at 06:54, jbo-...@mailo.com wrote: >>> +1 >>> Jérome >>> >>> De : Jeff McKenna À : mapserver-dev@lists.osgeo.org Sujet : Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format Date : 17/05/2022 15:19:

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Even Rouault
I'm 0 on this. While this is always nice to see a perf improvement, I'm somewhat concerned by the duplication of code between MapServer and GDAL. And from a purely technical point of view, one of my worry is that symbol clashes might occur between GDAL and MapServer on the common code they sha

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Seth G
Thanks Björn and Jeff! +1 Seth -- web:https://geographika.net twitter: @geographika On Wed, May 18, 2022, at 12:58 PM, Tom Kralidis wrote: > +1 > > ..Tom > >> On May 18, 2022, at 06:54, jbo-...@mailo.com wrote: >> +1 >> Jérome >> >> >>> De : Jeff McKenna >>> À : mapserver-dev@lists.osgeo.

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread Tom Kralidis
+1 ..Tom > On May 18, 2022, at 06:54, jbo-...@mailo.com wrote: > > +1 > Jérome > > >> De : Jeff McKenna >> À : mapserver-dev@lists.osgeo.org >> Sujet : Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as >> built-in format >> Date : 17/05/2022 15:19:06 Europe/Paris >> >> Update

Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format

2022-05-18 Thread jbo-ads
+1 Jérome De : Jeff McKenna À : mapserver-dev@lists.osgeo.org Sujet : Re: [mapserver-dev] Proposal/request to implement FlatGeobuf as built-in format Date : 17/05/2022 15:19:06 Europe/Paris Update: Björn has completed the effort (which now includes several msautotests) and we've created an RF