Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Steve Lime
This is my fault... The intention was to localize those bounds checks in a benign manner. However, I should have known that restricting angle to 0-360 might catch someone off guard and loosened that for the 7.6 backport. Those changes had been in the 8.0 branch for many months with zero negative fe

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Rahkonen Jukka
Hi, It looks like Steve Lime was reading the text in the paragraph and not the line the defines the synopsis and thought that the documentation was explicit https://github.com/MapServer/MapServer/issues/6463#issuecomment-1025938850 “since style-level angle documentation refers specifically to 0

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Jeff McKenna
Hi Oliver, a pull request in the documentation repository would be warmly received: https://github.com/MapServer/MapServer-documentation Thank-you for catching this. -jeff -- Jeff McKenna GatewayGeo: Developers of MS4W, MapServer Consulting and Training co-founder of FOSS4G http://gateway

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Oliver Christen
before that commit, the following code was working: STYLE COLOR 255 255 255 SYMBOL "rectangle3" ANGLE -45 SIZE 8 GAP 10 END after that commit, it no longer works, as ANGLE -45 is not accepted anymore, instead it had to be changed to STYLE COLOR 255 255

Re: [MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Rahkonen Jukka
Hi, Maybe the commit could be adjusted in Mapserver 7. Out of curiosity, what is the use case for zero sized labels and symbols? To disable them, or? About the angle, by the Mapserver 7.0 documentation, doesn't it feel like negative angles were not thought to work ever? "Angle, given in degree

[MapServer-users] breaking changes in branch-7-6 after commit of experimental changes from branch-8-0

2023-05-30 Thread Oliver Christen
Dear Mapserver commiters this commit there: https://github.com/MapServer/MapServer/pull/6818 broke a lot of things, like style angles not supporting negative values anymore or label size mandatorily greater than zero (also possibly for symbol) Im not against changes, but changes should be: a) do