[mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-07 Thread ikeszei
Hello, I noticed that when MapServer issues the query to MS SQL Server, it appends a .MakeValid() tag to the geometry field, which makes data access highly inefficient as no spatial indexes can be used when the MakeValid() is used. Here is the query that is being produced: SELECT convert

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-07 Thread Seth G
Hi, Good question. This is a fairly new change as part of https://github.com/mapserver/mapserver/issues/5781 from April this year. In SQL Profiler I seem to get GEOM.STIntersects for WFS requests and GEOM.MakeVaid().STIntersects for WMS. MakeValid does appear to stop the index being used. Do y

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-07 Thread Tamas Szekeres
I think we can remove MakeValid from the queries entirely. The problem is that if the table contains invalid geometries, the entire query will fail. Best regards, Tamas Seth G ezt írta (időpont: 2019. szept. 7., Szo, 21:35): > Hi, > > Good question. This is a fairly new change as part of > ht

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-07 Thread Istvan Keszei
We have real large geospatial tables. Not having an option to turn MakeValid off will kill our applications’ performance as indexes are essential. For a simple query, the disk reads are 100x more for a query including the MakeValid. Hence, the cpu resources required are multifold too. Yes, pl

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-08 Thread Seth G
Hi Istvan, Unfortunately you won't be able to turn it off without recompiling the MSSQL driver. I've added a pull request removing these at https://github.com/mapserver/mapserver/pull/5856 This will be merged into master assuming there are no objections. I assume you are using ms4w as you ment

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-09 Thread ikeszei
. Much appreciated, Istvan From: Seth G Sent: Sunday, September 8, 2019 11:06 PM To: Istvan Keszei ; Tamas Szekeres Cc: MapserverList OSGEO Subject: Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries Hi Istvan, Unfortunately you won&#

Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries

2019-09-09 Thread Rahkonen Jukka (MML)
Cc: MapserverList OSGEO mailto:mapserver-users@lists.osgeo.org>> Subject: Re: [mapserver-users] Highly inefficient MakeValid statement in Mapserver-generated spatial queries Hi Istvan, Unfortunately you won't be able to turn it off without recompiling the MSSQL driver. I've adde