Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-08 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated July 8, 2015, 6 p.m.) Review request for Marble and Torsten Rahn

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-08 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated July 8, 2015, 10:15 a.m.) Review request for Marble and Torsten

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-01 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated July 1, 2015, 5:57 p.m.) Review request for Marble and Torsten R

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-01 Thread Ana Badescu
> On June 29, 2015, 2:16 p.m., Torsten Rahn wrote: > > Hi Ana, > > > > Thanks for your review request on the tests. > > Some thoughts on improvements: > > - Why did you attach the tests as a diff instead of adding them to the > > review request? :-) ? > > - Please add some more corner cases fo

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-01 Thread Ana Badescu
> On June 25, 2015, 7:40 p.m., Dennis Nienhüser wrote: > > src/lib/marble/MergedLayerDecorator.cpp, line 234 > > > > > > could also be implemented like this: > > > > bool const hasQuad = overlay->latLonQ

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-07-01 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated July 1, 2015, 5:51 p.m.) Review request for Marble and Torsten R

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-06-29 Thread Dennis Nienhüser
> On June 29, 2015, 2:16 p.m., Torsten Rahn wrote: > > Hi Ana, > > > > Thanks for your review request on the tests. > > Some thoughts on improvements: > > - Why did you attach the tests as a diff instead of adding them to the > > review request? :-) ? > > - Please add some more corner cases fo

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-06-29 Thread Torsten Rahn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/#review81867 --- Hi Ana, Thanks for your review request on the tests. Some th

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-06-29 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated June 29, 2015, 9:01 a.m.) Review request for Marble and Torsten

Re: [Marble-devel] Review Request 124182: Implement gx:LatLonQuad

2015-06-26 Thread Ana Badescu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/ --- (Updated June 26, 2015, 8:12 p.m.) Review request for Marble and Torsten