Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-08-01 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/ --- (Updated Aug. 1, 2015, 4:54 p.m.) Status -- This change has been mar

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-08-01 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/#review83302 --- Ship it! Ship It! - Dennis Nienhüser On Aug. 1, 2015, 3:44

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-08-01 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/ --- (Updated Aug. 1, 2015, 7:44 p.m.) Review request for Marble and Gábor Pét

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-08-01 Thread Mihail Ivchenko
> On July 31, 2015, 4:12 p.m., Gábor Péterffy wrote: > > src/apps/marble-maps/Completion.qml, line 23 > > > > > > Maybe changing this to something like this? > > > > border.width: Screen.pixelDensity * si

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-08-01 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/#review83286 --- Ship it! Awesome :-) Only thing I'd change is adding an inden

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/ --- (Updated Aug. 1, 2015, 1:16 a.m.) Review request for Marble and Gábor Pét

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Dennis Nienhüser
> On July 31, 2015, 12:12 p.m., Gábor Péterffy wrote: > > It also works for me too. I like how fast is it on slow connection too. > > > > I would like to suggest as background color the palette.window, because in > > this case it is in harmony with the search field, this is my favourite > > ve

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Gábor Péterffy
> On júl. 31, 2015, 2:12 du, Gábor Péterffy wrote: > > src/apps/marble-maps/Completion.qml, line 33 > > > > > > I suggest > > background: palette.window After having a look at Dennis's mockup I changed my min

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Gábor Péterffy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/#review83226 --- It also works for me too. I like how fast is it on slow connec

Re: [Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/#review83222 --- Works like a charme :-) The suggestions arrive much quicker th

[Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

2015-07-31 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124541/ --- Review request for Marble and Gábor Péterffy. Repository: marble Descri