Re: [Maria-developers] implementing index condition pushdown in MariaDB 5.5

2013-02-15 Thread Zardosht Kasheff
Thanks a lot Sergei. This information is very helpful. I think this will be my (initial) attempt at implementing ICP for TokuDB. I will return the full pushed condition to MySQL, but I will use the information passed down to filter all index_next, index_next_same, and index_prev calls. This way, i

Re: [Maria-developers] implementing index condition pushdown in MariaDB 5.5

2013-02-15 Thread Sergei Petrunia
On Thu, Feb 14, 2013 at 02:24:57PM -0500, Zardosht Kasheff wrote: > Also, can somebody please explain how handler_index_cond_check checks > index conditions? The key function seems to be item->val_int. How does > this get each value and check check conditions? Function handler_index_cond_check() i

Re: [Maria-developers] implementing index condition pushdown in MariaDB 5.5

2013-02-15 Thread Sergei Petrunia
Hi Zardosht, On Thu, Feb 14, 2013 at 11:31:13AM -0500, Zardosht Kasheff wrote: > Thanks for the feedback. What makes this feature a little difficult > for me to grasp is the requirement that the engine is responsible for > doing some of the condition checking, and that MySQL is doing none of > the

Re: [Maria-developers] implementing multi range read at the storage engine in MariaDB 5.5

2013-02-15 Thread Zardosht Kasheff
Thanks for the pointers Igor. On implementing this. Looking at MariaDB-5.5.28a, I see MyISAM, InnoDB, and Aria all have the code below in their engine. Is that all that is required? Do we need to copy and paste that code into our engine? In fact, the only difference I see is that INnoDB has: if

Re: [Maria-developers] implementing multi range read at the storage engine in MariaDB 5.5

2013-02-15 Thread Igor Babaev
On 02/15/2013 04:17 AM, Zardosht Kasheff wrote: > Hello all, > > Is there anything to implementing multi range read for storage > engines? Or is there a default implementation that is likely good > enough. > > Also, is there anything one can read to understand how the feature > works and its bene

[Maria-developers] implementing multi range read at the storage engine in MariaDB 5.5

2013-02-15 Thread Zardosht Kasheff
Hello all, Is there anything to implementing multi range read for storage engines? Or is there a default implementation that is likely good enough. Also, is there anything one can read to understand how the feature works and its benefits? Thanks -Zardosht ___

[Maria-developers] Idea for parallel replication with statement-based binlogging

2013-02-15 Thread Kristian Nielsen
Hi Xiaobin, I hope you are enjoying the Spring Festival! All the best wishes for you and your family for the coming year. I had an idea for your parallel replication work, inspired by my work on in-order commit. I wanted to hear your opinion on it, if you are interested. The idea is to make your