Re: [Maria-developers] MWL83: review

2013-10-29 Thread Sergei Petrunia
> +double JOIN::static_pushdown_cost(Item *pushed_cond, uint idx) > +{ > + table_map cond_tables= pushed_cond->used_tables(); > + POSITION *last_pos= NULL; > + POSITION *opt_pos; > + double pushed_cond_cost; Take the first example from condition_pushdown.inc: explain extended SELECT count(*) f

Re: [Maria-developers] metadata_lock_info plugin

2013-10-29 Thread Sergey Vojtovich
Hi Kentoku, thanks for your contribution and sorry for this long delay. I finally managed to go through your code. The most important thing I'm worried about is that there is no protection of ticket lists: lists may be updated while we iterate them and it may cause server crash in concurrent envi

Re: [Maria-developers] [Commits] Rev 3711: MDEV-5104 crash in Item_field::used_tables with broken order by in file:///home/tsk/mprog/src/5.3/

2013-10-29 Thread Oleksandr Byelkin
Hi! OK to push! Thank you! 29.10.2013 12:39, tim...@askmonty.org пишет: At file:///home/tsk/mprog/src/5.3/ revno: 3711 revision-id: tim...@askmonty.org-20131029103903-bvjnf3b2aqnoyut5 parent: sa...@askmonty.org-20131021104549-857lwyn

Re: [Maria-developers] metadata_lock_info plugin

2013-10-29 Thread Roberto Spadim
=) no problem about disagree, i'm agree now hehe thanks guys! :) 2013/10/29 Sergey Vojtovich > Hi Kentoku, > > thanks for your contribution and sorry for this long delay. I finally > managed > to go through your code. > > The most important thing I'm worried about is that there is no protection