Re: [Maria-developers] [GSoC] First two weeks into coding! - James' comments

2014-06-02 Thread sriram patil
Hi James, On Mon, Jun 2, 2014 at 3:15 PM, James Briggs wrote: > Hi Sriram. > > I read your CREATE OR REPLACE DATABASE > code and have some comments: > > 1) I noticed that you directly mysql_rm_db the database > before creating it. Please ask your mentor if > it would be better to rename it, obt

Re: [Maria-developers] [GSoC] Accepted student ready to work : )

2014-06-02 Thread Sergei Golubchik
Hi, Pablo! To add to my last reply: On Jun 03, Sergei Golubchik wrote: > Well, it's your project, you can keep any measure you want. > But please mark clearly (in comments or whatever) what factors affect > results and what don't. > > It would be very useful to be able to see the simplest possib

Re: [Maria-developers] [GSoC] Accepted student ready to work : )

2014-06-02 Thread Sergei Golubchik
Hi, Pablo! On Jun 02, Pablo Estrada wrote: > Hello everyone, > Here's a small report on the news that I have so far: > > >1. I had a slow couple of weeks because of a quick holiday that I took. >I will make up for that. >2. I added the metric that considers number of test_runs since

Re: [Maria-developers] [GSoC] Accepted student ready to work : )

2014-06-02 Thread Elena Stepanova
Hi Pablo, Thanks for the update. Some comments inline. On 02.06.2014 18:44, Pablo Estrada wrote: Hello everyone, Here's a small report on the news that I have so far: 1. I had a slow couple of weeks because of a quick holiday that I took. I will make up for that. 2. I added the me

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-06-02 Thread Sergei Golubchik
Hi, Alexander! Looks ok to push, thanks! One minor comment below. On Jun 02, Alexander Barkov wrote: > === modified file 'sql/field.h' > --- sql/field.h 2014-03-26 21:25:38 + > +++ sql/field.h 2014-06-02 10:13:23 + > @@ -94,6 +94,31 @@ inline uint get_set_pack_length(int elem

Re: [Maria-developers] [GSoC] Accepted student ready to work : )

2014-06-02 Thread Pablo Estrada
Hello everyone, Here's a small report on the news that I have so far: 1. I had a slow couple of weeks because of a quick holiday that I took. I will make up for that. 2. I added the metric that considers number of test_runs since a test_case ran for the last time. I graphed it, and it

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-06-02 Thread Alexander Barkov
Hi Sergei, On 06/02/2014 06:01 PM, Sergei Golubchik wrote: Hi, Alexander! On Jun 02, Alexander Barkov wrote: Hello Sergei, Please find a new version of the patch that addresses your review suggestions. Also, see comments inline. Thanks. It looks like you've mistakenly attached the first v

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-06-02 Thread Sergei Golubchik
Hi, Alexander! On Jun 02, Alexander Barkov wrote: > Hello Sergei, > > Please find a new version of the patch that addresses your review > suggestions. Also, see comments inline. > > Thanks. It looks like you've mistakenly attached the first version of the patch. It's exactly identical to what y

Re: [Maria-developers] Possible race condition or NULL pointer triggered by OQGraph

2014-06-02 Thread Heinz Wiesinger
On Monday 02 June 2014 13:23:54 Sergei Golubchik wrote: > Hi, Andrew! > > On Jun 02, Andrew McDonnell wrote: > > Hi all > > > > (Cross-posted to oqgraph-developers, maria-developers) > > > > I am trying to track down a segfault apparently triggered by concurrent > > execution of queries through

Re: [Maria-developers] Possible race condition or NULL pointer triggered by OQGraph

2014-06-02 Thread Andrew McDonnell
Hi Sergei I cant, but Heinz has managed to (see https://mariadb.atlassian.net/browse/MDEV-6282) The value of lex at that point is NULL in the core I guess if that situation is impossible by design, this is more likely to be a memory overrun instead... In any case, I got Heinz to try my fix an

Re: [Maria-developers] Possible race condition or NULL pointer triggered by OQGraph

2014-06-02 Thread Sergei Golubchik
Hi, Andrew! On Jun 02, Andrew McDonnell wrote: > Hi all > > (Cross-posted to oqgraph-developers, maria-developers) > > I am trying to track down a segfault apparently triggered by concurrent > execution of queries through OQGraph - for context, see: > > https://mariadb.atlassian.net/browse/MDEV

Re: [Maria-developers] [GSoC] First two weeks into coding! - James' comments

2014-06-02 Thread James Briggs
Hi Sriram. I read your CREATE OR REPLACE DATABASE code and have some comments: 1) I noticed that you directly mysql_rm_db the database before creating it. Please ask your mentor if it would be better to rename it, obtain a successful create status, then delete the old db. Currently, if the disk

[Maria-developers] Possible race condition or NULL pointer triggered by OQGraph

2014-06-02 Thread Andrew McDonnell
Hi all (Cross-posted to oqgraph-developers, maria-developers) I am trying to track down a segfault apparently triggered by concurrent execution of queries through OQGraph - for context, see: https://mariadb.atlassian.net/browse/MDEV-6282 I am however a bit confused as to what is going on, becau