Re: [Maria-developers] JIRA ping

2014-12-12 Thread Kristian Nielsen
Jonas Oreland writes: > i addressed your comments and I uploaded 2 new patches to JIRA. > 1) a new "complete patch" > 2) a patch that is changes from v1 to v2. > the problem was that I didn't update info->last_pos and linfo->pos > correctly in send_format_descriptor_event > so the offsets were

Re: [Maria-developers] Review of MDEV-162: Enhanced semisync replication

2014-12-12 Thread Jonas Oreland
Hi again, uploaded dump-thread-enhancements.changes-v2-v3.patch which releases LOCK_binlog_end_pos while sending hb. and...to repeat, the dump-thread-enhancements is a prerequisite for this. /Jonas On Fri, Dec 12, 2014 at 1:56 PM, Kristian Nielsen wrote: > Jonas Oreland writes: > > > I think

Re: [Maria-developers] Review of MDEV-162: Enhanced semisync replication

2014-12-12 Thread Kristian Nielsen
Jonas Oreland writes: > I think it might be easier you just took and applied it to your favorite > branch (hence i'll won't send > a new version of the patch). Ok. > however there is one think that I discovered that needs to be fixed with > the interaction with > the Dump Thread Enhancement...I

Re: [Maria-developers] Review of MDEV-162: Enhanced semisync replication

2014-12-12 Thread Jonas Oreland
Hi there, I think it might be easier you just took and applied it to your favorite branch (hence i'll won't send a new version of the patch). however there is one think that I discovered that needs to be fixed with the interaction with the Dump Thread Enhancement...I'll add that patch to this or

[Maria-developers] Review of MDEV-162: Enhanced semisync replication

2014-12-12 Thread Kristian Nielsen
Jonas Oreland writes: Thanks for the MDEV-162 patch! Here is my review. I think the patch looks fine, and we should take it. Just a few questions below, and one minor comment: > === modified file 'mysql-test/suite/rpl/t/rpl_semi_sync.test' > --- mysql-test/suite/rpl/t/rpl_semi_sync.test 2014-0