Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-04-29 Thread Kristian Nielsen
Vicențiu Ciorbaru writes: > I've gotten to a "sort of" stable state with binlog_row_image. It's not > 100% complete as I did not add any tests for the new use cases. > Also there are a couple of changes that I am not 100% sure if they are > complete or correct. > > I would like some input on thes

Re: [Maria-developers] MDEV-7802 adding status variables - backport to 10.0 request

2015-04-29 Thread Kristian Nielsen
Jean-François Gagné writes: > On 2015-04-22 13:58, Kristian Nielsen wrote: >> Daniel Black writes: >> >>> I'm requesting a backport of MDEV-7802 >>> https://github.com/MariaDB/server/pull/30/files to 10.0 >> I don't mind putting the code in 10.0. >> >> However, normally we do not introduce new

Re: [Maria-developers] MDEV-7802 adding status variables - backport to 10.0 request

2015-04-29 Thread Daniel Black
- On 29 Apr, 2015, at 6:40 PM, Kristian Nielsen kniel...@knielsen-hq.org wrote: > So there were a couple of votes for backporting, and none against. So I will > push this into 10.0 as well. thank you very much. https://github.com/MariaDB/server/pull/30 ready to go. -- -- Daniel Blac

[Maria-developers] Likely a dead code in build_equal_items_for_cond()

2015-04-29 Thread Alexander Barkov
Hi Sanja and Igor, Can you please help to understand this pieces of code in sql_select.cc in 10.0: else if (cond->type() == Item::FUNC_ITEM || cond->real_item()->type() == Item::FIELD_ITEM) { It seems that the "cond->real_item()->type() == Item::FIELD_ITEM" part of this condi

Re: [Maria-developers] PLEASE REVIEW: (MDEV-7574) Security definer views don't work with CONNECT ODBC tables

2015-04-29 Thread Sergei Golubchik
Hi, Alexander! On Feb 24, Alexander Barkov wrote: > > There is only one problem with that. In case of embedded server > table->grant.privilege is always 0, because the embedded version > of check_table_access() is just an empty function. > > This change in sql/handler.cc, in handler::ha_external

Re: [Maria-developers] MDEV-7774: Crash when dropping user within rebuild_role_grants

2015-04-29 Thread Sergei Golubchik
Hi, Vicentiu! On Mar 13, vicen...@mariadb.org wrote: > revision-id: 22884d35e39ba078dddf5c15b42dd7e2ebb39c07 > parent(s): 184f718fef0101a7559364cb97e22ee568e64c12 > committer: Vicențiu Ciorbaru > branch nick: server > timestamp: 2015-03-13 20:12:22 +0200 > message: > > MDEV-7774: Crash when dropp

[Maria-developers] GSoC 2015 student

2015-04-29 Thread Blessing Atie
Hello everyone, My surname is Blessing and I am a student at University of Buea. I am very happy to be selected by MariaDb to part take in GSoC 2015. I will be working on Improving table Functions mentored Sergei Golubchik and I look forward to know him soon on #maria as well as the other student

Re: [Maria-developers] GSoC 2015 student

2015-04-29 Thread Sergei Golubchik
Hi, Atie! On Apr 29, Blessing Atie wrote: > Hello everyone, > My surname is Blessing and I am a student at University of Buea. I am very > happy to be selected by MariaDb to part take in GSoC 2015. Congratulations! > I will be working on Improving table Functions mentored Sergei Golubchik > an