Re: [Maria-developers] GSoC weekly reports (Unique indexes for blobs)

2016-07-27 Thread Shubham Barai
GSoC (week 9) InnoDB 1. After modifying row_merge_tuple_cmp to compare actual fields for the hash index, adding unique index through alter table was not working. It was due to tuples that were inserted in the order of user defined fields but for the hash index, they should have been inserted in

Re: [Maria-developers] 60d3489: MDEV-9143 JSON_xxx functions.

2016-07-27 Thread Sergei Golubchik
Hi, Alexey! Summary: no big problems found, no conceptual changes needed :) Still - I feel there was too much code copied around in item_jsonfunc.cc, better to reduce the code duplication. And in sql_json.cc - lots of complains about naming and absense of comments. I was mostly able to figure out

Re: [Maria-developers] Sachin weekly report

2016-07-27 Thread Sergei Golubchik
Hi, Sachin! On Jul 27, Sachin Setia wrote: > Hello Sergei! > Weekly Report for 9 week of gsoc > > Unique Long > > 1. Changed mysql_prepare_create function as suggested by you , now addition > of hash column will not be added in function start. > 2. Sorted out problem of full_hidden detection now