Re: [Maria-developers] MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler

Hi Nirbhay. On 11/25/2016 02:31 AM, Nirbhay Choubey wrote: Hi Bar, On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov > wrote: Hello Nirbhay, Can you please review a patch for 10.3: MDEV-11337 Split Item::save_in_field() into virtual

Re: [Maria-developers] MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler

Hi Bar, On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov wrote: > Hello Nirbhay, > > Can you please review a patch for 10.3: > MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler > > > It also automatically fixed two problems: > > MDEV-11331 Wrong

[Maria-developers] Please review MDEV-11347Move add_create_index_prepare(), add_key_to_list(), set_trigger_new_row(), set_local_variable(), set_system_variable(), create_item_for_sp_var() as methods t

Hello Sanja, Please review a patch for MDEV-11347. It turns a few other function into methods in LEX, to be able to reuse them easier. Thanks! commit 8ba89a6156fe05588146e15c582660922c33a086 Author: Alexander Barkov Date: Thu Nov 24 23:41:24 2016 +0400 MDEV-11347 Move

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > In which case is it lost ? > Can you add a test to federated_partition.test that shows in which case the > connection information is lost? when create a table like the following create table tbl_a( col_a int, primary key(col_a) )engine=myisam connection 'some settings for whole table'

Re: [Maria-developers] Please review a 10.3 patch "Moving functions cast_stmt_xxx and add_select_to_union_list as methods to LEX"

Hi, Alexander! On 11/24/2016 07:09 AM, Alexander Barkov wrote: Hello Sanja, As we agreed during our discussion on slack, we should port a few preparatory patches from bb-10.2-compatibility to 10.3, to make our further compatibility related development easier. This is the first patch. Please

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Thu, Nov 24, 2016 at 5:18 PM, Michael Widenius wrote: > Hi! > > On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote: >> Hi Monty! >> >> Thank you for starting this task. I appreciate it. >> >>> Kentoku, do you have patches for the test

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote: > Hi Monty! > > Thank you for starting this task. I appreciate it. > >> Kentoku, do you have patches for the test files, or should I just take >> them from the above spider branch or from somewhere else ? > > I just

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 4:31 PM, kentoku wrote: > Hi Monty! > > Please see comment at 2016-05-07 19:15 for patches for MariaDB 10.2. > >> I don't think this it will work removing the usage of p_elem->connect_string >> >> This is because each partition may have a

Re: [Maria-developers] MDEV-11344 Split Arg_comparator::set_compare_func() into virtual methods in Type_handler

Forgot to attach the file :) On 11/24/2016 04:28 PM, Alexander Barkov wrote: Hello Sanja, Can you please review a patch for MDEV-11344? Thanks. commit 1f76111b71a90e51251eb98f07f3a300b4b190de Author: Alexander Barkov Date: Thu Nov 24 16:26:30 2016 +0400 MDEV-11344

[Maria-developers] MDEV-11344 Split Arg_comparator::set_compare_func() into virtual methods in Type_handler

Hello Sanja, Can you please review a patch for MDEV-11344? Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help :