[Maria-developers] Errors in building debs

2017-03-31 Thread Sergey Petrunia
Hi Vicențiu, I'm looking at the last build in bb-10.2-mariarocks http://buildbot.askmonty.org/buildbot/builders/kvm-deb-trusty-x86/builds/3558/steps/compile/logs/stdio and I see this: + DH_BUILD_DDEBS=1 + echo + debian/autobake-deb.sh debian/autobake-deb.sh: line 80: [: i686: integer

Re: [Maria-developers] [Commits] 96403c5e124: Replace some unsigned integers with size_t to avoid type mismatch.

2017-03-31 Thread Sergey Petrunia
Hi Marko, Please find below the review for patch #1 of the "size_t patches": my comments are marked with 'psergey:' On Thu, Mar 30, 2017 at 02:39:50PM +0300, marko.mak...@mariadb.com wrote: > commit 96403c5e1240342948cb88600ece14c0c8b72dbc > Author: Marko Mäkelä >

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread jerome brauge
It's exactly the case. De : Vladislav Vaintroub [mailto:vvaintr...@gmail.com] Envoyé : vendredi 31 mars 2017 15:36 À : jerome brauge; Diego Dupin Cc : MariaDB Developers (maria-developers@lists.launchpad.net) Objet : Re: [Maria-developers] bb-10.2-compatibility - processlist On 31.03.2017

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread Vladislav Vaintroub
On 31.03.2017 15:17, jerome brauge wrote: Using connectionAttributes is not possible in case where you use a connection pool ... Dunno. Personally, I do not see it as impossible, and would like ApplicationName, ClientUser, ClientHostname for all clientside-pooled connections with the

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread jerome brauge
Using connectionAttributes is not possible in case where you use a connection pool ... De : Vladislav Vaintroub [mailto:vvaintr...@gmail.com] Envoyé : vendredi 31 mars 2017 14:44 À : jerome brauge; Diego Dupin Cc : MariaDB Developers (maria-developers@lists.launchpad.net) Objet : Re:

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread Vladislav Vaintroub
On 31.03.2017 14:35, jerome brauge wrote: Vladislav, It’s weird to implement setClientInfo without provide a way to see values (MySql Connector J only put values in a hashtable, I do not know what it is for !) On Oracle, Sybase, SQLServer and DB2, these values are pushed in processes

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread jerome brauge
Vladislav, It's weird to implement setClientInfo without provide a way to see values (MySql Connector J only put values in a hashtable, I do not know what it is for !) On Oracle, Sybase, SQLServer and DB2, these values are pushed in processes system view. As much as possible, we want avoid to

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread Vladislav Vaintroub
On 3/31/2017 12:16 PM, jerome brauge wrote: Hi Vladislav, As I understand is that this plugin allow user to see their own session variables. Here, we can see these information for each session (for monitoring purpose, licensing control, …) Is it correct ? Yes, I think you're

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread jerome brauge
Hi Vladislav, As I understand is that this plugin allow user to see their own session variables. Here, we can see these information for each session (for monitoring purpose, licensing control, ...) Is it correct ? Regards, Jérôme. De : Vladislav Vaintroub [mailto:vvaintr...@gmail.com] Envoyé :

Re: [Maria-developers] bb-10.2-compatibility - processlist

2017-03-31 Thread Vladislav Vaintroub
Hi Jerome, Bar is user_variables plugin not enough for that ? https://mariadb.com/kb/en/mariadb/information-schema-user_variables-table/ It is only one driver that sets these user variables, so it might not be worth to extend processlist even more for general case, just for that. On

Re: [Maria-developers] b4a223e3381: MDEV-10355 Weird error message upon CREATE TABLE with DEFAULT

2017-03-31 Thread Sergei Golubchik
Hi, Jacob! On Mar 30, Jacob Mathew wrote: > Hi Sergei, > > > 2. Why the test for FUNC_ITEM? I don't see any logical reason why > >skipping of "" should only apply to functions. > > > > ... I think this method could be like this: > > == > > void

[Maria-developers] Please review: MDEV-12416 OOM in create_virtual_tmp_table() makes the server crash

2017-03-31 Thread Alexander Barkov
Hello Alexey, can you please review a patch for MDEV-12416? Thanks! diff --git a/mysql-test/r/error_simulation.result b/mysql-test/r/error_simulation.result index edb97d4..e0ec26b 100644 --- a/mysql-test/r/error_simulation.result +++ b/mysql-test/r/error_simulation.result @@ -121,3 +121,12 @@ a

[Maria-developers] Please review MDEV-12415 Remove sp_name::m_qname

2017-03-31 Thread Alexander Barkov
Hello Sanja, can you please review a patch for MDEV-12415? Thanks! diff --git a/sql/event_parse_data.cc b/sql/event_parse_data.cc index 6c123c8..2cd8f5c 100644 --- a/sql/event_parse_data.cc +++ b/sql/event_parse_data.cc @@ -88,9 +88,6 @@ Event_parse_data::init_name(THD *thd, sp_name *spn)