[Maria-developers] review of MDEV-10177 Hidden columns

2017-09-28 Thread Sergei Golubchik
Hi, Sachin! Here's a review of all changes between 474f51711b1 and f0e2cf3e6c8: > diff --git a/include/my_base.h b/include/my_base.h > index b93300d7562..68c828d5f74 100644 > --- a/include/my_base.h > +++ b/include/my_base.h > @@ -277,7 +277,8 @@ enum ha_base_keytype { >This flag can be

Re: [Maria-developers] MDEV-13417 / MDEV - 13418 The order of evaluation of SELECT..INTO assignments

2017-09-28 Thread jerome brauge
Hello Alexander, Sergei, So I split it into two distinct patches. I've used the same idea in these two patches : For each field - stored the old value in record[1] (done by default for update) - evaluate fieId (in record[0]) - switch field pointer on record[1] Then restore all field pointer