Re: [Maria-developers] MDEV-13972 crash in Item_func_sec_to_time::get_date

Hi, Alexander! See comments below. TL;DR - dunno. Changes in behavior. Lots of code for overflow checks that is unused or duplicated. And only to avoid side effects with invalid arguments for SEC_TO_TIME() ? Perhaps, just check for val_str() returing NULL here and have the side effects fixed in

[Maria-developers] Please review MDEV-10802 TIMESTAMP NOT NULL field with explicit_defaults_for_timestamp and NO_ZERO_DATE shouldn't throw error

Hi Sergei, Please review a patch for MDEV-10802. Thanks! diff --git a/mysql-test/suite/sys_vars/inc/explicit_defaults_for_timestamp.inc b/mysql-test/suite/sys_vars/inc/explicit_defaults_for_timestamp.inc index 4cf3914..508363b 100644 --- a/mysql-test/suite/sys_vars/inc/explicit_defaults_for_times