[Maria-developers] MDEV-13550 is test case required?

2017-10-13 Thread Aleksey Midenkov
Hello! Do we have to write test cases for such coding errors? Because this is developer factor: either he does such errors or not. What are conditions of getting PR merged? ___ Mailing list: https://launchpad.net/~maria-developers Post to :

Re: [Maria-developers] MDEV-14013

2017-10-13 Thread jerome brauge
Hi Alexander, I agree, your code is more clearer. I've added your additional tests and done the pull request. Thank you very much. Jérôme. > -Message d'origine- > De : Alexander Barkov [mailto:b...@mariadb.org] > Envoyé : vendredi 13 octobre 2017 14:34 > À : jerome brauge;

Re: [Maria-developers] Please review MDEV-10802 TIMESTAMP NOT NULL field with explicit_defaults_for_timestamp and NO_ZERO_DATE shouldn't throw error

2017-10-13 Thread Alexander Barkov
Hello Sergei, Thanks for review. Please find a modified version attached. See comments below. On 10/13/2017 02:08 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Oct 07, Alexander Barkov wrote: >> Hi Sergei, >> >> Please review a patch for MDEV-10802. >> >> Thanks! > >> diff --git >>

Re: [Maria-developers] MDEV-14013

2017-10-13 Thread Alexander Barkov
Hello Jerome, Thank you very much for you contribution! On 10/11/2017 02:32 PM, jerome brauge wrote: > Hello Alexander, > Here is the patch for MDEV-14013, can you review it ? The patch looks very good. I only found small things: 1. LEX::make_text_literal_concat()

Re: [Maria-developers] [Commits] 06bb7ee: MDEV-10892 - rpl.rpl_semi_sync_uninstall_plugin fails with Assertion `0' failure

2017-10-13 Thread Sergei Golubchik
Hi, Sergey! On Oct 12, Sergey Vojtovich wrote: > revision-id: 06bb7eef9882536fc1d99b4462a65b53ec9f137e > (mariadb-5.5.57-14-g06bb7ee) > parent(s): 93aadda513d8b5c2b49001514e235c4fdd73e08a > committer: Sergey Vojtovich > timestamp: 2017-10-12 15:37:45 +0400 > message: > > MDEV-10892 -

Re: [Maria-developers] [Commits] 96e982b: MDEV-7140 - Sporadic buildbot failures in rpl.rpl_semi_sync_uninstall_plugin

2017-10-13 Thread Sergei Golubchik
Hi, Sergey! On Oct 12, Sergey Vojtovich wrote: > revision-id: 96e982bb1a72db47a41b97bb632b595b347d2956 > (mariadb-5.5.57-14-g96e982b) > parent(s): 93aadda513d8b5c2b49001514e235c4fdd73e08a > committer: Sergey Vojtovich > timestamp: 2017-10-12 14:42:17 +0400 > message: > > MDEV-7140 - Sporadic

Re: [Maria-developers] Please review MDEV-10802 TIMESTAMP NOT NULL field with explicit_defaults_for_timestamp and NO_ZERO_DATE shouldn't throw error

2017-10-13 Thread Sergei Golubchik
Hi, Alexander! On Oct 07, Alexander Barkov wrote: > Hi Sergei, > > Please review a patch for MDEV-10802. > > Thanks! > diff --git > a/mysql-test/suite/sys_vars/inc/explicit_defaults_for_timestamp.inc > b/mysql-test/suite/sys_vars/inc/explicit_defaults_for_timestamp.inc > index