Sergei,
On Sat, Oct 14, 2017 at 9:20 PM, Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 13, Aleksey Midenkov wrote:
>> Hello!
>>
>> Do we have to write test cases for such coding errors? Because this is
>> developer factor: either he does such errors or not. What are
>>
Hi, Aleksey!
On Oct 13, Aleksey Midenkov wrote:
> Hello!
>
> Do we have to write test cases for such coding errors? Because this is
> developer factor: either he does such errors or not. What are
> conditions of getting PR merged?
Generally it's preferrable to have a test case for all bugs
Hello Jerome,
On 10/13/2017 06:05 PM, jerome brauge wrote:
> Hi Alexander,
> I agree, your code is more clearer.
> I've added your additional tests and done the pull request.
I've merged and closed the pull request.
Thank you very much for cooperation!
>
> Thank you very much.
> Jérôme.
>
>
3 matches
Mail list logo