Re: [Maria-developers] MDEV-13997 Change Item_bool_rowready_func2 to cache const items at fix time rather than evaluation time

2017-10-27 Thread Alexander Barkov
Hello Sergei, On 10/26/2017 07:29 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Oct 04, Alexander Barkov wrote: >> Hello Sergei, >> >> Please review a patch for MDEV-13997. >> >> It's needed for: >> MDEV-13995 MAX(timestamp) returns a wrong result near DST change >> and for: >> MDEV-4912

Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-27 Thread Sergei Golubchik
Hi, Sergey! On Oct 26, Sergey Vojtovich wrote: > Hi Sergei, > > The only reason is there were minor requests to make it tunable. It is easier > to convert read-only var to command line option. > > If we know for sure that we won't do it, I can make it status var instead. As discussed on irc,

Re: [Maria-developers] Code syntax: questions on pointers, etc.

2017-10-27 Thread Sergei Golubchik
Hi, Aleksey! On Oct 23, Aleksey Midenkov wrote: > On Sun, Oct 22, 2017 at 10:27 PM, Sergei Golubchik wrote: > >> 2. It is still passed as a pointer to functions. Why is that? > >> > >> The main feature of C++ references is that it cannot be NULL, so we > >> get segfault on top