Re: [Maria-developers] -Wnon-virtual-dtor and scripts in

Hi Vlad, On 12/06/2017 04:29 PM, Vladislav Vaintroub wrote: > Hi Bar, > > > > Sure. There is a cmake file > https://github.com/MariaDB/server/blob/10.3/cmake/maintainer.cmake > which seems to become the place to customize GCC/Clang specific > warnings. I suppose you can add this flag there

Re: [Maria-developers] 78a1779: mysqldump fix for invisible column

Hi, Sachin! Looks fine. Two comments: 1. optimization idea, see below 2. add a test case that actually restores from the dump (and checks that it was restored correctly). mysqldump.test has examples, search for $MYSQL. After that - please push! On Dec 07, sachin wrote: >

Re: [Maria-developers] 339dd3d: Invisible Column mysqldump bug fix

Hi Serg! Thanks for the review! On Tue, Dec 5, 2017 at 7:01 PM, Sergei Golubchik wrote: > Hi, Sachin! > > Summary: > > 1. Add a test case, it should include a mix of tables with and without >invisible columns, and columns with strange names (reserved words, >spaces).