Re: [Maria-developers] [Commits] 4b4267288cb: MDEV-14743: Server crashes in Item_func_match::init_search

2018-01-12 Thread Oleksandr Byelkin
Hi, Sergei! Am 12.01.2018 um 17:37 schrieb Sergei Golubchik: Hi, Oleksandr! Two thoughts. 1. Please use if (!ifm->fixed) then you'll only need one #ifdef. OK, then I'll use __unlikely() also. 2. How does it work with the iterator? if you remove the current element from the

Re: [Maria-developers] [Commits] 4b4267288cb: MDEV-14743: Server crashes in Item_func_match::init_search

2018-01-12 Thread Sergei Golubchik
Hi, Oleksandr! Two thoughts. 1. Please use if (!ifm->fixed) then you'll only need one #ifdef. 2. How does it work with the iterator? if you remove the current element from the list and then iterator with jump to the next one, won't it cause one element to be skipped? On Jan 10,

[Maria-developers] Eliminating or replacing the InnoDB row_prebuilt_t::fetch_cache

2018-01-12 Thread Marko Mäkelä
The handler API in MySQL and MariaDB is operating on a single record at a time. There are some ‘batched’ primitives that in my understanding were developed for the NDB cluster, but generally InnoDB does not use them. The only nontrivial thing that InnoDB does during reads is the Index Condition