Re: [Maria-developers] MDEV-14849 CREATE + ALTER with user-invisible columns produce ...

2018-01-29 Thread Sergei Golubchik
Hi, Sachin! On Jan 29, Sachin Setiya wrote: > commit 5bd97f22094f3b6a658d503f98022ccd9076bb19 > Author: Sachin Setiya > Date: Mon Jan 29 12:31:07 2018 +0530 > > MDEV-14849 CREATE + ALTER with user-invisible columns produce ... > > Problem:- > create or

Re: [Maria-developers] MDEV-14785 SYSTEM_INVISIBLE behaviour not consistent ---Initial Patch

2018-01-29 Thread Sergei Golubchik
Hi, Sachin! On Jan 29, Sachin Setiya wrote: > commit 5e2f5aa78a5f53b000a2b9c6989c9ed7076e2527 > Author: Sachin Setiya Note the typo in your email ^ > Date: Mon Jan 29 17:09:32 2018 +0530 > > MDEV-14785 SYSTEM_INVISIBLE behaviour not consistent > > TODO

Re: [Maria-developers] [Commits] Mdev-15085 Rebased to latest 10.3

2018-01-29 Thread Sergei Golubchik
Hi, Sachin! On Jan 29, Sachin Setiya wrote: > commit 905806689979ae91c89115f18b107ebacbc489e2 > Author: Sachin Setiya > Date: Fri Jan 26 22:58:34 2018 +0530 > > Mdev-15085 Invisible Column Non-constant Default value results... > > Problem:- If we create

[Maria-developers] Wording suggestion?

2018-01-29 Thread Sergei Golubchik
Hi, Ian, Russell, As you know, UPDATE in MariaDB is executed left-to-right, say, in the case of UPDATE t1 SET a=b, b=a both columns will have the same value, old value of `b`. We're now introducing a new sql_mode to have standard compatible behavior, where all assignments are executed kind of

Re: [Maria-developers] MDEV-13790 UNHEX() of a somewhat complicated CONCAT() returns NULL

2018-01-29 Thread Sergei Golubchik
Hi, Alexander! On Jan 29, Alexander Barkov wrote: > Hi Sergei, > > Thanks for review. Comments follow inline: ok to push Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post

Re: [Maria-developers] MDEV-13790 UNHEX() of a somewhat complicated CONCAT() returns NULL

2018-01-29 Thread Alexander Barkov
Hi Sergei, Thanks for review. Comments follow inline: On 01/28/2018 07:22 PM, Sergei Golubchik wrote: Hi, Alexander! On Nov 03, Alexander Barkov wrote: Hello Sergei, Please review a patch for MDEV-13790. It removes the attempt to search the best suitable buffer and just returns the result