Re: [Maria-developers] 4b01d3aee60: MDEV-17082 Application-time periods: CREATE

Hi, Nikita! On Jan 31, Nikita Malyavin wrote: > revision-id: 4b01d3aee60 (versioning-1.0.7-2-g4b01d3aee60) > parent(s): 44144533e50 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2019-01-30 22:53:43 +1000 > message: > > MDEV-17082 Application-time periods: CREATE > > * add

Re: [Maria-developers] c39f74ce0d9: MDEV-16974 Application period tables: UPDATE

On Wed, Jan 30, 2019 at 3:50 AM Nikita Malyavin wrote: > Jan 9, 2019 06:09, Sergei Golubchik : > >> > --- /dev/null >> > +++ b/mysql-test/suite/period/t/update.opt >> > @@ -0,0 +1 @@ >> > +--explicit_defaults_for_timestamp >> >> Why? >> it's best to avoid non-default command line options, unless

Re: [Maria-developers] 83444b747f1: MDEV-16975 Application period tables: ALTER TABLE

Hi, Sergei! On Mon, Feb 4, 2019 at 11:49 PM Sergei Golubchik wrote: > > > > diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy > > > > index 10535326ce5..545c8f831b9 100644 > > > > --- a/sql/sql_yacc.yy > > > > +++ b/sql/sql_yacc.yy > > > > @@ -8190,6 +8195,10 @@ alter_list_item: > > > >

Re: [Maria-developers] f93af1f93e2: MDEV-12836 Avoid table rebuild when adding or removing of auto_increment settings

Hi, Eugene! On Feb 04, Eugene Kosov wrote: > > >   create table t1 (a int unique); > >   insert t1 values (NULL),(NULL),(NULL); > >   alter table t1 modify a int auto_increment; > > create table t1 (a int not null, unique key a_key (a)) engine=innodb; > insert into t1 values (19), (1), (100500);

Re: [Maria-developers] f93af1f93e2: MDEV-12836 Avoid table rebuild when adding or removing of auto_increment settings

Hi, Sergei! Thanks for you review. 04.02.2019, 21:59, "Sergei Golubchik" : > Hi, Eugene! > > On Feb 04, Eugene Kosov wrote: >>  revision-id: f93af1f93e2 (mariadb-10.3.12-19-gf93af1f93e2) >>  parent(s): d4144c8e010 >>  author: Eugene Kosov >>  committer: Eugene Kosov >>  timestamp: 2019-01-23 19

Re: [Maria-developers] f93af1f93e2: MDEV-12836 Avoid table rebuild when adding or removing of auto_increment settings

Hi, Eugene! On Feb 04, Eugene Kosov wrote: > revision-id: f93af1f93e2 (mariadb-10.3.12-19-gf93af1f93e2) > parent(s): d4144c8e010 > author: Eugene Kosov > committer: Eugene Kosov > timestamp: 2019-01-23 19:32:02 +0300 > message: > > MDEV-12836 Avoid table rebuild when adding or removing of auto_

Re: [Maria-developers] 83444b747f1: MDEV-16975 Application period tables: ALTER TABLE

Hi, Nikita! On Feb 04, Nikita Malyavin wrote: > On Fri, Jan 4, 2019 at 6:29 AM Sergei Golubchik wrote: > > > > +insert t values(@e, @s); > > > +ERROR 23000: CONSTRAINT `CONSTRAINT_1` failed for `test`.`t` > > > > Hmm. The standard, indeed, says "there's an implicit constraint". > > > > But it do

Re: [Maria-developers] ce91482: MDEV-17599 ALTER TABLE DROP CONSTRAINT does not work for foreign keys.

Hi, Alexey! Looks good, one comment below Ok to push On Feb 04, Alexey Botchkov wrote: > revision-id: ce91482df1af6935f81a2142d0ee9391feab2454 > (mariadb-10.2.21-45-gce91482) > parent(s): 97930df13c0e403940969ebb47398760b59f753c > committer: Alexey Botchkov > timestamp: 2019-02-04 12:57:57 +0400