Re: [Maria-developers] eb121bbe93e: Vanilla cleanups and refactorings

2021-09-10 Thread Sergei Golubchik
Hi, Aleksey! On Sep 10, Aleksey Midenkov wrote: > On Fri, Sep 10, 2021 at 9:32 PM Sergei Golubchik wrote: > > On Sep 10, Aleksey Midenkov wrote: > > > revision-id: eb121bbe93e (mariadb-10.6.1-78-geb121bbe93e) > > > parent(s): d90f54e2206 > > > author: Aleksey Midenkov > > > committer: Aleksey

Re: [Maria-developers] 818407474d6: MDEV-22166 CONVERT PARTITION: move out partition into a table

2021-09-10 Thread Aleksey Midenkov
Btw, Sergei, that MacOS problem in MDEV-22165 is not a showstopper, so I didn't investigate that. The main business was to get the task into usable/reviewable state. Probably that bug can be reproduced on vanilla, so I change my answer to "I don't know". On Sat, Sep 11, 2021 at 12:24 AM Aleksey

Re: [Maria-developers] 818407474d6: MDEV-22166 CONVERT PARTITION: move out partition into a table

2021-09-10 Thread Aleksey Midenkov
Hi Sergei, Monty! On Fri, Sep 10, 2021 at 10:02 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > I presume that changes to the logging code is what Monty asked. Not everything. I've done what I could in the current timeframe, the less important things were postponed. Didn't get his approval for

Re: [Maria-developers] eb121bbe93e: Vanilla cleanups and refactorings

2021-09-10 Thread Aleksey Midenkov
Hi, Sergei! On Fri, Sep 10, 2021 at 9:32 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Sep 10, Aleksey Midenkov wrote: > > revision-id: eb121bbe93e (mariadb-10.6.1-78-geb121bbe93e) > > parent(s): d90f54e2206 > > author: Aleksey Midenkov > > committer: Aleksey Midenkov > > timestamp:

Re: [Maria-developers] ff0ece70855: MDEV-26531: mtr shows some hunks failed

2021-09-10 Thread Sergei Golubchik
Hi, Anel! On Sep 10, Anel Husakovic wrote: > revision-id: ff0ece70855 (mariadb-10.6.1-73-gff0ece70855) > parent(s): 1bc82aaf0a7 > author: Anel Husakovic > committer: Anel Husakovic > timestamp: 2021-09-03 21:15:58 +0200 > message: > > MDEV-26531: mtr shows some hunks failed > > Reviewed by:

Re: [Maria-developers] 818407474d6: MDEV-22166 CONVERT PARTITION: move out partition into a table

2021-09-10 Thread Sergei Golubchik
Hi, Aleksey! I presume that changes to the logging code is what Monty asked. So I'll only comment on a couple of minor issues: On Sep 10, Aleksey Midenkov wrote: > revision-id: 818407474d6 (mariadb-10.6.1-80-g818407474d6) > parent(s): bb4b95975f7 > author: Aleksey Midenkov > committer: Aleksey

Re: [Maria-developers] eb121bbe93e: Vanilla cleanups and refactorings

2021-09-10 Thread Sergei Golubchik
Hi, Aleksey! On Sep 10, Aleksey Midenkov wrote: > revision-id: eb121bbe93e (mariadb-10.6.1-78-geb121bbe93e) > parent(s): d90f54e2206 > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: 2021-09-10 17:42:10 +0300 > message: > > diff --git a/dbug/tests.c b/dbug/tests.c > index

Re: [Maria-developers] 4645a1e1950: MDEV-26238: Remove inconsistent behaviour of --default-* options in my_print_defaults

2021-09-10 Thread Sergei Golubchik
Hi, Rucha! On Sep 08, Rucha Deodhar wrote: > Hi, Sergei ! > Thanks for the review. > > > > diff --git a/extra/my_print_defaults.c b/extra/my_print_defaults.c > > > index b7f52382721..e2ec0b00923 100644 > > > --- a/extra/my_print_defaults.c > > > +++ b/extra/my_print_defaults.c > > > @@ -48,20

Re: [Maria-developers] 6768e3a2830: MDEV-22166 MIGRATE PARTITION: move out partition into a table

2021-09-10 Thread Aleksey Midenkov
Hi Sergei, On Tue, Sep 7, 2021 at 12:34 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Sep 06, Aleksey Midenkov wrote: > > > > > > > > I believe ALTER TABLE atomicity is not the perfect one in respect of > > > > rollback on error so why should that be an example for me? > > > > > > let's

Re: [Maria-developers] b248988c8b6: MDEV-19275 Provide SQL service to plugins.

2021-09-10 Thread Sergei Golubchik
Hi, Alexey! On Sep 10, Alexey Botchkov wrote: > > For example, I'd think it connects to the current server, internally. > > But then, why does it need host and user? > > Initially i thought it can be put in the thread's security_ctx so functions > like CURRENT_USER > return these values. After

Re: [Maria-developers] b248988c8b6: MDEV-19275 Provide SQL service to plugins.

2021-09-10 Thread Alexey Botchkov
> For example, I'd think it connects to the current server, internally. > But then, why does it need host and user? Initially i thought it can be put in the thread's security_ctx so functions like CURRENT_USER return these values. After some more meditation i decided that it doesn't seem to be