I mean, I'd just put the reference to the head in the commit message, i. e.
now the last commit is
- test progress reporting f1af51e4
I'd add a line:
See unsquashed history at f1af51e4
In the final commit message
On Wed, 24 Nov 2021 at 23:50, Sergei Golubchik wrote:
> Hi, Nikita!
>
>
Hi, Nikita!
Sorry, I meant what did you mean by
> I would also embed a reference to the original unsquashed branch. It
> seems to me as a good idea in sense of helping the reader investigate
> the code
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
I mean, commits:
- test progress reporting
- open a read view for MVCC engines
- Forbid savepoints setup while ONLINE ALTER goes on
- decouple commit/rollback code from binlog hton
- report progress
- Add test for update after exclusive lock
- MENT-651 [8/8] add versioning
Hi, Nikita!
On Nov 24, Nikita Malyavin wrote:
> Sergei, I think all the commits starting from [4/8] ALTER ONLINE TABLE
> should be squashed.
>
> I will also add a better description in the commit message covering our
> latest discussions.
>
> I would also embed a reference to the original
Hi, Nikita!
On Nov 23, Nikita Malyavin wrote:
>
> Right. Adding as follows:
>
> Event_log is supposed to be a basic logging class that can write events in
> a single file.
>
> MYSQL_BIN_LOG in comparison will have:
> * rotation support
> * index files
> * purging
> * gtid, xid and other
Hi, Nikita!
On Nov 24, Nikita Malyavin wrote:
> >> > diff --git a/sql/sql_table.cc b/sql/sql_table.cc
> >> > index 29d0f487303..87dbe226c2e 100644
> >> > --- a/sql/sql_table.cc
> >> > +++ b/sql/sql_table.cc
> >> > @@ -11300,6 +11300,9 @@ static int online_alter_read_from_binlog(THD
> >> > *thd,
Hi, Nikita!
May be you don't need to truncate the transaction cache, but can log
SAVEPOINT and ROLLBACK TO SAVEPOINT as Query_log_event? That's easier.
Normal binlogging does it if the "transaction" modifies some
non-transactional tables. But you can just do it unconditionally.
Let's keep it as
Hi, Nikita!
On Nov 24, Nikita Malyavin wrote:
>
> The way to test with and without binlog is to rename .test in .inc and make
> a new test: one that sources have_binlog.inc, and one that doesn't.
>
> I don't like putting tests in .inc, so decided to leave only one version of
> it. Maybe that's
Hi Sergei,
Please find my input below.
> diff --git a/sql/sql_select.cc b/sql/sql_select.cc
> index 0dfe95e81b0..fa07608177a 100644
> --- a/sql/sql_select.cc
> +++ b/sql/sql_select.cc
> @@ -7910,28 +7910,27 @@ best_access_path(JOIN *join,
> can make an adjustment is a
9 matches
Mail list logo
