Re: [Maria-developers] 3617add6975: MDEV-27208: Extend CRC32() and implement CRC32C()

2022-01-03 Thread Sergei Golubchik
Hi, Marko! On Jan 03, Marko Mäkelä wrote: > revision-id: 3617add6975 (mariadb-10.6.1-252-g3617add6975) > parent(s): bc90f5d6967 > author: Marko Mäkelä > committer: Sergei Golubchik > timestamp: 2021-12-15 19:54:34 +0100 > message: > > MDEV-27208: Extend CRC32() and implement CRC32C() > > We

Re: [Maria-developers] 734aee3cd3c: MDEV-27018 IF and COALESCE lose "json" property

2022-01-03 Thread Sergei Golubchik
Hi, Alexander! > - We'll probably have more FORMATs in the future. Like what? As far as I can see, standard doesn't support FORMAT in the column definition at all. >Adding all format tests inside "normal" >Field_string/Field_varchar/Field_blob >is not a good idea. > > >> + */ > >>

Re: [Maria-developers] 8a84f5a40c1: MDEV-24176 Preparations

2022-01-03 Thread Sergei Golubchik
Hi, Aleksey! On Dec 29, Aleksey Midenkov wrote: > > > > > + /* > > > > > + NOTE: came from TABLE::alias_name_used and this is only a hint! > > > > > It works > > > > > + only in need_correct_ident() condition. On other cases it is > > > > > FALSE even if > > > > > + table_name is