Re: [Maria-developers] 24c653be25a: unpack_row: unpack a correct number of fields

Hello, Sergei, On Fri, 5 May 2023 at 23:28, Sergei Golubchik wrote: > > - for (field_ptr= begin_ptr; field_ptr < end_ptr && *field_ptr; > ++field_ptr) > > + for (field_ptr= begin_ptr; field_ptr < end_ptr > > + /* In Online Alter conv_table can be wider > than > > +

[Maria-developers] START ALTER replication test cases

Hi Sachin, Andrei, I'm looking at test cases for START ALTER / Lag-free Alter on Slave. And I happened to notice something in test case rpl.rpl_start_alter_bugs: --connection master set global binlog_alter_two_phase=true; # ... ALTER TABLE t1 DROP PRIMARY KEY; ALTER TABLE t1 ADD

Re: [Maria-developers] c5ce597f06a: MDEV-31043 ER_KEY_NOT_FOUND upon concurrent ALTER and transaction

> > > You forgot to address the following: > > > if (do_commit) > > { > > - // do not set STMT_END for last event to leave table open in > altering thd > > - error= binlog_flush_pending_rows_event(thd, false, true, binlog, > ); > > - if (is_ending_transaction) > > +