Hi Sergei,
On Tue, Feb 15, 2022 at 4:35 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> I've took a look at the whole diff bad1440325ba 9af2883e2692.
> (but without MDEV-16029)
>
> I have a couple of comments about minor issues, and a suggestion,
> please, see below. Nothing big, really.
>
> > di
ure merges.
>
> On Apr 20, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > On Tue, Apr 19, 2022 at 11:13 AM Sergei Golubchik wrote:
> > >
> > > Hi, Aleksey,
> > >
> > > On Apr 18, Aleksey Midenkov wrote:
> > > > >
> > &g
Hi Sergei!
On Tue, Apr 19, 2022 at 11:13 AM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> On Apr 18, Aleksey Midenkov wrote:
> > >
> > > I have a second patch that renames flags to have a very well-defined
> > > meaning and name.
> > >
&
Hi Sergei,
On Sun, Apr 17, 2022 at 8:48 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> > I attached the patch and this still fails rpl.create_or_replace_row.
>
> small mistake in the patch:
>
> > --- a/sql/sql_class.h
> > +++ b/sql/sql_class.h
> > @@ -2916,7 +2916,7 @@ class THD: public THD_coun
Hi Sergei!
On Fri, Apr 15, 2022 at 6:00 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> On Apr 13, Aleksey Midenkov wrote:
> > >
> > > No, quite the opposite.
> > > I think (see above) that CONTEXT_ANALYSIS_ONLY_VCOL_EXPR
> > > (it's set insid
ta() &&
> +thd->binlog_need_stmt_format(trans_table));
> res= thd->binlog_query(THD::ROW_QUERY_TYPE,
> thd->query(), thd->query_length(),
> trans_table, FALSE, FALSE, errcode);
Hi Sergei,
On Wed, Apr 13, 2022 at 8:18 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> On Apr 12, Aleksey Midenkov wrote:
> > > > > > +bool Vcol_expr_context::init()
> > > > > > +{
> > > > > > + /*
> > > > > >
Sergei,
On Wed, Apr 6, 2022 at 11:03 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> Thanks. I'll send a separate review email, there will be only replies
> here:
>
> On Apr 05, Aleksey Midenkov wrote:
> > Hi, Sergei!
> >
> > > > @@ -5709,8 +57
Hi Sergei!
On Thu, Apr 7, 2022 at 8:09 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> This is a review of `git diff 5fbbdbc85ba3 62d3496969db`
>
> Basically, no new comments, see below:
>
> On Apr 07, Aleksey Midenkov wrote:
>
> > diff --git a/libmariadb b
Hi, Sergei!
On Thu, Mar 31, 2022 at 11:30 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> Here's a review of the combined `git diff 4daf9d7c3ee0 f67dcf6ba5f2`:
>
> > diff --git a/mysql-test/suite/vcol/r/vcol_syntax.result
> > b/mysql-test/suite/vcol/r/vcol_syntax.result
> > index 0063f38ea36..c5
Hi, Sergey!
On Sun, Jan 9, 2022 at 4:53 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 09, Aleksey Midenkov wrote:
> > revision-id: 88f8aa20bba (mariadb-10.3.31-79-g88f8aa20bba)
> > parent(s): d5451867af1
> > author: Aleksey Midenkov
> > committer: Ale
Hi Sergei,
On Wed, Mar 2, 2022 at 10:33 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> On Feb 15, Aleksey Midenkov wrote:
> > > On Feb 12, Aleksey Midenkov wrote:
> > > > commit 0402f6dcb67
> > > > Author: Aleksey Midenkov
> > > > D
t; See a couple of comments below. Nothing big.
>
> On Feb 12, Aleksey Midenkov wrote:
> > commit 0402f6dcb67
> > Author: Aleksey Midenkov
> > Date: Tue Feb 8 22:54:03 2022 +0300
> >
> > diff --git a/sql/sql_delete.cc b/sql/sql_delete.cc
> > index 0403
Hi Sergei!
On Mon, Jan 17, 2022 at 7:56 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 13, Aleksey Midenkov wrote:
> > >
> > > But always using expr_arena doesn't necessarily seem to be a correct
> > > choice. E.g. Arg_comparator creates Item
lf in a different table. And if it's always in the same table,
> why to force it to find this table over and over?
That was the alias fix. Refix of Item_field was required. I returned
back cleanup_excluding_fields_processor() and removed VCOL_TABLE_ALIAS
processing despite my opinion t
Hi Sergei!
On Wed, Jan 12, 2022 at 8:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 12, Aleksey Midenkov wrote:
> > revision-id: ef70e809a40 (mariadb-10.3.31-80-gef70e809a40)
> > parent(s): 88f8aa20bba
> > author: Aleksey Midenkov
> > committer: Ale
Hi Sergei,
On Mon, Jan 3, 2022 at 2:44 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Dec 29, Aleksey Midenkov wrote:
> > > > > > + /*
> > > > > > + NOTE: came from TABLE::alias_name_used and this is only a
> > > > >
Hi Sergei!
On Tue, Dec 28, 2021 at 12:03 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Oct 18, Aleksey Midenkov wrote:
> > On Sun, Oct 17, 2021 at 4:55 PM Sergei Golubchik wrote:
> > > On Oct 17, Aleksey Midenkov wrote:
> > > > commit 8a84f
Hi, Sergei!
On Mon, Dec 6, 2021 at 11:22 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Dec 05, Aleksey Midenkov wrote:
> > > > diff --git a/sql/sql_base.cc b/sql/sql_base.cc
> > > > index ac22a63bdba..459edb614f7 100644
> > > > ---
Hi Sergei,
On Tue, Nov 23, 2021 at 11:29 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> This is a review of diff b95c5105e2 2552bce607
>
> This was quite good, thanks! Just a couple of questions/comments, see
> below.
>
> On Nov 23, Aleksey Midenkov wrote:
>
>
Hi Sergei!
On Sun, Oct 17, 2021 at 4:55 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Oct 17, Aleksey Midenkov wrote:
> > commit 8a84f5a40c1
> > Author: Aleksey Midenkov
> > Date: Thu May 27 17:00:14 2021 +0300
> >
> > MDEV-24176 Prepar
Hi, Sergey!
On Sat, Sep 11, 2021 at 12:45 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 10, Aleksey Midenkov wrote:
> > On Fri, Sep 10, 2021 at 9:32 PM Sergei Golubchik wrote:
> > > On Sep 10, Aleksey Midenkov wrote:
> > > > revision-id: eb12
I could in the current timeframe, the
> less important things were postponed. Didn't get his approval for that
> though, so I'm asking now whether the current state of patch is OK to
> push from his POV?
>
> > So I'll only comment on a couple of minor issues:
>
t get his approval for that
though, so I'm asking now whether the current state of patch is OK to
push from his POV?
> So I'll only comment on a couple of minor issues:
>
> On Sep 10, Aleksey Midenkov wrote:
> > revision-id: 818407474d6 (mariadb-10.6.1-80-g818407474d6)
Hi, Sergei!
On Fri, Sep 10, 2021 at 9:32 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 10, Aleksey Midenkov wrote:
> > revision-id: eb121bbe93e (mariadb-10.6.1-78-geb121bbe93e)
> > parent(s): d90f54e2206
> > author: Aleksey Midenkov
> > committer: Ale
Hi Sergei,
On Tue, Sep 7, 2021 at 12:34 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 06, Aleksey Midenkov wrote:
> > > >
> > > > I believe ALTER TABLE atomicity is not the perfect one in respect of
> > > > rollback on error so why sho
Sergei,
On Wed, Sep 1, 2021 at 8:51 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Aug 27, Aleksey Midenkov wrote:
> > >
> > > I still don't quite understand why did you introduce a new method
> > > with frm backup and a (low proba
Hi Sergei!
On Thu, Sep 2, 2021 at 5:13 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > On Wed, Sep 1, 2021 at 10:20 PM Sergei Golubchik wrote:
> > > On Sep 01, Aleksey Midenkov wrote:
> > > > > >
> >
T TABLE tbl_name TO PARTITION (partition definition)
>ALTER TABLE ... CONVERT PARTITION part_name TO TABLE tbl_name
>
> I also think it conveys the meaning better.
Yes, CONVERT looks more natural. Updated the code.
>
> Regards,
> Sergei
> VP of MariaDB Server Engineering
>
Sergei,
On Wed, Sep 1, 2021 at 10:35 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > On Wed, Sep 1, 2021 at 10:13 PM Sergei Golubchik wrote:
> > > On Sep 01, Aleksey Midenkov wrote:
> > > &
Sergei,
On Wed, Sep 1, 2021 at 10:20 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > > >
> > > > Looks like IF_DBUG is superfluous macro and should be replaced by
> > > >
> > > > #ifndef DBU
Sergei,
On Wed, Sep 1, 2021 at 10:13 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > > >
> > > > +move_out_partition:
> > > > +MIGRATE_SYM PARTITION_SYM
> > > > +| MIGRATE_SYM OU
Sergei,
On Wed, Sep 1, 2021 at 9:07 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > >
> > > We have a series of IF_xxx(A,B) macros, IF_PARTITIONING, IF_WIN, etc.
> > > IF_DBUG(A,B) expands to A if dbug is compiled i
Sergei,
On Wed, Sep 1, 2021 at 8:21 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > revision-id: dc2ace70f1b (mariadb-10.6.1-68-gdc2ace70f1b)
> > parent(s): 19fbfab084f
> > author: Aleksey Midenkov
> > committer: Alekse
Hi, Sergei!
On Wed, Sep 1, 2021 at 2:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Aug 30, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > Updated bb-10.7-midenok-MDEV-22166 is d4668e7254c6
>
> I'll look right after replying to this e
Hi Sergei!
On Wed, Sep 1, 2021 at 3:46 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Sep 01, Aleksey Midenkov wrote:
> > revision-id: 19fbfab084f (mariadb-10.6.1-67-g19fbfab084f)
> > parent(s): 8009680fbc3
> > author: Aleksey Midenkov
> > committer: Ale
Hi Sergei!
Updated bb-10.7-midenok-MDEV-22166 is d4668e7254c6
On Thu, Aug 26, 2021 at 9:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Some replies.
>
> On Aug 26, Aleksey Midenkov wrote:
> > > > diff --git a/sql/lex.h b/sql/lex.h
> > > > index cbf
Hi Sergei!
On Fri, Aug 27, 2021 at 3:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Aug 26, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > The updated branch is cabd0530 bb-10.7-midenok-MDEV-22166
>
> Commits
>
> cabd0530426 Parser refacto
the 3-command
> sequence, so non-atomic. But, of course, making it atomic makes perfect
> sense.
>
> See other comments below.
>
> On Aug 23, Aleksey Midenkov wrote:
> > commit 6768e3a2830
> > Author: Aleksey Midenkov
> > Date: Thu Jul 29 22:54:12 20
sey!
>
> On Aug 23, Aleksey Midenkov wrote:
> > revision-id: f14cfd22115 (mariadb-10.6.1-63-gf14cfd22115)
> > parent(s): 03225474d60
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
> > timestamp: 2021-08-17 20:01:48 +0300
> >
Hi Sergei!
On Mon, Jul 26, 2021 at 7:35 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jul 23, Aleksey Midenkov wrote:
> > Now updated the patch to
> >
> > git diff dfa2d0bc13..9b564832e3
>
> Thanks, no new comments about it. Just one question be
Hi Sergei!
Now updated the patch to
git diff dfa2d0bc13..9b564832e3
On Wed, Jul 21, 2021 at 11:33 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> As before, despite the email subject, it's
>
> git diff dfa2d0bc13..e533b5fb307
>
> Don't be confused :)
>
Hi Sergei!
The rebased patches are in
bb-10.7-midenok-MDEV-17554
Do we have open questions on review?
On Thu, Jun 3, 2021 at 1:52 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> On Thu, Jun 3, 2021 at 12:27 PM Aleksey Midenkov wrote:
> >
> > Sergei,
> >
> > On
Hi Sergei!
On Tue, Jun 8, 2021 at 3:04 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 08, Aleksey Midenkov wrote:
> > revision-id: b3844107287 (mariadb-10.5.2-424-gb3844107287)
> > parent(s): 27d66d644cf
> > author: Aleksey Midenkov
> > committer: A
Hi Sergei!
On Thu, Jun 3, 2021 at 1:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 26, Aleksey Midenkov wrote:
> > On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
> > > On Nov 03, Aleksey Midenkov wrote:
> > >
> > > And please, pre
t; fix before the next release.
>
> On Jun 01, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > Users could benefit from this fix of MDEV-18734 since the last
> > changes. Do you really think the open questions left are so important
> > for this bug to be still not
Sergei,
On Thu, Jun 3, 2021 at 12:27 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> On Thu, Jun 3, 2021 at 11:30 AM Sergei Golubchik wrote:
> >
> > Hi, Aleksey!
> >
> > On Jun 03, Aleksey Midenkov wrote:
> > > On Wed, Jun 2, 2021 at 11:37 PM Sergei
Sergei,
On Thu, Jun 3, 2021 at 11:30 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 03, Aleksey Midenkov wrote:
> > On Wed, Jun 2, 2021 at 11:37 PM Sergei Golubchik wrote:
> > > On Jun 02, Aleksey Midenkov wrote:
> > > > On Wed, Jun 2, 2021 at 9
Sergei,
On Wed, Jun 2, 2021 at 11:37 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > On Wed, Jun 2, 2021 at 9:06 PM Sergei Golubchik wrote:
> > >
> > > On Jun 02, Aleksey Midenkov wrote:
> > > > &
Sergei,
On Wed, Jun 2, 2021 at 9:06 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > > > > > > >
> > > > > > > > - if (!(sql_lock= (MYSQL_LOCK*)
> > &
Sergei,
On Wed, Jun 2, 2021 at 2:00 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > > > > > diff --git a/mysql-test/suite/versioning/t/partition.test
> > > > > > b/mysql-test/suite/versioning/t/partition.test
Hi Sergei!
I'm sorry, what other I can say apart from commits descriptions? This
code fixes the roots of problems while you suggest to keep bugs
masked.
On Wed, Jun 2, 2021 at 3:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 02, Aleksey Midenkov wrote:
> > r
Sergei,
On Wed, Jun 2, 2021 at 12:06 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 01, Aleksey Midenkov wrote:
> > > > +# Don't auto-create new partition on DELETE HISTORY:
> > > > +set timestamp= unix_timestamp('2000-01-01 00:00:00'
Hi Sergei!
Users could benefit from this fix of MDEV-18734 since the last
changes. Do you really think the open questions left are so important
for this bug to be still not pushed?
On Tue, Jan 26, 2021 at 1:51 AM Aleksey Midenkov wrote:
>
> Hi Sergei,
>
> On Tue, Dec 22, 2020 at 7:
22158b3c05a,
> so not only commit 38a888da0f1.
>
> The main thing below - I didn't understand a couple of changes and asked
> for clarifications.
>
> On May 30, Aleksey Midenkov wrote:
> > revision-id: 38a888da0f1 (mariadb-10.5.2-653-g38a888da0f1)
> > parent(s): bc
ergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 27, Aleksey Midenkov wrote:
> > > On Apr 06, Aleksey Midenkov wrote:
>
> > > > To be able to specify them in INSERT command they must be at least
> > > > user-invisible. Sys
Sergei,
sorry, I forgot to add that implementation with @@force_fields_visible
is cleaner and shorter. Also that helps to deprecate sysvers_show and
MDEV-16587 which I would greatly appreciate.
On Tue, Apr 27, 2021 at 4:07 PM Aleksey Midenkov wrote:
>
> Hi Sergei!
>
> On Tue, Apr
Hi Sergei!
On Tue, Apr 6, 2021 at 3:29 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 06, Aleksey Midenkov wrote:
> > > > But, since we need to specify implicit system fields we cannot
> > > > avoid adding one more session variable. In
Hi, Sergei!
On Mon, Apr 12, 2021 at 8:46 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 12, Aleksey Midenkov wrote:
> > On Mon, Apr 12, 2021 at 3:14 PM Sergei Golubchik wrote:
> > >
> > > On Apr 11, Aleksey Midenkov wrote:
> > > >
Hi Sergei,
On Mon, Apr 12, 2021 at 3:14 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 11, Aleksey Midenkov wrote:
> >
> > It was a conscious choice. Quantitative characteristic is implied.
>
> This isn't going anywhere.
Of course. And because of that
Hi Sergei,
On Sun, Apr 11, 2021 at 7:21 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 11, Aleksey Midenkov wrote:
> > On Sat, Apr 10, 2021 at 11:12 PM Sergei Golubchik wrote:
> > > On Apr 09, Aleksey Midenkov wrote:
> > > > > &g
Hi Sergei,
On Sat, Apr 10, 2021 at 11:12 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 09, Aleksey Midenkov wrote:
> > > >
> > > > --echo # Increment from 3 to 5
> > > > --echo # Increment from 3 to 6, manual names, LOCK TABLES
> &
Hi Sergei,
On Thu, Apr 8, 2021 at 3:30 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 07, Aleksey Midenkov wrote:
> > > > +
> > > > +--echo # INSERT, INSERT .. SELECT don't increment partitions
> > >
> > > it's not reall
Hi Sergei,
On Sun, Apr 4, 2021 at 2:48 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Note, it's a review of the `git diff 82e44d60d1e 8175ce8a5f1`
> so it's not only commit c4de76aeff8
>
> On Apr 04, Aleksey Midenkov wrote:
> > revision-id: c4de76a
Hi Sergei,
On Mon, Apr 5, 2021 at 8:04 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 26, Aleksey Midenkov wrote:
> > > > >
> > > > > In other words, if one can create an arbitrary history by
> > > > > manipulating @@timestamp vari
ake another look or it's on you now?
>
> I think I've never got a reply to this question.
> Shall I take another look at the bb-10.6-midenok-MDEV-17554 branch or
> not yet?
I've updated the branch on top of the latest 10.6. Please go ahead and
take a look.
>
> &
Sergei,
On Thu, Feb 25, 2021 at 11:09 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 25, Aleksey Midenkov wrote:
> > > On Nov 24, Aleksey Midenkov wrote:
> > > > 1. Add server variable system_versioning_insert_history which will
> > >
Hi, Sergei!
On Tue, Dec 1, 2020 at 7:54 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Nov 24, Aleksey Midenkov wrote:
> >
> > And mysqldump should take care of setting system_versioning_insert_history
> > sysvar. Right? Is everything else in the task descripti
Hi Sergei,
On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Nov 03, Aleksey Midenkov wrote:
> >
> > the updated patches are here:
> >
> > https://github.com/MariaDB/server/commits/5f6bcd6cd0145513974b0dfc5b2cefba28b72f1a
>
>
Hi Sergei!
On Tue, Sep 22, 2020 at 8:31 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> Wow, this comes so late, sorry! :(
>
> But it's fixVersion=10.6 and on the top my list, so here you are.
>
> On May 07, Aleksey Midenkov wrote:
> > >
>
Hi Sergei!
The updated patches are here:
https://github.com/MariaDB/server/commits/2c2e79487a9189e02fce8f884a9ab2b42b9aa333
On Tue, Nov 3, 2020 at 8:28 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> the updated patches are here:
>
>
https://github.com/Mari
commit, but the diff below includes all three commits that mention
MDEV-18734.
>
> On Nov 02, Aleksey Midenkov wrote:
> > revision-id: 2f9bbf392072 (mariadb-10.2.31-543-g2f9bbf392072)
> > parent(s): 1f4960e3f2ac
> > author: Aleksey Midenkov
> > committer: Aleksey
Sergei,
On Sat, Oct 31, 2020 at 12:54 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Oct 25, Aleksey Midenkov wrote:
> > On Wed, Oct 21, 2020 at 4:19 PM Sergei Golubchik
wrote:
> > > On Oct 20, Aleksey Midenkov wrote:
> > > > revision-id: 0cd537
Hi Sergei!
On Wed, Oct 21, 2020 at 4:19 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 20, Aleksey Midenkov wrote:
> > revision-id: 0cd5377e9ff (mariadb-10.2.31-357-g0cd5377e9ff)
> > parent(s): dc716da4571
> > author: Aleksey Midenkov
> > committer: Alek
Hi Sergei!
On Wed, Jul 1, 2020 at 12:26 AM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jun 29, Aleksey Midenkov wrote:
> > revision-id: 9bf4b92cbc5 (mariadb-10.5.2-168-g9bf4b92cbc5)
> > parent(s): 478301d9b9a
> > author: Aleksey Midenkov
> > committer: A
t really see
> how update_virtual_field() can ever get an error. But it's not a
> particularly future-proof approach. And I just might be wrong about
> errors.
>
> On Apr 23, Aleksey Midenkov wrote:
> > revision-id: 7d593466a22 (mariadb-10.2.28-4-g7d593466a22)
>
Sergei,
On Tue, May 19, 2020 at 1:52 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On May 19, Aleksey Midenkov wrote:
> > > > diff --git a/mysql-test/suite/versioning/engines.combinations
> > > > b/mysql-test/suite/versioning/engines.combinations
> >
d1 the one I was supposed to review?
Yes.
>
> On May 17, Aleksey Midenkov wrote:
> > revision-id: b97e45651d1 (mariadb-10.4.7-33-gb97e45651d1)
> > parent(s): 7587975bf06
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
> > timestamp: 2019-08-1
er. Disagree?
>
> And for the test - please add the case for a table with no PRIMARY KEY, bug
> with the UNIQUE instead.
>
> Best regards!
> HF
>
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list: https://launc
9:25 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 09, Aleksey Midenkov wrote:
> > > > +#
> > > > +# MDEV-17554 Auto-create new partition for system versioned tables
> > > > with history partitioned by INTERVAL/LIMIT
> > >
Hi, Sergei!
On Tue, Apr 7, 2020 at 3:03 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Apr 07, Aleksey Midenkov wrote:
> > revision-id: 9941c6a3179 (mariadb-10.5.2-164-g9941c6a3179)
> > parent(s): 920c3c6b237
> > author: Aleksey Midenkov
> > committer: A
Sergei,
On Wed, Feb 19, 2020 at 8:27 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 18, Aleksey Midenkov wrote:
> > On Mon, Feb 17, 2020 at 8:23 PM Sergei Golubchik wrote:
> > > On Feb 17, Aleksey Midenkov wrote:
> > > > On Sat, Nov 9, 2019 at 12
Sergei,
On Mon, Feb 17, 2020 at 8:23 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Feb 17, Aleksey Midenkov wrote:
> > Hi Sergei!
> >
> > On Sat, Nov 9, 2019 at 12:03 AM Sergei Golubchik wrote:
> > >
> > > Hi, Aleksey!
> > >
&g
d if we'll want to change it to "pp%u" it should
> be done only in one place.
>
Done.
> 2. don't overload operators, use, say,
>
> bool greater_than(size_t seconds)
>
Done.
> But overall it's pretty good. A nice idea with a separate thread.
&g
Hi, Sergei!
On Wed, Jan 1, 2020 at 4:07 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Jan 01, Aleksey Midenkov wrote:
> > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote:
> > > On Dec 22, Aleksey Midenkov wrote:
> >
> > My concern is mostly ab
Hi, Sergei!
On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 22, Aleksey Midenkov wrote:
> > > >
> > > > Particularly to this function I don't like its name, semantics and
> > > > signature.
> > >
&g
Hi, Sergei!
On Thu, Dec 19, 2019 at 11:32 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik
> wrote:
> > > On Dec 18, Aleksey Midenkov wrote:
> > > > On Wed, Dec 18, 20
Sergei,
On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > Sergei,
> >
> > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik
> wrote:
> >
> > > Hi, Aleksey!
> > >
> > >
Sergei,
On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 18, Aleksey Midenkov wrote:
> > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote:
> >
> > But it's better to be from the other side:
> >
> > bool L
ins and use class methods instead. We can't use THD directly
though, because we don't want it compiled in plugins. So we compile
non-inline methods in server that are used in plugin.
--
All the best,
Aleksey Midenkov
@midenok
___
Mailing list
Hi, Sergei!
On Fri, Dec 6, 2019 at 5:34 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Dec 05, Aleksey Midenkov wrote:
> > >
> > > > 3. Invalidate referenced shares on:
> > > >
> > > > - RENAME TABLE
> > > > - DROP TABLE
Hi Sergei!
On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> Just a question for now
> (and a couple of style comments, I didn't look at the logic yet)
>
> On Dec 04, Aleksey Midenkov wrote:
> > revision-id: c91ec05e01b (mariadb-10.4.4-4
Sergei,
On Thu, Oct 31, 2019 at 2:03 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 30, Aleksey Midenkov wrote:
> > On Fri, Oct 25, 2019 at 9:44 PM Sergei Golubchik
> wrote:
> > > On Oct 25, Aleksey Midenkov wrote:
> > > > revision-id: d5352
Hi Sergei,
On Thu, Sep 26, 2019 at 4:15 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Sep 26, Aleksey Midenkov wrote:
> > revision-id: f6269a85ad7 (mariadb-10.4.7-38-gf6269a85ad7)
> > parent(s): a9ca752f1a9
> > author: Aleksey Midenkov
> > committer: Aleksey
Hi Sergei,
On Fri, Oct 25, 2019 at 9:44 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Oct 25, Aleksey Midenkov wrote:
> > revision-id: d5352b8154d (mariadb-10.2.25-54-gd5352b8154d)
> > parent(s): 1153950ad0a
> > author: Aleksey Midenkov
> > committer: Alek
Hi Sergei!
Fixed in `bb-10.3-midenok`.
On Fri, Aug 30, 2019 at 8:49 PM Sergei Golubchik wrote:
> Hi, Aleksey!
>
> On Aug 30, Aleksey Midenkov wrote:
> > revision-id: c3d2998a038 (versioning-1.0.3-71-gc3d2998a038)
> > parent(s): 611488e3d90
> > author: Aleksey Miden
please move clear_error() to the caller
> (ha_innodb.cc) and remove the assert.
>
> On Jul 04, Aleksey Midenkov wrote:
> > revision-id: 4670c85a48c (mariadb-10.4.5-47-g4670c85a48c)
> > parent(s): 0f55a9eb73b
> > author: Aleksey Midenkov
> > committer: Aleksey Midenkov
&
Hi Sergei!
On Fri, Jun 7, 2019 at 8:45 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Looks ok, thanks!
> No requests to change anything,
> but still a couple of "why" questions, see below
>
> On Jun 07, Aleksey Midenkov wrote:
> > revision-id: 66f93
, so
you'll have to find out your own codes via tack utiity. With strong
will and enough patience it is possible to add Ctrl+, Alt+, Shift+ and
their combinations as well.
This works only with MDEV-17609 patch.
--
All the best,
Aleksey Midenkov
@midenok
Hello, Sergei!
On Fri, May 3, 2019 at 8:43 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On May 03, Aleksey Midenkov wrote:
> > revision-id: ef2519fee4e (versioning-1.0.5-17-gef2519fee4e)
> > parent(s): 56145be2951
> > author: Aleksey Midenkov
> > commit
1 - 100 of 131 matches
Mail list logo
