Re: [Maria-developers] [Commits] e446bf7: MDEV-12145: Wrong result (missing rows) on query with IN and EXISTS subqueries from InnoDB tables

2017-04-04 Thread Igor Babaev
Varun, 1. The mdev # in the test case should be 12145 2. Could you please explain why do you need > @@ -9735,8 +9735,7 @@ make_join_select(JOIN *join,SQL_SELECT *select,COND *cond) >!(used_tables & tab->emb_sj_nest->sj_inner_tables)) >{ > save_used_tables= used_table

Re: [Maria-developers] Fwd: Do we have anywhere some code that copies from one internal tmp table into another?

2016-04-22 Thread Igor Babaev
On 04/22/2016 03:10 PM, Sergei Golubchik wrote: > Hi, Igor! > > On Apr 15, Igor Babaev wrote: >> >> Please help me if you are aware of such code. >> In my case the tables are similar. >> I understand that it's easy to write this code. >> (Read rows f

[Maria-developers] Fwd: Do we have anywhere some code that copies from one internal tmp table into another?

2016-04-15 Thread Igor Babaev
Hi, Please help me if you are aware of such code. In my case the tables are similar. I understand that it's easy to write this code. (Read rows from the source table one by one updating the destination table). Still I would prefer to use the existing code. Regards, Igor. __

Re: [Maria-developers] Window functions: compare_window_spec_joined_lists() has a bug

2016-04-04 Thread Igor Babaev
Sergey, I fixed the problem and pushed the fix. Regards, Igor. On 04/04/2016 01:15 PM, Sergey Petrunia wrote: > Hello Igor, > > I'm trying this example: > > create table t1 (a int, b int); > insert into t1 values (1,1),(2,2),(3,3); > > select rank() over (order by a), rank() over (order by b)

Re: [Maria-developers] [Commits] Rev 4227: MDEV-6441: memory leak in file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6441/

2014-07-29 Thread Igor Babaev
Sanja, Correct the comment for the commit and push. The only question I have concerns another comment: +# MDEV-5515: sub-bug nets of 3rd execution crash ^ Is this an intended word? Regards, Igor. On 07/28/2014 05:36 AM, sa...@askmonty.org wrote: > At file:///home/bell/mari

Re: [Maria-developers] Proposal for: MDEV-5244: Make extended_keys=ON by default in 10.0

2014-02-21 Thread Igor Babaev
On 02/21/2014 04:14 PM, Sergey Petrunia wrote: > Hello, > > I was looking at how to make extended_keys=ON by default in 10.0. > > There haven't been any bugs in the feature for quite some time, but we still > have a question of how to be with the testsuite (do we run it with > extended_keys=OFF,

Re: [Maria-developers] On how to fix indentation and history in sql_join_cache.cc

2013-10-10 Thread Igor Babaev
On 10/10/2013 07:42 AM, Sergei Petrunia wrote: > Hi Sanja, > > My experiment was successfull. It seems, one can fix identation in > sql_join_cache.cc so in the following way: Great! Regards, Igor > > # Create a branch in a state "right after the problem" > bzr branch -rsa...@askmonty.org-201

Re: [Maria-developers] mysql 5.6, 5.7

2013-06-18 Thread Igor Babaev
easily extracted from the debug trace. The most important: the optimizer trace does not actually explain WHY the chosen alternative is REALLY better than rejected ones: the calculation of the costs remains under the cover. Regards, Igor. > Just my $.02. > > -Zardosht > > On M

Re: [Maria-developers] mysql 5.6, 5.7

2013-06-17 Thread Igor Babaev
On 06/17/2013 04:24 PM, Roberto Spadim wrote: > hi guys, i was reading mysql 5.6 and 5.7 manual > i know that mariadb is very different (a bit) than mysql internally > there's a mysql merge issue or something like that i can see what will > be merged and what not? > > i like the partition lock pru

Re: [Maria-developers] MariaDB 10.0.2-alpha release prep

2013-04-23 Thread Igor Babaev
On 04/22/2013 03:45 PM, Daniel Bartholomew wrote: > I've begun prepping MariaDB 10.0.2-alpha for release. > > Draft changelog and release notes are here: > - https://kb.askmonty.org/en/mariadb-1002-release-notes/ > - https://kb.askmonty.org/en/mariadb-1002-changelog/ Daniel, Don't forget about

Re: [Maria-developers] Rev 3701: Fixed bug mdev-4311

2013-03-25 Thread Igor Babaev
t; Any reason this will not work? > > On Sun, Mar 24, 2013 at 10:20:41AM -0700, Igor Babaev wrote: >> On 03/24/2013 08:37 AM, Sergei Golubchik wrote: >>> Hi, Igor! >>> >>> On Mar 22, Igor Babaev wrote: >>>> At file:///home/igor/maria/maria-5.5-bu

Re: [Maria-developers] Rev 3701: Fixed bug mdev-4311

2013-03-24 Thread Igor Babaev
On 03/24/2013 08:37 AM, Sergei Golubchik wrote: > Hi, Igor! > > On Mar 22, Igor Babaev wrote: >> At file:///home/igor/maria/maria-5.5-bug4311/ >> >> >> revno: 3701 >> revision-id: i...@askmo

Re: [Maria-developers] Determining to which project a patch should be sent.

2013-02-19 Thread Igor Babaev
We touched a lot of functions, but only a few of them were added by MariaDB. Regards, Igor. > > - Christian > > On Tue, Feb 19, 2013 at 10:46 PM, Igor Babaev wrote: >> On 02/19/2013 04:59 PM, Christian Convey wrote: >>> Hi guys, >>> >>> As I work throug

Re: [Maria-developers] Determining to which project a patch should be sent.

2013-02-19 Thread Igor Babaev
On 02/19/2013 04:59 PM, Christian Convey wrote: > Hi guys, > > As I work through the Coverity Scan results of MariaDB's trunk, I find > myself having to research what some functions do, and the meanings of > their parameters and return values. Rather than just recording what I > learn on a piece

Re: [Maria-developers] implementing multi range read at the storage engine in MariaDB 5.5

2013-02-15 Thread Igor Babaev
On 02/15/2013 04:17 AM, Zardosht Kasheff wrote: > Hello all, > > Is there anything to implementing multi range read for storage > engines? Or is there a default implementation that is likely good > enough. > > Also, is there anything one can read to understand how the feature > works and its bene

Re: [Maria-developers] Fwd: debugging how query plans are made

2013-02-12 Thread Igor Babaev
On 02/12/2013 08:10 AM, Zardosht Kasheff wrote: > Is there something similar in MariaDB? I would recommend you to try this feature first and see how it is helpful for you. May be that after the first your experience you'll lose any interest in it. (The direct answer is: No, we don't have optimize

Re: [Maria-developers] Igor please review: EXPLAIN for DELETE

2013-02-06 Thread Igor Babaev
Hi Sergey, I looked through your code trying to figure out in what direction you are moving. If my understanding of the code is correct you move in the right direction. Here are some general notes. Ideally I would like to see the following architecture (I ignore here the fact that we have to supp

Re: [Maria-developers] Fwd: [Commits] Rev 3622: Fix for MDEV-4140 in file:///home/tsk/mprog/src/5.3-md4140/

2013-02-06 Thread Igor Babaev
Timour, It's ok to push this patch as a fix. Yet remember that this fix leads us to a performance regression 5.2 >> 5.3 when the range expression contains a constant [single-row] subquery. This is due to the changes when and how we build range trees in 5.3. When we have a range expression with c

Re: [Maria-developers] Fwd: [Commits] Rev 3622: Analysis: in file:///home/tsk/mprog/src/5.3-md641/

2013-01-31 Thread Igor Babaev
On 01/31/2013 04:41 AM, Timour Katchaounov wrote: > Igor, > > Let me know if I can push the patch below. It fixes the bug > according to our last discussion. If the number of group_list > elements was known, I could add a test already in the beginning > of the function, however such a counter does

Re: [Maria-developers] Fwd: [Commits] Rev 3616: Fix for bug in file:///home/tsk/mprog/src/5.3-md641/

2013-01-27 Thread Igor Babaev
Timour, It's not clear for me: 1. why group by queries with GROUP BY col1, col2, where col1,col2 are defined over the same table, are considered as possibly good for for loose scan optimization. 2. how it comes that unique index is considered as a candidate for a loose scan (see your test case).

Re: [Maria-developers] Order by speed optimization

2013-01-12 Thread Igor Babaev
On 01/11/2013 09:33 PM, Matthew Lagoe wrote: > I was talking with a few people about a query such as > > > |select * from table order by X, Y, Z limit G;| > > > As the "ORDER BY" for me could change to any number of 12 values in any > order I am not able to use a multicolumn index as such I

Re: [Maria-developers] Order by speed optimization

2013-01-12 Thread Igor Babaev
On 01/11/2013 09:33 PM, Matthew Lagoe wrote: > I was talking with a few people about a query such as > > > |select * from table order by X, Y, Z limit G;| > > > As the "ORDER BY" for me could change to any number of 12 values in any > order I am not able to use a multicolumn index as such I

Re: [Maria-developers] extended keys

2012-12-17 Thread Igor Babaev
INNODB); in open_binary_frm(), table.cc (mariadb) You have to change it. There is a similar code in mysql, also in open_binary_frm(),table.cc Regards, Igor. > > On Sun, Dec 16, 2012 at 10:58 PM, Igor Babaev wrote: >> On 12/14/2012 11:33 AM, Rich Prohaska wrote: >>> MySQL 5.6.9 change

Re: [Maria-developers] extended keys

2012-12-16 Thread Igor Babaev
On 12/14/2012 11:33 AM, Rich Prohaska wrote: > MySQL 5.6.9 changed how the number of key parts are measured. They > replaced one simple counter (key_parts) with four counters. Glancing > at the code, i assume that this was done to support extended keys. If > so, the mariadb implementation of ext

Re: [Maria-developers] [Commits] Rev 3589: Fixed bug mdev-585 (LP bug #637962) in file:///home/igor/maria/maria-5.3-mdev585/

2012-11-02 Thread Igor Babaev
. Both 5.3 and 5.5 are in GA anyway. Regards, Igor. > > On Thu, Nov 01, 2012 at 02:54:34PM -0700, Igor Babaev wrote: >> At file:///home/igor/maria/maria-5.3-mdev585/ >> >> >> revno: 3589 >> revision

Re: [Maria-developers] Please look at and advise about MDEV-3801

2012-10-22 Thread Igor Babaev
On 10/22/2012 07:54 AM, Igor Babaev wrote: > On 10/22/2012 12:53 AM, Timour Katchaounov wrote: >> Igor, >> >> Great, the patch indeed fixes the bug both on 5.3 and 5.5, however the >> reduced test case I produced still takes 21 MB, and I was not successful >> in

Re: [Maria-developers] Please look at and advise about MDEV-3801

2012-10-22 Thread Igor Babaev
te. > I already spent too much in reducing the test case. Would you agree that > I push your patch without a test case? I think you still have to add the test case case (in a separate file) that is run with the --big option. Regards, Igor. > > Timour > > > On 20.10.2012 0

Re: [Maria-developers] Please look at and advise about MDEV-3801

2012-10-19 Thread Igor Babaev
On 10/19/2012 12:43 PM, Timour Katchaounov wrote: > Hi Igor, > > Could you please look at this bug > https://mariadb.atlassian.net/browse/MDEV-3801, > and read my last comment. The bug may be (just a guess ATM) related to > index > creation on the temporary table created for the derived table. Sin

Re: [Maria-developers] [Maria-discuss] Json Explain

2012-09-30 Thread Igor Babaev
Peter, You are right that EXPLAIN in any format has nothing to do with the optimizer. Looking at the piece of the MySQL code that forms the strings for the EXPLAIN anyone could easily come up with the patch providing JSON format for the EXPLAIN (even with the extensions of MySQL 5.6) and it would

Re: [Maria-developers] Support of the extended syntax for ANALYZE

2012-05-19 Thread Igor Babaev
Serg, All, On 05/19/2012 10:51 AM, Sergei Golubchik wrote: > Hi, Igor! > > On May 19, Igor Babaev wrote: >> On 05/19/2012 04:22 AM, Sergei Golubchik wrote: >>> On May 10, Igor Babaev wrote: >>> Alternatively, it could have an explicit "PERSISTENT" key

Re: [Maria-developers] Support of the extended syntax for ANALYZE

2012-05-19 Thread Igor Babaev
On 05/19/2012 04:22 AM, Sergei Golubchik wrote: > Hi, Igor! > > On May 10, Igor Babaev wrote: >> Serg, >> >> Here's the patch we talked about on IRC today. > ... >> +ANALYZE TABLE t1(COLUMN(), INDEX()); >> +ANALYZE TABLE t1(COLUMN(c,e,b), INDEX(idx

Re: [Maria-developers] [Commits] Rev 3488: Fix of LP bug#968720. in file:///home/bell/maria/bzr/work-maria-5.3-lpb968720/

2012-04-05 Thread Igor Babaev
Sanja, Please correct the comment (see my variant below) and fix the problem in cut() I discovered. Sorry, I basically don't understand your code. Contact me on IRC please. Regards, Igor. On 04/04/2012 04:01 AM, sa...@montyprogram.com wrote: > At file:///home/bell/maria/bzr/work-maria-5.3-lpb968

Re: [Maria-developers] Igor please review: [Commits] Rev 3464: BUG#951937: Wrong result (missing rows) with semijoin+materialization, IN subquery, InnoDB, TEMPTABLE view in file:///home/psergey/dev2/5

2012-03-23 Thread Igor Babaev
On 03/23/2012 02:41 PM, Sergei Petrunia wrote: > Hello Igor, > > Could you please review the below: Hi Sergey, Here's my feedback: > > - Forwarded message from Sergey Petrunya - > > From: Sergey Petrunya > To: comm...@mariadb.org > X-Mailer: mail (GNU Mailutils 1.2) > Date: Sat, 24

Re: [Maria-developers] Fwd: [Commits] Rev 3335: Fix bug lp:825075 in file:///home/tsk/mprog/src/5.3/

2012-02-17 Thread Igor Babaev
On 02/17/2012 08:00 AM, Sergei Petrunia wrote: > Hi Timour, > > So, we're trying to fix this by making group-by-loose-scan access method be > able to scan forwards (when evaluating MIN) and/or backwards (if evaluating > MAX) until it finds a record that satisfies the WHERE condition. > > We stil

Re: [Maria-developers] Please review: [Commits] Rev 3377: BUG#912510: Crash in do_copy_not_null with semijoin=ON, firstmatch=ON, aggregate

2012-01-09 Thread Igor Babaev
On 01/08/2012 02:46 AM, Sergei Petrunia wrote: > Hello Igor, Timour > > Could anybody of please review the below fix? > additional details about the problem were posted at > https://mariadb.atlassian.net/browse/MDEV-67. Sergey, After the discussion with you on skype I reviewed Timour's code

Re: [Maria-developers] [Commits] Rev 3376: Fixed LP bug #910083. in file:///home/igor/maria/maria-5.3-bug910083/

2012-01-03 Thread Igor Babaev
s the case, then I would refine your fix by testing whether > a statement is a SELECT, or UPDATE (or INSERT?) and updating the THD > only when needed. It's relevant for the scenario when the fixed item is created by a different client: for example, when the item belongs to SP and this SP

Re: [Maria-developers] [Commits] Rev 3376: Fixed LP bug #910083. in file:///home/igor/maria/maria-5.3-bug910083/

2012-01-03 Thread Igor Babaev
have any explanation why you had removed the call. Should it be a reference to Monty's opinion?I have to admit it would be pretty pretty lame. Regards, Igor. > > Timour > > On 3.01.2012 06:06, Igor Babaev wrote: >> At file:///home/igor/maria/maria-5.3-bug910083/ >>

Re: [Maria-developers] Preparations for 5.3.2 release

2011-09-28 Thread Igor Babaev
On 09/28/2011 03:36 AM, Sergey Petrunya wrote: > Hi! > > As discussed on the yesterday's call, we're starting to prepare for the > next 5.3 release, 5.3.2 beta. The intent is to build it on this or on the > next weekend. > > Before the release, we need to do > 1. Bugs > 2. optimizer_switch cha

Re: [Maria-developers] Please review: [Commits] Rev 3199: Fix bug lp:858148. in file:///home/tsk/mprog/src/5.3/

2011-09-28 Thread Igor Babaev
OK to push. Regards, Igor. On 09/28/2011 07:23 AM, Timour Katchaounov wrote: > Hi Igor, > > Could you please review the following fix. > It is very much related to a bug you fixed: > https://bugs.launchpad.net/bugs/702301 > > Thanks, > Timour > > Original Message > Return-Pat

[Maria-developers] Performance speed-up for DBT3 query set with MariaDB 5.3.0

2011-08-07 Thread Igor Babaev
Hi, Here are the results for DBT3 query set I've got on my laptop with MariaDB 5.3.0 installed. [ Dell Latitude E6510: 4-cores with multithreading (8 threads in total) Memory: 8GB, SSD, SuSE 11.3 ] DBT3 factor 10 (60M rows in lineitem) built for InnoDB. Mysqld was launched with the followin

Re: [Maria-developers] Fwd: [Commits] Rev 3092: Fixed bug lp:809245 in file:///home/tsk/mprog/src/5.3-mwl89/

2011-07-13 Thread Igor Babaev
On 07/13/2011 07:38 AM, Timour Katchaounov wrote: > Igor, > > Could you please review my patch for bug LP:809245. > > Ttimour Timour, It's ok to push this patch Regards, Igor. > > > Original Message > Return-Path: > X-Original-To: tim...@askmonty.org > Delivered-To: tim...

Re: [Maria-developers] Fwd: [Commits] Rev 3104: Fix bug lp:809266 in file:///home/tsk/mprog/src/5.3-mwl89/

2011-07-13 Thread Igor Babaev
On 07/13/2011 02:34 PM, Timour Katchaounov wrote: > Igor, > > Could you please review this fix for bug lp:809266. Timour, If you have full coverage of the new code from the patch then you may push it. Regards, Igor. > > Timour > >

Re: [Maria-developers] Buildbot failures: Microsecond-related changes break innodb_plugin but not xtradb

2011-06-04 Thread Igor Babaev
On 06/04/2011 02:19 AM, Sergey Petrunya wrote: > Hi! > > All of the recent 5.3 builds in buildbot have two failures: > > innodb_plugin.innodb_bug54044 'innodb_plugin' > innodb_plugin.innodb_information_schema 'innodb_plugin' > > The failure happens only with innodb_plugin. XtraDB is fine. > >

Re: [Maria-developers] A serious merge bug in 5.3.

2011-04-24 Thread Igor Babaev
On 04/24/2011 01:51 AM, Sergei Golubchik wrote: > Hi, Igor! > > On Apr 24, Igor Babaev wrote: >> >> When debugging I discovered the following bad code in sql_select.cc of >> the current 5.3 tree: > >> tmp= table->file->read_time(key, 1, >

Re: [Maria-developers] [Commits] Rev 2908: Fixed LP bugs #717577, #724942. in file:///home/igor/maria/maria-5.3-bug717577/

2011-04-23 Thread Igor Babaev
On 04/23/2011 05:26 PM, Sergey Petrunya wrote: > On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote: >> Hello Igor, >> >> First, an overall comment: there are lots of typos/coding style violations in >> the patch. To reduce amount of effort spent on such things, I was just >> fixing

Re: [Maria-developers] Igor please review: Rev 2929: BUG#693747: Assertion multi_range_read.cc:908: int DsMrr_impl::dsmrr_init in file:///home/psergey/dev2/5.3-2/]

2011-03-02 Thread Igor Babaev
On 03/02/2011 05:30 AM, Sergey Petrunya wrote: > Hello Igor, > > Could you please review the below: > > - Forwarded message from Sergey Petrunya - > > From: Sergey Petrunya > To: comm...@mariadb.org > X-Mailer: mail (GNU Mailutils 1.2) > Date: Wed, 2 Mar 2011 00:17:53 +0300 (MSK) > Su

Re: [Maria-developers] Igor please review: [Commits] Rev 2926: BUG#724275: Crash in JOIN::optimize in maria-5.3 in file:///home/psergey/dev2/5.3-2/]

2011-02-28 Thread Igor Babaev
On 02/28/2011 01:31 PM, Sergey Petrunya wrote: > Hello Igor, > > Could you please review the below: Ok to push. Regards, Igor. > > - Forwarded message from Sergey Petrunya - > > From: Sergey Petrunya > To: comm...@mariadb.org > X-Mailer: mail (GNU Mailutils 1.2) > Date: Tue, 1 Mar 2

Re: [Maria-developers] Fwd: [Commits] Rev 2901: BNLH algorithm always used a full table scan over the joined table in file:///home/igor/maria/maria-5.3-mwl128-hashrange/

2011-02-21 Thread Igor Babaev
On 02/21/2011 12:30 PM, Sergey Petrunya wrote: > On Fri, Feb 11, 2011 at 08:49:37PM -0800, Igor Babaev wrote: >> Hi Sergey, >> >> Please review this patch that fixes a defect of the current >> implementation of the mwl #128 that never couples hash join >> with rang

[Maria-developers] IMPORTANT: LP bug #611648 does not allow running benchmarks for DS-MRR normally

2011-02-01 Thread Igor Babaev
Hi, I've just reported bug #611648 that probably explains the strange results I had when trying to run my benchmark queries for DS-MRR about which I talked at today's optimizer meeting. Philip, please assign this bug to SergeyP. Regards, Igor. ___ Mai

Re: [Maria-developers] index_merge, @@sort_buffer_size, and Sort_XXX counters

2011-01-19 Thread Igor Babaev
On 01/19/2011 02:32 PM, Sergey Petrunya wrote: > Hello, > > index_merge uses @@sort_buffer_size as a guide of how much space it can use > for > sorting. I think there is an issue with the way it is done. > > Before index_merge was introduced, @@sort_buffer_size was used only by > filesort (also

Re: [Maria-developers] problem with partitioning and our storage engine in 5.2

2010-12-09 Thread Igor Babaev
> revno: 2732 [merge] > revision-id: i...@askmonty.org-20091112043128-yd6odg8zr5ribjal > parent: pser...@askmonty.org-20091104224158-nk2s2luvlqwa02bl > parent: i...@askmonty.org-20091110023239-vgttyweq2qmh0y25 > committer: Igor Babaev > branch nic

Re: [Maria-developers] [Commits] Rev 2977: Fix of LP BUG#675248. in file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/

2010-11-23 Thread Igor Babaev
Sanja. Ok to push after the required changes in comments Regards, Igor. sa...@askmonty.org wrote: > At file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/ > > > revno: 2977 > revision-id: sa...@askmonty.org-20101123150005-

Re: [Maria-developers] MariaDB 5.1.51

2010-11-19 Thread Igor Babaev
Daniel Bartholomew wrote: > On Fri, 19 Nov 2010 09:04:17 -0800 > Igor Babaev wrote: > > Igor> * MySQL Bug #51242 > Igor> <http://bugs.mysql.com/bug.php?id=51242> /HAVING clause on table > Igor> join produce incorrect results/ > Igor> > Igor> Dan

Re: [Maria-developers] MariaDB 5.1.51

2010-11-19 Thread Igor Babaev
On 11/19/2010 08:17 AM, Daniel Bartholomew wrote: > All, > > I've created the download, release notes, and changelog pages for > MariaDB 5.1.51: > > http://askmonty.org/wiki/MariaDB:Download:MariaDB_5.1.51 > http://kb.askmonty.org/v/mariadb-5151-release-notes > http://kb.askmonty.org/v/mariadb-5151

Re: [Maria-developers] Final testing for join_cache levels and hash join

2010-11-15 Thread Igor Babaev
On 11/15/2010 04:45 AM, Philip Stoev wrote: > Igor, > > As you have noticed I have started filing bugs that require 4-5 > tables, self joins, etc. to show up. I continue running the same tests > as before, it is just that the 2-table bugs have all been fixed by now. > > While I do consider 4-5 tabl

Re: [Maria-developers] really annoying bug in mysql 5.0/5.1 optimiser, opened for more than 2 years, and still present in MariaDB

2010-08-27 Thread Igor Babaev
Jocelyn Fournier wrote: > Hi, > > There's a really annoying bug in the mysql optimiser existing for a > really long time now, and which has a direct impact on performances : > > http://bugs.mysql.com/bug.php?id=36817 > > Since MySQL definitly doesn't seem to want to fix it, I hope MariaDB > cou

Re: [Maria-developers] 64 table join limit

2010-08-13 Thread Igor Babaev
Dan Meany wrote: > One thing about dynamic columns is that they have sped up our development > cycle by a factor of 5, since we are not spending time on hard coded binding > layers, and analysts can create application tables instead of developers and > DBAs. We have other mechanisms in place to

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2779)

2010-06-28 Thread Igor Babaev
#At lp:maria based on revid:kniel...@knielsen-hq.org-20091130132430-edrwle5zh6udx9rp 2779 Igor Babaev 2010-06-28 Optimization that checks for expressions whether they are always null. modified: mysql-test/r/func_in.result sql/item.h sql/item_cmpfunc.cc

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2750)

2010-06-28 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20091103182103-jnjuss2b4t72rz83 2750 Igor Babaev 2010-06-28 An implementation of index intersect via a modified Unique class. This code is planned to be used for mwl#21. modified: include/my_tree.h mysys/tree.c

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2792)

2010-05-26 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100518174632-e2xaeunykfmtyafm 2792 Igor Babaev 2010-05-26 MWL#106: creation of keys for materialized derived tables/views. Also fixed several bugs in the backported code. modified: mysql-test/r

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2791)

2010-05-18 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100513065914-yq9y2pbd9zn2fm7w 2791 Igor Babaev 2010-05-18 Fixed bugs in the backport of derived tables (mwl106). modified: mysql-test/r/derived_view.result mysql-test/r/table_elim.result sql

Re: [Maria-developers] Segmented Key Cache - About section

2010-05-18 Thread Igor Babaev
f the key cache will behave themselves differently. Regards, Igor. Henrik Ingo wrote: > On Mon, May 17, 2010 at 9:14 PM, Igor Babaev wrote: >> 1. the author of the original patch >> 2. our community members (not only PeterZ!) >> 3. our developers >> >> what term they

Re: [Maria-developers] Segmented Key Cache - About section

2010-05-18 Thread Igor Babaev
Henrik Ingo wrote: > On Mon, May 17, 2010 at 9:14 PM, Igor Babaev wrote: >> 1. the author of the original patch >> 2. our community members (not only PeterZ!) >> 3. our developers >> >> what term they prefer 'Segmented Key Cache' or 'Partitioned Ke

Re: [Maria-developers] Segmented Key Cache - Syntax section

2010-05-17 Thread Igor Babaev
Hi Daniel, Daniel Bartholomew wrote: > Hello everyone, > > Summarizing from my previous email: I'm working on the documentation for > the Segmented Key Cache, one of the new features in MariaDB 5.2. My > previous email was about the "About" section of the documentation. This > email is about the

Re: [Maria-developers] Segmented Key Cache - About section

2010-05-17 Thread Igor Babaev
gt; position of the page in the file, and it's always the same for the > page. Pages are evenly distributed among segments. > > The idea and the original code of the segmented key cache was provided > by Fredrik Nylander from Stardoll.com. The code was extensively > reworked, improved, a

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2790)

2010-05-13 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100512040958-yc654eq2zdfo8l8m 2790 Igor Babaev 2010-05-12 Cleanup modified: sql/sql_derived.cc === modified file 'sql/sql_derived.cc' --- a/sql/sql_derived.cc2010-05-12 04:09:58 + +++ b/sql/sql_

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2789)

2010-05-11 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100429211039-rp1mza3xjeqd4t1w 2789 Igor Babaev 2010-05-11 Fixed several bugs in the backport code (mwl#106). modified: mysql-test/r/innodb_lock_wait_timeout_1.result mysql-test/r/lock_multi_bug38499.result

Re: [Maria-developers] Please check optimiser regression in MySQL 5.1.46

2010-05-02 Thread Igor Babaev
ble_cond= make_cond_for_table(curr_join->tmp_having, used_tables, used_tables); Regards, Igor. 3447 Igor Babaev2010-05-02 Fixed bug #53334. The fix actually reverts the change introduced b

Re: [Maria-developers] Please check optimiser regression in MySQL 5.1.46

2010-04-30 Thread Igor Babaev
Hi! Kristian Nielsen wrote: > Hi Igor, Timour, Sergey, > > Can one of you please check this patch from MySQL 5.1.46? It is a commit to > fix http://bugs.mysql.com/bug.php?id=51494 > > This patch introduces a regression: > > http://bugs.mysql.com/bug.php?id=53334 > > If I revert the patch, t

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2845)

2010-04-08 Thread Igor Babaev
#At lp:maria based on revid:mo...@askmonty.org-20100408115657-lxjm4cpvi4zp81rk 2845 Igor Babaev 2010-04-08 Fixed a problem of merge from mysql-5.1 baseline. modified: sql/sql_select.cc === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2010-03-1

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2750)

2010-04-05 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100405202809-beg2cwhelygpbl6i 2750 Igor Babaev 2010-04-05 Post review fixes. modified: include/keycache.h mysql-test/suite/funcs_1/r/is_columns_is.result mysql-test/suite/funcs_1/r/is_tables_is.result

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2749)

2010-04-05 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100403201935-gg9tnu4bxe73i7yk 2749 Igor Babaev 2010-04-05 [merge] Merge with the latest changes of 5.2. modified: mysql-test/r/connect.result mysql-test/t/connect.test sql/sql_acl.cc === modified file

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2746)

2010-03-31 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100331231003-9gvmv2y8384kbqfa 2746 Igor Babaev 2010-03-31 Made the results of the key_cache test to be platform independent. modified: mysql-test/r/key_cache.result mysql-test/t/key_cache.test === modified

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2744)

2010-03-31 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100329211612-d7f7utiqasfk0ups 2744 Igor Babaev 2010-03-31 Adjusted results modified: mysql-test/r/key_cache.result mysql-test/suite/pbxt/r/mysqlshow.result mysql-test/t/key_cache.test === modified

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2746)

2010-03-19 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100319062332-4ghnaoaxcgagwj3m 2746 Igor Babaev 2010-03-19 [merge] Merge modified: configure.in mysql-test/Makefile.am === modified file 'configure.in' --- a/configure.in 2010-03-15 11:51:23 +

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2745)

2010-03-18 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100317023231-w7h0euroof0lul8e 2745 Igor Babaev 2010-03-18 Made the vcol suite independent on time zone. modified: mysql-test/suite/vcol/inc/vcol_supported_sql_funcs_main.inc mysql-test/suite/vcol/r

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2744) Bug#539643

2010-03-16 Thread Igor Babaev
#At lp:maria/5.2 based on revid:ser...@pisem.net-20100315115123-21tgprclhz7qbk6m 2744 Igor Babaev 2010-03-16 Fixed bug #539643. The cause of the problem is a bad merge MariaDB-5.1=>MariaDB-5.2. Added the vcol suite to the list of the default suites run

Re: [Maria-developers] [Fwd: WorkLog sends out too many mail-copies to maria-developers]

2010-03-15 Thread Igor Babaev
Daniel Bartholomew wrote: > On Sat, 13 Mar 2010 09:34:22 +0100 > Kristian Nielsen wrote: > > Kristian> One thing we could do is disable the worklog...@askmonty.org > Kristian> alias (eg. send it to /dev/null). This should disable sending > Kristian> the mails to the mailing list at least. > > I

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2772) Bug#51092

2010-03-06 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20100305185448-satt36ksg5xxkwji 2772 Igor Babaev 2010-03-06 Fixed bug #51092. The function JOIN_CACHE::read_all_record_fields could return 0 for an incremental join cache in two cases: 1. there were no more records

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2771) Bug#45191

2010-03-05 Thread Igor Babaev
#At lp:maria/5.2 based on revid:pser...@askmonty.org-20100225080910-38wapbgw5vpm6nax 2771 Igor Babaev 2010-03-05 Corrected Evgen's fix for bug #45191. Made sure that join buffers could be used for inner tables of any semi-join when the first match strategy is emp

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2771) Bug#45191

2010-03-04 Thread Igor Babaev
#At lp:maria/5.2 based on revid:pser...@askmonty.org-20100225080910-38wapbgw5vpm6nax 2771 Igor Babaev 2010-03-04 Corrected Evgen's fix for bug #45191. Made sure that join buffers could be used for inner tables of any semi-join when the first match strategy is emp

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2740)

2009-12-21 Thread Igor Babaev
#At lp:maria/5.2 based on revid:i...@askmonty.org-20091221022615-kx5ieiu0okmiupuc 2740 Igor Babaev 2009-12-21 [merge] Merge from 5.2-dsmrr modified: mysql-test/r/innodb_mrr.result mysql-test/r/type_date.result === modified file 'mysql-test/r/innodb_mrr.r

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2785)

2009-12-13 Thread Igor Babaev
Kristian, There should be a common sense after all. Adding 7K files from boost doesn't comply with a common sense. no matter what Arjen thinks about it. If oqgraph cannot do without boost in the MariaDB development tree we'd better drop oqgraph. Regards, Igor. Sergei Golubchik wrote: > Hi, kniel

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2765) Bug#42116 WL#17

2009-11-11 Thread Igor Babaev
#At lp:maria based on revid:mo...@mysql.com-2009111749-dnv4ams2mnb8b8rp 2765 Igor Babaev 2009-11-11 Corrected a line from the patch for table elimination (WL#17) to fix a problem with the test case for bug#42116. modified: sql/sql_select.cc === modified file

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2765)

2009-11-10 Thread Igor Babaev
#At lp:maria based on revid:mo...@askmonty.org-20091110151512-zdhox73n97ant1pm 2765 Igor Babaev 2009-11-10 Test! modified: sql/opt_range.cc per-file messages: sql/opt_range.cc Test! === modified file 'sql/opt_range.cc' --- a/sql/opt_range.cc 2009-11-1

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2748) WL#24

2009-10-29 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20091029184958-1b1iyhu09sihxc6o 2748 Igor Babaev 2009-10-29 Fixed a bug in the code of the patch for WL#24 that manifested itself when running the pbxt.group_min_max test leading to wrong result sets and execution plans for

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2747)

2009-10-29 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20091026173514-biry7lgxqiz2zz7a 2747 Igor Babaev 2009-10-29 Replaced a lame implementation of the function sel_trees_must_be_ored that blocked building index merge plans for the queries with where conditions of the form

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2745)

2009-10-17 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20091012045934-8rkx13xrp0vqy6p2 2745 Igor Babaev 2009-10-17 Changed test cases to make results for innodb platform independent. modified: mysql-test/r/range_vs_index_merge.result* mysql-test/r/range_vs_index_merge_innodb.result

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2755)

2009-09-24 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090925064243-2kf7ah4m6u25ex58 2755 Igor Babaev 2009-09-24 [merge] Merge modified: mysql-test/r/create.result mysql-test/r/information_schema.result mysql-test/t/information_schema.test mysql-test/t/not_embedded_server.test sql

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2754)

2009-09-24 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090920030226-xxh7a4i3gre9rqhe 2754 Igor Babaev 2009-09-24 Took care of mysql test suite failures on Windows. modified: mysql-test/suite/rpl/t/rpl_binlog_corruption.test mysql-test/suite/rpl/t/rpl_killed_ddl.test vio/viosocket.c

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2753) Bug#47016

2009-09-19 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090919221119-bpy6nqq2xmn64dh4 2753 Igor Babaev 2009-09-19 Applied the fix for bug #47016 - a failure of rpl_do_grant watched on Windows. modified: mysql-test/suite/rpl/t/rpl_do_grant.test === modified file 'mysql-test/suit

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2752)

2009-09-19 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090919212129-p3ydr02t0es1py7y 2752 Igor Babaev 2009-09-19 [merge] Merge modified: mysql-test/mysql-test-run.pl mysql-test/r/myisam.result mysql-test/suite/maria/r/maria3.result mysql-test/t/myisam.test sql/sql_table.cc

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2751) Bug#47455

2009-09-19 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090918192704-0vlgzsth6r0e86zk 2751 Igor Babaev 2009-09-19 Fixed bug #47455 - a failure with main.myisam_crash_before_flush_keys.test on Windows. modified: storage/myisam/myisamchk.c === modified file 'storage/myisam/myisam

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2750)

2009-09-18 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090918190257-descsgkvdgbqtfgq 2750 Igor Babaev 2009-09-18 Made innodb_xtradb_bug317074.test to be a 'big' test to avoid a timeout failure of it on Windows. modified: mysql-test/t/innodb_xtradb_bug317074.test === mod

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2749) Bug#46931

2009-09-18 Thread Igor Babaev
#At lp:maria based on revid:pser...@askmonty.org-20090917230109-mni2vfp5mtgxpbhw 2749 Igor Babaev 2009-09-18 Applied the fix for bug #46931 from mysql-5.1 main trunk to fix a failure in rpl_get_master_version_and_clock.test modified: mysql-test/extra/rpl_tests

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2744)

2009-09-17 Thread Igor Babaev
Kristian Nielsen wrote: > Igor Babaev writes: > >> #At lp:maria based on revid:i...@askmonty.org-20090916174301-lzzh1r0khn3dxwvp >> >> 2744 Igor Babaev2009-09-16 >> Fixed a failure of the merge_innodb test on windows. >> modified: &g

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2744)

2009-09-16 Thread Igor Babaev
#At lp:maria based on revid:i...@askmonty.org-20090916174301-lzzh1r0khn3dxwvp 2744 Igor Babaev 2009-09-16 Fixed a failure of the merge_innodb test on windows. modified: storage/myisammrg/ha_myisammrg.cc === modified file 'storage/myisammrg/ha_myisammrg.cc' --- a/storage

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2743) Bug#417751

2009-09-16 Thread Igor Babaev
#At lp:maria based on revid:kniel...@knielsen-hq.org-20090916120716-ssmx93bg4znld9l8 2743 Igor Babaev 2009-09-16 Fix of bug #417751 by Yasufumi Kinoshita. modified: storage/xtradb/srv/srv0start.c === modified file 'storage/xtradb/srv/srv0start.c' --- a/storage/