> +CREATE TABLE gcol_t1 (
> + sidea DOUBLE,
> + sideb DOUBLE,
> + sidec DOUBLE AS (SQRT(sidea * sidea + sideb * sideb))
> +);
> +
> +SELECT * FROM information_schema.columns WHERE table_name='gcol_t1';
Great. Just one tiny detail -
there is no gcol_bugfixes.result in your c
ched)
> +{
> +print_value(str);
> +return;
> +}
> +str->append(STRING_WITH_LEN("("));
> +if (example)
> +example->print(str, query_type);
> +else
> +Item::print(str, query_type);
Hi, Jacob!
On Mar 20, Jacob Mathew wrote:
> Hi Sergei,
>
> Both the changes for this bug and the changes for MDEV-10355 are in a stage
> tree named bb-10.2-. However, when I look at the automated
> testing on their respective branches, I see a few failures. As far as I
&
hd->collect_insert_id(table->file->insert_id_for_cur_row);
> >> +}
> > 1. Why are you doing it here, and not per row, inside
> > `while ((values= its++))` loop?
>
> It is what we need INSERT ID as if the com
Hi, Sachin!
On Mar 15, Sachin Setiya wrote:
> Hi Serg!
>
> On Sun, Mar 12, 2017 at 11:50 PM, Sergei Golubchik <s...@mariadb.org> wrote:
> > Hi, Sachin!
> >
> > On Feb 10, Sachin Setiya wrote:
> >> revision-id: b6f4d16a015fc778186ae4d2c1820a78c
, do updates. 2) do updates in parallel with the
dump. Just take care to enable at least the primary key, and made sure
that in both approaches you get the same table content at the end.
That's a simple test, no coding involved, but it'll give some
understanding as to what approach is faster on
t show anything bad, please squash your
three commits into one, rebase it on top of the current 10.2 and push.
Thanks!
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to
re table_name = 't1';
> +
> +drop table t1;
This is good, thanks!
But please, test column-level constraints too, as I've asked in a review.
Something like
create table t1 (c1 int check(c1 > 10), c2 int check (c2 < c1), ...)
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariad
ill_reason(X) ((enum kill_reason)((X) >> 2))
Something like that. This doesn't change much internally, only the
presentation and the way of thinking about it changes.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing
mem_root);
> +// no need free Items because they was only constants
> +free_root(arena.mem_root, MYF(0));
> +stop_collecting_insert_id();
> +return TRUE;
> + }
> + return FALSE;
> +
> +}
> +
> #endif /* !defined(MYSQL_CLIENT) */
> diff --
> MDEV-10555: Server crashes in mysql_admin_table upon killing ANALYZE
>
> Take into acount result of open table operation in mysql_admin_table.
Where's the test case?
Otherwise ok to push.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
__
you doing something in end_send()? You've fixed
THD::decide_logging_format(), why was that not enough?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-de
st, before
writing a proposal - it's the only way you can be sure your proposal
will be meaningful and realistic.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to
s in include/service_versions.h.
May be, it's best not to break the ABI for such a minor reason and only
change THD methods, not service functions.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.n
tand.
> I did something like this:
...
> And turned on INFORMATION_SCHEMA in phpmyadmin and it is slow, very
> slow. What I'm doing wrong here? How to speed up?
I cannot answer it like that, sorry.
The idea looks good and promising.
Your implementation looks fine too, I didn't spot anything
+0400
> message:
>
> MDEV-11941 - Lintian complains about executable bits
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad
> MDEV-10646 - System Unit File After network-online
>
> Bind to an address even if it is not yet configured.
Looks ok to me
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-
ngs? May be it should say about const (String::make_const) strings
instead. Thanks. Also you could add something about this your CONCAT
fix. Like, the item can use internal buffer as a temporary storage,
but the result should be in the String argument, not the other way
around. Ideally, we'd ha
conv_charset, _errors);
> + return null_value ? 0 : check_well_formed_result(str);
> }
That's a good idea. I'd expect it to fix the bug for both queries, with
and without SUBSTR. Hmm, not sure about SUBSTR, but then it'll be
Item_func_substr to fix.
But (sorry) you're fixing only Item_fun
f you'd modify the test case to use CONCAT direcly on
Item_conv_charset, this fix won't help.
The rule that could work is not to reuse a string if it is "const" in
the String::mark_as_const() sense. I'm 100% sure it's safe, but
it's something that the item can control in its val_str.
But it
lan on applying for this project - try to fix them.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~m
cy, so maybe we should go this direction?
How can you ensure that the buffer is different every time?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : m
nnecessary.
> >
> > Opinions? Ideas?
> IMHO 2 is good idea (Actually I thought that now it is done like 2)
Well, sure. It's the bullet-proof one, but most expensive performance
wise, many items will need to start copying the result, basically on
every level of the expression tree the
disallow one item to appear twice in
an expression. No idea how to do that.
4. A variand of #3, an item can appear many times, but it'll be only
evaluated once per row. That still needs #1, but #2 is unnecessary.
Opinions? Ideas?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.
ated like it
> is
> done for connection threads.
>
> Also let event scheduler not to inc/dec running threads counter for symmetry
> with other "service" threads.
>
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
if(left_expr->element_index(i)->is_null())
> + set_cond_guard_var(i,FALSE);
> + }
>if (!(item= new (thd->mem_root)
> Item_func_trig_cond(thd, item, get_cond_guard(i
> DBUG_RETURN(
*some charsets*, it's not true generally.
It is certainly not true that if you can convert, you can compare. For
example, let's compare t1.a with a latin1_german2_ci literal, for
example, "ö". You can convert "ö" to latin1_swedish_ci. But
t1.a= "ö" collate latin1_
ge:
>
> MySQL Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY - REQUIRES
> FLUSH PRIVILEGES
>
> Port & fix of MySQL patch for the problem.
Don't mix the refactoring and a bug fix. I don't see from this big patch
what the bug fix was. Please split in two (or more) comm
>, should have been <3717968>
It's 3717968
> 3rd: is <222>, should have been <222>
And so on, all values are as they should've been.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mai
shes. You'd need
to traverse them to see what databases a user has grants for.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Uns
r use case?
If it's *only* reading timestamps with a time zone, that is only
literals for insert/update/etc - then you can do with a rather small
fix, no ABI changes, no new data types, no on-disk format changes,
nothing.
A full support, a new data type TIMESTAMP WITH TIME ZONE - is
significant
E_FOR_UPDATE);
>}
>
> And that DBUG_ASSERT() actually does the crash.
>
> MySQL just blindly does the file->extra(HA_EXTRA_PREPARE_FOR_UPDATE)
> even for that 'SELECT * FROM t2;' query.
>
> Best regards.
> HF
>
Regards,
Sergei
Chief Architect MariaDB
and secur...@
eq. 7), but the correct value is 222 (length eq. 3).
>
> What I see is the correct value (exclude the first example presented
> here) but the length-information is one row behind (one row of
> TestSmall).
>
> For accessing the information presented here I used COND->str_value.
>
is TIMESTAMP WITH TIME ZONE literals with the standard
conversion behavior. It can be implemented completely inside
str_to_datetime.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-develo
ither have the password column, the plugin column, or both.
> Otherwise
> + we have a corrupt user table. */
> + DBUG_ASSERT(user_table.password() || user_table.plugin());
you cannot assert the table structure. ALTER TABLE shouldn't crash the
server.
> + if (user_table.ssl_ty
acquire for the tables we are oppening. */
> + const enum thr_lock_type lock_type;
not needed here, it's stored in every TABLE_LIST anyway
> + /* The grant tables are set-up in a linked list. We keep the head of it. */
> + Grant_table_base *first_table_in_list;
> + /**
> +Chain
s a bug
in Archive engine, in all versions, not in 10.2 only. In should not
store the uninitialized tail of VARCHAR columns.
On Feb 07, Varun Gupta wrote:
> Hi,
>
> The commit is:
>
> commit c697ddc315429c56dec567b2fe85cfe5c03834ea
> Author: Sergei Golubchik <s...@mariadb
other way.
Could you find what commit caused it? git bisect is quite useful for
that.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.la
ht candidate for this.
How would that help? You'll get faster execution if MyISAM would preload
first pages of the table. But it doesn't know you're going to do a full
table scan, so why would it preload it?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
__
.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help : https
don't calculate it every time here, do it once and store
in the TABLE_SHARE structure. Much like non_determinstic_insert is.
But I'm removing non_determinstic_insert now (it's always false, dead
code) so add another flag. Or - better - add a 'uint vcol_flags'
member which is OR of vcol_in
P out parameter + literal
> >
> Sending an updated patch, with comments.
Thanks! ok to push
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-develo
hange ?
Could you elaborate on that, please?
What exactly do you need and what do you need it for?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@l
Hi, Alexander!
On Jan 20, Alexander Barkov wrote:
> Hello Sergei,
>
> Please review a patch for MDEV-11780.
>
> Thanks!
> commit 1e6544808b1da0ca76d6c2e72318f41eeeb037a7
> Author: Alexander Barkov <b...@mariadb.org>
> Date: Fri Jan 20 14:20:52 2017 +
direct access to Item_param::state.
Looks ok to push.
Stylistic comments:
* too many fixed= true in all set_* methods. I'd rather added a method
fix_type(), to be used like
- type= Item::STRING_ITEM
+ fix_type(Item::STRING_ITEM)
and in this method I'd { type=type_arg; fixed= true }
r example
https://mariadb.org/get-involved/getting-started-for-developers/
You can look at open issues at jira.mariadb.org (search for Minor or
Trivial issues, they're usually simpler).
You can find project ideas from previous GSoC's at
https://mariadb.com/kb/en/mariadb/google-summer-of-code/
Regard
> MDEV-10956 Strict Password Validation Breaks Replication.
>
> Password validation switched off completely for slave threads.
I'd rather disable only strict_password_validation check in replication
threads. Because it, indeed, makes no sense there.
Regards,
Sergei
Chief Architect Ma
Hi, Alexander!
On Dec 26, Alexander Barkov wrote:
> Hello Sergei,
>
> can you please review a fix for MDEV-11134.
>
> I made it the easiest way, just fixed the assert to cover this special
> case when Item_param::safe_charset_converter() is called from
> mysql_prepare_creat
COM_CHANGE_USER, you might
need here:
thd->clear_error(); // if errors from rollback
ok to push with the change as above. But please make sure that C/C part
is pushed too
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
__
Hi, Alexander!
On Dec 26, Alexander Barkov wrote:
> Hello Sergei,
>
> can you please review a fix for MDEV-11134.
Sure. Where is it? :)
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.n
a= thd->activate_stmt_arena_if_needed();
> + buff= (char *) thd->alloc(scramble_length + 1);
> + if (arena)
> +thd->restore_active_arena(arena, );
> + }
Ok to push, just remove the unnecessary pair of curly braces and the
indentation.
Regards,
Sergei
Chief Architec
a= thd->activate_stmt_arena_if_needed();
> + buff= (char *) thd->alloc(scramble_length + 1);
> + if (arena)
> +thd->restore_active_arena(arena, );
> +}
where is it called from, why does it happen during the parsing?
> if (buff == NULL)
>re
Hi, jerome!
On Dec 27, jerome brauge wrote:
> Sergei,
> On SQLServer these kind of option (ANSI_NULLS, CONCAT_NULL_YIELDS_NULL
> and so on) can be set at session level or inside stored procedure (but
> not in function). In the last case, the scope of the setting is
> limite
UPER user
can change it (and thus break the replication).
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : http
false.
I'd say it's a bug.
It seems that we didn't have any Sys_var_set variable with more than 32
elements in the set yet, so it didn't show up.
To continue, I think, you can fix my_set_bits to work on ulonglongs.
Or create a second my_set_bits64().
Btw, I suspect you'll see more sql_mode
sts for
> some reasons, neither has an MDEV.
>
> Note, in case of literals it worked fine. Only subselects were affected.
okay
> Please suggest a good commit comment.
Just explain all the above there.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
_
Hi, Alexander!
On Dec 19, Alexander Barkov wrote:
> Hello Sergei,
>
> Please review a patch for MDEV-10386.
>
> Thanks!
> diff --git a/sql/item.cc b/sql/item.cc
> index 53666aa..44bd620 100644
> --- a/sql/item.cc
> +++ b/sql/item.cc
> @@ -1164
t");
>if (m_part_info)
> bitmap_set_all(_part_info->used_partitions);
> + m_extra_prepare_for_update= FALSE;
>file= m_file;
>do
>{
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
n 10.2" or
"periodically merge bb-10.2-ext in 10.3"
I suggest the former.
> - bb-10.2-compatibility will once (when it's ready) be
> merged or rebased to 10.3
>
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
__
public:
>uint arg_count;
>table_map used_tables_cache, not_null_tables_cache;
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launch
(merge)
> | |
> V |
> 10.3<-/
>
>
> Any objections about this scheme?
>
> I'd only propose to use "10.2-ext" instead of "10.3-base",
> as this intermediate branch is goin
and opening tables for LOCK TABLES.
> >
> > will you use MDL_SHARED_READ_ONLY right away when retrying?
> > or it'll do the upgrade thing again?
> Upgrade thing again, which is farily stupid. That's how it was in original
> code
> and I didn't change it in a hurry.
Can
thd->variables.lock_wait_timeout);
> +
> +thd->pop_internal_handler();
> +
> +if (deadlock_handler.need_reopen())
> +{
> + /*
> +Deadlock occurred during upgrade of metadata lock.
> +Let us
's version has column position 28 (0 index) vs our datadir version
> expects position 29.
>
> ---
> scripts/mysql_system_tables_fix.sql | 6 ++
> 1 file changed, 6 insertions(+)
>
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
__
Hi, Alexander!
On Dec 07, Alexander Barkov wrote:
> Hello Sergei,
>
> this is an improved version, as discussed in slack.
thanks, ok to push!
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://laun
t;
> MDEV-10663: Use of Inline table columns in HAVING clause throws 1463 Error
>
> check for VIEW/DERIVED fields
ok to push!
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-
ror() method here. How do report errors about
incorrect table definition? May be you should copy (ugh!) report_error
from, say, Event_db_intact?
> +};
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchp
Hi, Alexander!
On Dec 05, Alexander Barkov wrote:
> Hello Sergei,
>
> Please review a patch for MDEV-10717.
ok to push
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-develo
ur_s->keys == 0)
> +return TRUE;
> +
> + cur_s= tables[COLUMN_STAT].table->s;
> + if (cur_s->fields < COLUMN_STAT_N_FIELDS || cur_s->keys == 0)
> +return TRUE;
> +
> + cur_s= tables[INDEX_STAT].table->s;
> + if (cur_s->fields < INDEX_STAT
NCRYPT("Die Katze", "foo", "1234567890123456" USING aes_128_cbc);
(like charset names) otherwise it's not at all intuitive that
SELECT AES_ENCRYPT("Die Katze", "foo", "1234567890123456"
USING "aes-128-cbc")
ead, for each transaction that you want to skip, generate
> an empty transaction with the same GTID as the transaction"
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post t
gt; +
> +void THD::cleanup_connection(void)
> +{
Why do you need a dedicated method for that, instead of simply invoking
THD::change_user() for COM_RESET_CONNECTION?
> +}
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mail
years ago YYTHD was current_thd. This
LEX *lex=Lex;
mantra was used to avoid calling current_thd too often.
Now thd is passed as an argument to yyparse, so Lex no longer uses
current_thd and there's no need to "optimize" it into a local variable.
Old code still does it, though.
Regard
Hi, Alexander!
On Nov 28, Alexander Barkov wrote:
> Hello Sergei,
>
> On 11/28/2016 05:47 PM, Sergei Golubchik wrote:
> > Hi, Alexander!
> >
> >> diff --git a/sql/sql_load.cc b/sql/sql_load.cc
> >> index af4b251..6a473ce 100644
> >> --- a/sql/sql_
; which is the correct return value.
>
> Thoughts?
Can table->file->inited be true here at all?
I've added an assertion there and run the main test suite (in normal and
--ps-protocol, just in case) - it has never fired.
So, I'd speculate that table->file->inited must be a
Hi, Sergey!
On Nov 12, Sergey Petrunia wrote:
> Hi Sergei and everyone,
>
> MariaDB defines ER_LOCK_WAIT_TIMEOUT as
>
> share/errmsg-utf8.txt:eng "Lock wait timeout exceeded; try restarting
> transaction"
>
> facebook/mysql-5.6 has an enhancemen
there that
should be hidden (besides authentication tokens, obviously).
So I'd prefer it as open as possible - but read-only. World-readable,
not world-writable.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https:/
Hi, Kristian!
On Nov 05, Kristian Nielsen wrote:
> Sergei Golubchik <s...@mariadb.org> writes:
>
> > If you think you need admin access, please request it (again).
>
> Yes, please restore my access to the repo. I use it regularly, to work
> with web hooks, see how
ecommended for
all other members)
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-devel
;
> > > You're right, we should fix mysqlimport. I just wonder why this trivial
> > > fix
> > > wasn't introduced before?
> >
> > Will you do it as a part of MDEV-7660?
> Better not.
Could you make an MDEV for that? Type=Bug, FixVersion=10.2.
Othe
15 +0300
> message:
>
> MDEV-11126: Crash while altering persistent virtual column
>
> Problem was that if old virtual column is computed and stored there
> was no check if new column is really virtual column.
Regards,
Sergei
Chief Archit
b() seems to fail with EE_DELETE. It always says
"Error dropping database (can't rmdir './exp_db', errno: 39 "Directory not
empty")"
May be you should add this EE_DELETE as a warning?
> + }
> +
>path[length]= '\0';// Remo
communicate with the client.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-dev
Hi, Kristian!
On Oct 22, Sergei Golubchik wrote:
> Hi, Kristian!
>
> Yes, it is maintained, I've forwarded your email to the maintainer.
And that's the reply I got:
=====
Hi, Sergei,
Le 23/10/2016 à 00:32, Sergei Golubchik a écrit :
> Hi, Olivier!
> On
Hi, Alexey!
On Oct 23, Alexey Botchkov wrote:
> Hi, Sergei.
>
> I'd like to draw your attention to this old issue:
> https://jira.mariadb.org/browse/MDEV-7389
>
> The idea was to make a bigger thing - to modify the plugin API
> so it is easier to use and let user to
ch looks reasonable and should probably be upstreamed. But I am not
> sure how the mroonga storage engine is maintained - should this go directly
> into MariaDB? If there is an upstream maintained mroonga storage engine,
> probably it should preferably go there fir
good and should be
> upstreamed. But I am not sure how the CONNECT storage engine is maintained -
> should this go directly into MariaDB? If there is an upstream maintained
> CONNECT storage engine, probably it should preferably go there first?
>
> - Kristian.g
>
Regards,
Ser
Hi, Sergey!
On Oct 15, Sergey Vojtovich wrote:
> Hi Sergei,
>
> Sorry to say this, but you reviewed outdated commits. There's just one in
> bb-10.2-mdev7660 now. Since value of those cleanups was rather questionable
> and I got conflicts on rebase I discarded them.
Oh, okay. I kn
ou restore autocommit. Where a transaction is actually committed?
> }
>
>
> diff --git a/storage/innobase/handler/ha_innodb.cc
> b/storage/innobase/handler/ha_innodb.cc
> index 150f21a..b1dd81b 100644
> --- a/storage/innobase/handler/ha_innodb.cc
> +++ b/storage/innobase/handle
tures, JSON_TABLE is the most
interesting, but also the comlexity is a big unknown. The second one
would be GeoJSON (and it's fairly predictable), then goes JSON
comparison and JSON data type.
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Ma
es* in the future? If not, you
could move json_lib-t.cc into unittest/strings. And why the test is .cc?
The file looked pure C to me.
Anyway, I think it's ok to push after resolving these minor issues. Thanks!
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Hi, Nirbhay!
On Sep 27, Nirbhay Choubey wrote:
> On Tue, Sep 27, 2016 at 3:49 PM, Sergei Golubchik <s...@mariadb.org> wrote:
> >
> > I don't understand, why do you need to create a dummy plugin here?
> >
>
> Since global_system_variables.table_plugin is null
access victim_thd->transaction, because it's
not protected from concurrent accesses. And it's an overkill to take
LOCK_plugin and iterate the whole installed_htons[] array every time.
Then ok to push
>}
> + else
> + {
> +WSREP_WARN("Cannot abort InnoDB transaction&
mmy_plugin and assign it to
> + global_system_variables.table_plugin.
> +*/
> +void wsrep_plugins_pre_init()
> +{
> + wsrep_dummy_plugin=
> +(st_plugin_int *) my_malloc(sizeof(st_plugin_int), MYF(0));
> + wsrep_dummy_plugin->state= PLUGIN_IS_DISABLED;
> + global_system_
* element size is not the same as Item string value length (tree element
is record image with varchar columns in it). To use correct strings
value lengths, the upper code needs to correct tree allocated size
after each insertion. And after each deletion (if elements will be
deleted t
the problem should pay
for it, others shouldn't suffer :)
In ha_maria:implicit_commit, it was Aria's hack, and that if() was added
inside Aria. Here is purely wsrep problem, putting an if() on a common
code path for all threads looks just wrong.
>{
> mysql_mutex_lock(_plugin)
case REAL_RESULT:
> +min_rec_length+=2;
> +break;
> + case INT_RESULT:
> +min_rec_length++;
> + break;
> + case TIME_RESULT:
> +min_rec_length+=6;
> +break;
> + defa
urgine table cache).
>
> The reason was missing mysql_cond_broadcast().
ok to push
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-develope
parent
> for Item_func_{md5|sha|sha2|password|hex|to_base64}
> and overriding its eq() method to compare arguments binary.
Good fix, thanks!
Ok to push
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
___
Mailing li
!c_path->parsed)
> +{
> + String *s_p= args[n_arg]->val_str(tmp_paths+(n_arg-2));
> + if (s_p &&
> + json_path_setup(_path->p,s_p->charset(),(const uchar *)
> s_p->ptr(),
> + (const uchar *) s_p->ptr
1001 - 1100 of 2336 matches
Mail list logo
