n easily bypass this
check.
And, anyway, why an engine would not support log tables?
Only because it's transactional?
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-develo
URN(true);
> +}
What about InnoDB? Or RocksDB? Or any other transactional engine?
> #ifdef WITH_PARTITION_STORAGE_ENGINE
> if (alter_info->flags & Alter_info::ALTER_PARTITION)
> {
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
__
mysqld > 1)
> +{
> + char **argv_mysqld= _args[0];
> + if ((ho_error= handle_options(_mysqld, _mysqld,
> +xb_server_options,
> xb_get_one_option)))
> +exit(ho_error);
> +}
> +
> +my_handle
ic in MDEV-17399 code doesn't have support for dumping a
> portion
> of JSON document, so one gets empty strings in the price column.
>
> Should we support Q1 with JSON output in the price column? If yes, should we
> do it within the scope of MDEV-17399 or create another task for thi
or rpm package
>
> Part of MDEV-22552
This is ok. But don't push it yet, let's have all commits ok to push
them all at once
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-
any syntax whose lex
> lex->tmp_table()
> returns false here.
>
> RENAME specifically does not have 'temporary' qualifier.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~ma
IMPLICIT_COMMIT_BEGIN).
> That reads every DDL, Admin, Account that are bin-logged.
I mean RENAME for temporary tables. Does it also cause an implicit commit?
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: http
at about RENAME? What other operations are there that don't open a table?
2. check_has_uncommitted_xa() already does er_xaer_rmfail() internally,
you don't need to repeat it.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing
, bool if_exists,
> > >path_length= build_table_filename(path, sizeof(path) - 1, db.str,
> > > alias.str, reg_ext, 0);
> > > }
> > > +
> > > DEBUG_SYNC(thd, "rm_table_no_locks_before_delete_
please, add a test for the case when a user has no privileges on
test.t1, the object existence is not leaked out (if one has no
privileges to know whether t1 exists or whether t1 is a view or a table,
the error message should not divulge it).
(the same for tables and for sequences in your next commit)
&
egin with I want to implement:
>
> +, -. *, /, ++, --, <, >, ==, !=
if/while support ==, !=, <, <=, >, >= so you have to do at least those.
And then, yes, math, +, -, *, /, %. increment/decrement are less useful,
may be do them later?
Don't forget query_get_value(), it's a
Hi, Michael!
On Jun 11, Michael Widenius wrote:
> revision-id: 250bc3b6d74 (mariadb-10.5.2-390-g250bc3b6d74)
> parent(s): ba2c2cfb20e
> author: Michael Widenius
> committer: Michael Widenius
> timestamp: 2020-06-11 11:33:55 +0300
> message:
>
> Ensure that table is truly dropped when using
++ b/sql/item_func.cc
> @@ -4702,10 +4702,12 @@ update_hash(user_var_entry *entry, bool set_null,
> void *ptr, size_t length,
> entry->unsigned_flag= unsigned_arg;
>}
>entry->type=type;
> +#ifdef USER_VAR_TACKING
TRACKING
> #ifndef EMBEDDED_LIBRARY
>THD *thd= current_thd
TE_ROWS_EVENT)
> + table->file->prepare_for_insert(1);
> +
You can simplify it as
table->file->prepare_for_insert(get_general_type_code() != WRITE_ROWS_EVENT);
otherwise ok to push
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
)
walk() method defines the general API for traversing the tree.
An individual processor is the user of that API.
If some user has special weird needs, I'd prefer that to be implemented
in that user processor, not in the general API used by many.
> But returning to Item_ref, I just realized
> + if (ref && *ref)
> +return (*ref)->walk(processor, walk_subquery, arg) ||
> + (this->*processor)(arg);
> + return false;
> +}
> +
> +
> /**
>Transform an Item_ref object with a transformer callback function.
>
Regards,
Sergei
VP o
created when individual key_part->length
> < max_key_length but SUM(key_parts->length) > max_key_length
>
> Make UNIQUE HASH key in case when key_info->key_length > max_key_length
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
_
s was set up by Table_map_log_event::do_apply_event()
> @@ -14344,6 +14345,7 @@ int Rows_log_event::find_row(rpl_group_info *rgi)
> issue_long_find_row_warning(get_general_type_code(),
> m_table->alias.c_ptr(),
> is_index_scan, rgi);
>table->default_column
ebug_purge
>
> - commit ea37b144094a0c2ebfc6774047fd473c1b2a8658 (MDEV-16678) caused
> a regression. when purge thread tries to open the table for virtual
> column computation, there is no need to acquire MDL for the table.
> Because purge thread already hold MDL for the table
Regards,
Sergei
VP
e
> +Scope_value make_scope_value(T , const T _value)
> +{
> + return Scope_value(variable, scope_value);
> +}
as you've seen from Sql_mode_save usage, sometimes the value is assigned
later, not when it's saved. Please, add another helper that doesn't
req
{
> @@ -7152,6 +7151,7 @@ void TABLE::mark_columns_needed_for_insert()
>/* Mark virtual columns for insert */
>if (vfield)
> mark_virtual_columns_for_write(TRUE);
> + mark_columns_per_binlog_row_image();
this looks ok.
>if (check_constraints)
> mark_check_constraint_columns
k [25-31 May] of
> Community Bonding Period under the mentor-ship of Sergei Golubchik and
> Oleksandr Byelkin for GSoC-20. The tasks taken up for this week was to
> study and analyze *INSERT SELECT RETURNING* and developing a test
> suite for *MULTIPLE
> TABLE DELETE RETURNING.*
Re
);
>DBUG_ASSERT(marked_for_read());
>char *blob;
>memcpy(, ptr+packlength, sizeof(char*));
A couple of red flags here.
First, you don't fix BINLOG_ROW_IMAGE_MINIMAL.
And generally you should not modify read/write sets from val_str,
if should be done earlier before the execution
7 Strict SQL with system versioned tables causes issues
>
> Respect system fields in NO_ZERO_DATE mode.
>
> This is the subject for refactoring in MDEV-19597
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mai
_arena(expr_arena, _arena);
>bitmap_clear_all(_set);
>vf->vcol_info->expr->walk(::update_vcol_processor, 0, _set);
>vf->vcol_info->expr->save_in_field(vf, 0);
>in_use->restore_active_arena(expr_arena, _arena);
> - DBUG_RETURN(in_use->
wsrep_on;
> + thd->variables.wsrep_on= 0;
>thd->server_status&= ~(SERVER_STATUS_IN_TRANS |
> SERVER_STATUS_IN_TRANS_READONLY);
>thd->server_status|= SERVER_STATUS_AUTOCOMMIT;
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
__
> - ha_info= ha_info->next())
> -DBUG_ASSERT(ha_info->ht() != binlog_hton);
> -#endif
>rc= write_empty_xa_prepare(thd, cache_mngr); // normally gains
> need_unlog
>trans_register_ha(thd, true, binlog_hton, 0); // do it for futur
t; '1...'
> value found during parsing
> +ERROR 22007: Illegal double
> '1111
(hton->commit)];
> + tmp= [MY_TEST(hton->commit && !(hton->flags &
> HTON_NO_ROLLBACK))];
Why not to say that hton->rollback==NULL means no rollback?
Then you won't need a new flag for that.
And you'll remove redundancy, what would it mean if HTON_NO_ROLLBACK is
present, but hton->ro
; > > +++ b/mysql-test/suite/versioning/r/select.result
> > > @@ -45,7 +45,7 @@ ASOF_x y
> > > 7107
> > > 8108
> > > 9109
> > > -select x as FROMTO_x, y from t1 for system_time from timestamp '0-0-0
> > > 0:0:0' to ti
--loose-file-key-management-filekey=FILE:$MTR_SUITE_DIR/t/filekeys-data.key
this is very redundant, you include have_file_key_management_plugin.inc
and it already sets all options for the file_key_management plugin to work.
so you only need --encrypt-tmp_files=ON here.
Regards
if (!(field->flags & VERS_SYSTEM_FIELD))
> + error= make_empty_rec_store_default(thd, regfield,
> field->default_value);
will the field be initialized at all? It should have something, even
bzero will do, but we shouldn't dump uninited memory to frm.
> delete
Hi, Mohammed!
On May 11, Mohammed Hammaad Mateen wrote:
> Greetings,
> Hope you are safe and doing great,
>
> This post describes the things I've done in my first week [ 4-10 May ] of
> Community Bonding Period under the mentor-ship of Sergei Golubchik and
> Oleksandr Byelkin
MDEV-22312 */
don't put MDEV numbers into the code, please.
> +/* If the current user can see the role generate different type of
> error. */
> +if(user_can_see_role)
> +{
> + my_error(ER_SET_DEFAULT_ROLE_FOR_USER, MYF(0), c_usr.ptr(), rolename);
> + result= 1;
parse.cc b/sql/sql_parse.cc
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -5204,7 +5204,8 @@ check_table_access(THD *thd, ulong requirements,TABLE_LIS>
Register access for view underlying table.
Remove SHOW_VIEW_ACL, because it will be checked during making view
*/
-table
100644
> --- a/sql/sql_insert.cc
> +++ b/sql/sql_insert.cc
> @@ -1953,6 +1953,8 @@ int write_record(THD *thd, TABLE *table,COPY_INFO *info)
>if (likely(!error))
>{
> info->deleted++;
> +if (!table->file->has_transactions(
array.
> + }
>m_comparators[m_comparator_count].m_handler= tmp.type_handler();
>m_comparators[m_comparator_count].m_arg_index= value_index;
>m_comparator_count++;
> diff --git a/sql/item_cmpfunc.h b/sql/item_cmpfunc.h
> index 06f15503258a..4e84c3008578 100644
> --- a/sql/i
(<$_.gcov): $!";
> + }
> + else
> + {
> +my $f=substr $_, 0, -5;
> +open FH, '<', "$f.gcov" or die "open(<$f.gcov): $!";
> +undef $f;
> + }
I'd rather write it more compact, in two lines like
my $f = $gcov_vers < 7 ? $_ : sub
l_field() with clear
> DA since no matter how SQL command is finished it must update the
> index after bulk INSERT.
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria
e(s) or column(s) or function(s) or
> definer/invoker of view lack rights to use them
This must be a bug. If one does
SELECT * INTO OUTFILE FROM some.view
than the current user should have FILE, not the view definer.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.o
t suite (not main, but I don't remember
> exactly) test which require the permission otherwise I would not return and
> add more rights.
Where? The view is clearly not insertable-into, so INSERT privilege is
meaningless. Some fields are updateable, and one can delele from it.
This was more acci
INSERT INTO global_priv SELECT * FROM tmp_user_sys WHERE NOT
> > @had_sys_user;
> > > +DROP TABLE tmp_user_sys;
> >
> > 1. This could've been simply INSERT IGNORE, I suspect
>
> Nope, the idea is do not insert more than needed.
Why would INSERT IGNORE insert more
> Column_name char(64) binary DEFAULT '' NOT NULL, Timestamp timestamp NOT NULL
> DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, Column_priv
> set('Select','Insert','Update','References') COLLATE utf8_general_ci DEFAULT
> '' NOT NULL, PRIMARY KEY (Host,Db,User,Table_nam
Hi, Michael!
On Apr 16, Michael Widenius wrote:
> Hi!
>
> On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote:
> >
> > Hi, Michael!
> >
> > On Apr 13, Michael Widenius wrote:
> > > revision-id: bc5c062b1d1 (mariadb-10.5.2-124-gbc5c062b1d1)
> >
adow--
then any truncation will only affect the "original_name" part and it'll
be fine.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-
Hi, Michael!
On Apr 16, Michael Widenius wrote:
> Hi!
>
> On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote:
>
>
> > where's a test case for MDEV-22077?
>
> One can't use the test case in MDEV-22077 as it involves a table
> created by a 32 bit MariaDB ve
Hi, Michael!
On Apr 16, Michael Widenius wrote:
> On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote:
> > On Apr 13, Michael Widenius wrote:
> > > revision-id: bf32018be96 (mariadb-10.5.2-126-gbf32018be96)
> > > parent(s): 62c2d0f3e1f
> > > author: Michae
rom_binary_frm_image(THD *thd, bool write,
> const uchar *frm_image,
> -size_t frm_length)
> +size_t frm_length,
> +
with the comment
Added --temp-pool option to mysqld. This will cause temporary files
created to use a small set of filenames, to try and avoid problems
in the Linux kernel.
And I doubt it's still an issue in 2020.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb
L Workbench has a configuration option
whether to put this VISIBLE in the sql file or not.
This is a client tool misconfiguration issue.
I think the user can trivially tell his tool not to generate
MariaDB-incompatible syntax and we don't have to change the server for
this.
Regards,
Ser
,6 +581,7 @@ man/mariadb-check.1
> man/mariadb-client-test.1
> man/mariadb-client-test-embedded.1
> man/mariadb_config.1
> +man/mariadb-config.1
> man/mariadb-convert-table-format.1
> man/mariadbd.8
> man/mariadbd-multi.1
>
Regards,
S
mporary_tables());
please, never do asserts with &&-ed conditions, this should be
DBUG_ASSERT(!tl->derived);
DBUG_ASSERT(!tl->schema_table);
DBUG_ASSERT(has_temporary_tables());
> - if (tl->open_type == OT_BASE_ONLY || !has_temporary_tables())
> + if (
if (error == EBUSY)
> - return error;
> + goto end;
>}
>else
> error= pthread_mutex_lock(>mutex);
> @@ -393,6 +394,8 @@ int safe_mutex_lock(safe_mutex_t *mp, myf my_flags, const
> char *file,
> }
>}
>
> +end:
> + DBUG
to use new binary names in --debug traces
ok to push
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe
t removes close_table completely,
so I expect it to work for S3 just as you wanted.
>{
> /*
>All instances of this table needs to be closed.
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing lis
argument :
> +"Explicite --die command executed");
typo. "Explicit"
> break;
>case Q_EXIT:
> /* Stop processing any more commands */
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
__
ting one that looked at least remotely relevant"
> To be continued...
I've attached a proof-of-concept patch that adds a partition using
fallback-and-retry mechanism of open_table().
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
commit b5b14eaa775
Author: Sergei G
E), NO_MUTEX_GUARD, NOT_IN_BINLOG, ON_CHECK(0),
> ON_UPDATE(0));
You don't need to write all this tail of the default behavior. The last
line could be just
DEFAULT(FALSE));
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
_
>set_query(qs);
> +}
> +
> +if (fast_alter_partition_table(thd, table, _info, _info,
> + tl, >s->db, >s->table_name))
> +{
> + push_warning(thd, Sql_condition::WARN_LEVEL_WARN,
> WAR
PERIOD
> > implicitly for updates and deletes.
> >
> Sure, option two should be chosen. I rewrote the code
Why option two?
Do you know use cases that would justify this behavior?
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
__
ysql_inplace_alter_table()
>
> Removed redundant tdc_remove_table(TDC_RT_REMOVE_ALL). Share was marked
> flushed by preceding wait_while_table_is_used() and eventually flushed by
> close_all_tables_for_name().
>
> Part of MDEV-17882 - Cleanup refresh version
>
Regards,
Serg
Hi, Sergey!
okay then
On Apr 02, Sergey Vojtovich wrote:
> Sergei,
>
> On Thu, Apr 02, 2020 at 11:43:26AM +0200, Sergei Golubchik wrote:
> > Hi, Sergey!
> >
> > On Apr 01, Sergey Vojtovich wrote:
> > > revision-id: 5c26e91f755 (mariadb-10.5.0-70-g5c26e
Hi, Sergey!
On Apr 02, Sergey Vojtovich wrote:
> On Thu, Apr 02, 2020 at 11:43:14AM +0200, Sergei Golubchik wrote:
> > Hi, Sergey!
> >
> > On Apr 01, Sergey Vojtovich wrote:
> > > revision-id: 6daf451415f (mariadb-10.5.0-69-g6daf451415f)
> > > pare
sh lookups
>
> Let auto repair table and truncate table routines flush TABLE_SHARE
> directly.
>
> Part of MDEV-17882 - Cleanup refresh version
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
for mysql.gtid_slave_pos truncation
>
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad
_unused_tables() cleanup
>
> As tc_purge() never marks share flushed, let tdc_remove_table() do it
> directly.
sure
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-develope
+ DBUG_RETURN(close_cached_tables(thd, argument.tables, true,
> + thd->variables.lock_wait_timeout));
are you sure you want to do it when argument.tables is empty? It'll do
purge_tables() which seems to be a bit extreme for DROP SERVER
> }
>
Regards
eference, which means we can
> avoid hash lookup and flush unused TABLE instances directly.
>
> TDC_RT_REMOVE_UNUSED -> TDC_element::flush_unused(). Only [ab]used by
> mysql_admin_table() currently. Should be removed eventually.
>
> Part of MDEV-17882 - Cleanup refresh
t;{
> result= true;
> break;
>}
> - table->file->extra(HA_EXTRA_PREPARE_FOR_FORCED_CLOSE);
>close_all_tables_for_name(thd, table->s, HA_EXTRA_NOT_USED, NULL);
> }
the rest is fine
Regards,
Sergei
VP of MariaDB Server Engineering
and sec
gt;}
>
> + if (thd->lex->type & REFRESH_READ_LOCK)
> + {
> +for (auto table_list= all_tables; table_list;
> + table_list= table_list->next_global)
> +{
> + if (table_list->table->file->extra(HA_EXTRA_FLUSH))
> +goto error_re
Hi, Rasmus!
On Apr 01, Rasmus Johansson wrote:
> Hi Serg,
>
> Thanks for the review. I've addressed the review comments in commit 1cedc95
> in branch 10.2-MENT-566. See below for comments.
Looks good now, thanks. Ok to push
Please squash these commits before pushing, though
Regard
for storage engine plugins
>
> Use plugin->plugin->info->hton instead.
> plugin_data() replaced with plugin_hton().
> plugin_hton() must never return NULL anymore and is only good to be called
> against plugins in PLUGIN_IS_READY state.
Why is that?
Regards,
Sergei
VP of
l not be wrong, because your condition
$test eq @sorted_tests[$#sorted_tests]
can only be true once, for the very last test. So you can as well remove the
whole if()
and put the unconditional
$xml_report .= "\t\n";
after the loop.
> +}
> +
> +$xml_
give an idea about when
>will direct added be true ? In fact in all the uses for
>direct_added, it is always in an unlikely branch in Item_sum.cc.
This was added specifically for and is only used by the spider engine.
If you run spider tests you'll probably see it being true.
But I suspect you
quot;,
> 19, "M small buf: %M", 0);
> - test_w_len("M small buf positional: 0 \"In",
> + test_w_len("M small buf positional: 0 \"..",
> 30, "M small buf positional: %1$M", 0);
>
>return exit_status();
We didn'
the string.
perhaps it would be simpler to move ... inside backtick_string()
>
>test1("Length modifiers work: 1 * -1 * 2 * 3",
> "Length modifiers work: %d * %ld * %lld * %zd", 1, -1L, 2LL,
> (size_t)3);
> @@ -125,7 +125,7 @@ int main(void)
&
nd wrongly call update_handler.
see above. An assert is now impossible. If we wrongly call
update_handler it might work, but more often than not it'll produce
incorrect table content. So, no crash, but a hard to detect incorrect
data corruption.
> > > +
> > >THD_STA
Server)
I don't understand that at all.
1. What does the comment "Place mysql_install_db symlink also in
scripts" even mean?
2. you CONFIGURE_FILE mariadb-install-db twice.
3. Why two INSTALL(PROGRAM ?
4. You set all bindir/etc variables for mysql_install_db and it will
affect C
03-04-01
1 2 2003-05-01 2003-06-01
And the same for replace, basically:
replace t1 values (1,3,'2003-01-01','2003-02-01');
-> 1 3 2003-01-01 2003-02-01
1 2 2003-05-01 2003-06-01
or
-> 1 3 2003-01-01 2003-02-01
1 1 2
+
> +if (!null_in_key && !error
> +&& table->check_period_overlaps(key_info, key_info,
> +new_data, record_buffer) == 0)
That's strange. You compare keys in key_period_compare_bases(), why do
you do NULL values here?
>
cc
> index 9dbb7a15726..49e97faea22 100644
> --- a/sql/key.cc
> +++ b/sql/key.cc
> @@ -896,3 +897,51 @@ bool key_buf_cmp(KEY *key_info, uint used_key_parts,
>}
>return FALSE;
> }
> +
> +
> +/**
> + Compare base parts (not including the period) of keys with
Hi, Alexander!
On Feb 26, Alexander Barkov wrote:
> Hi, Sergei, Georg,
>
> Please review a fixed version of the patch for MDEV-17832.
>
> There are two files attached:
> - mdev-17821.v18.diff (server changes)
Here you are:
> diff --git a/include/mysql.h b/in
guide me about where and how to start so that I can
> contribute to this organization. Looking forward to get the guidance
> as soon as possible and to work with this organization.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur
BUG_ASSERT(my_count_bits(want_access) <= 1);
I think you can remove SUPER_ACL from the userstat plugin and uncomment
the assert above.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~mari
nt i=0; i < parts; i++)
> +
> + /* Correct the key & key_parts if this function has been called before
> */
> + key= table->key_info + key_index;
> + key->key_part= key_part;
> +
> + for (uint i=0; i < parts; i++, key_part++)
>
e.cc b/sql/sql_table.cc
> index 102416ec0a6..9e40c2ae8c8 100644
> --- a/sql/sql_table.cc
> +++ b/sql/sql_table.cc
> @@ -10506,10 +10506,10 @@ do_continue:;
> No additional logging of query is needed
>*/
>binlog_done= 1;
> + DBUG_ASSERT(new_table->fi
s engine name
in the plugin_array[] (note, all builtin plugins are already there)
* initialize it and (if successful) load mysql.plugin table
It only concerns the sql_plugin.cc part of your commit. Your aria part
of the commit is still needed, because a good-behaving engine has to be
read-o
y is a clustered and a reference key".
Just "clustered" is marked with HA_CLUSTERED_INDEX.
So,
1. You've renamed the method but the name does not match the semantics.
It is called is_clustering_key() but it really means
"clustered AND reference key"
2. What other engine ca
Hi, Oleksandr!
On Feb 26, Oleksandr Byelkin wrote:
> On Wed, Feb 26, 2020 at 1:44 PM Sergei Golubchik wrote:
>
> > Hi, Sanja!
> >
> > _some_ comments are below.
> >
> > The main thing, I still don't understand your changes in sql_select.cc.
> >
> &g
+ if (opt_init_connect.length &&
> + (sctx->master_access & IGNORE_INIT_CONNECT_ACL) == NO_ACL)
dunno, I kind of like !(access & SOME_ACL)
why not to keep privilege_t -> bool?
>{
> execute_init_command(thd, _init_connect, _sys_init_connect);
>
> spec_start - query_start))
>MYSQL_YYABORT;
> +if ($7)
> +{
> + elem->set_cycle_list($7);
> +}
> }
> ;
>
> +opt_cycle:
> + /* empty */
>
a wrong"
--source include/search_pattern_in_file.inc
this will print that there were 4 matches. Alternatively you can use
four very specific SEARCH_PATTERN, one for each expected error.
It's easier than what you've used, keeps the error log in one file, and
doesn't run unnecessary sql on th
Hi, Aleksey!
On Feb 18, Aleksey Midenkov wrote:
> On Mon, Feb 17, 2020 at 8:23 PM Sergei Golubchik wrote:
> > On Feb 17, Aleksey Midenkov wrote:
> > > On Sat, Nov 9, 2019 at 12:03 AM Sergei Golubchik wrote:
> > > >
> > > > 1.
> > > >
Hi, Aleksey!
On Feb 17, Aleksey Midenkov wrote:
> Hi Sergei!
>
> On Sat, Nov 9, 2019 at 12:03 AM Sergei Golubchik wrote:
> >
> > Hi, Aleksey!
> >
> > 1.
> > It should be possible to enable/disable auto-creation. For example,
> > CREATE TABLE ...
::ON_ERROR;
> + }
> +;
> +
> +table_function:
> + JSON_TABLE_SYM '(' expr ',' TEXT_STRING_sys
difficult to see what you're parsing without a syntax specs in the
commit comment.
> + {
> +Tab
gt; +--echo # End of 10.3 tests
please add few tests when sql_quote_show_create=0. Like
1. sql_quote_show_create=0, role name is not reserved (e.g. foo)
2. sql_quote_show_create=0, role name is reserved (e.g. fetch)
3. sql_quote_show_create=0, role name is not
/*
> If we have requested too much file handles than we bring
>max_connections in supported bounds. Still leave at least
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.
t
> handler->position fix to unique blobs. The reason is that
> main.long_unique_bugs test fails, and I did not find a quick solution for
> that :(
Monty is rewriting the code around long uniques and the update_handler.
We'll have to wait until he's done.
> On Tue, 17 De
Hi, Aleksey!
On Jan 05, Aleksey Midenkov wrote:
> On Wed, Jan 1, 2020 at 4:07 PM Sergei Golubchik wrote:
> > On Jan 01, Aleksey Midenkov wrote:
> > > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote:
> > > > On Dec 22, Aleksey Midenkov wrote:
> > &g
sent out an
> > discussion to maria-docs, but didn't get some help. So I think I may
> > get something in dev channel.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
___
Mailing list: https://launchpad.net/~maria-develope
501 - 600 of 2336 matches
Mail list logo
