Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Nikita Malyavin
On Fri, Mar 1, 2019 at 1:24 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Feb 28, Nikita Malyavin wrote: > > On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik > wrote: > > > On Dec 28, Nikita Malyavin wrote: > > > > Hi, Sergei! > > > > > > > > In short, I am on the side of standard conformance.

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Sergei Golubchik
Hi, Nikita! On Feb 28, Nikita Malyavin wrote: > On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik wrote: > > On Dec 28, Nikita Malyavin wrote: > > > Hi, Sergei! > > > > > > In short, I am on the side of standard conformance. > > > > Our TRUNCATE is not exactly a standard TRUNCATE. it's defined as

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Nikita Malyavin
On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Dec 28, Nikita Malyavin wrote: > > Hi, Sergei! > > > > In short, I am on the side of standard conformance. > > Our TRUNCATE is not exactly a standard TRUNCATE. it's defined as > DROP+REPLACE. But generally I agree, stand

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2018-12-27 Thread Sergei Golubchik
Hi, Nikita! On Dec 28, Nikita Malyavin wrote: > Hi, Sergei! > > In short, I am on the side of standard conformance. Our TRUNCATE is not exactly a standard TRUNCATE. it's defined as DROP+REPLACE. But generally I agree, standard conformance. > Next two statements are generally out of scope of thi

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2018-12-27 Thread Nikita Malyavin
Hi, Sergei! In short, I am on the side of standard conformance. Next two statements are generally out of scope of this bug, but: I like to see extra2 reading in separate function, and i believe that `TABLE_SHARE::init_from_binary_frm_image` needs more decomposiiton. Further: > I don't quite like

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2018-12-26 Thread Sergei Golubchik
Hi, Nikita! On Dec 26, Nikita Malyavin wrote: > revision-id: 0608c273598 (versioning-1.0.5-112-g0608c273598) > parent(s): 49d506cd1d7 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2018-09-05 04:42:17 +1000 > message: > > MDEV-15966: Behavior for TRUNCATE versioned table is