Hi, Aleksey,
Basically, it's fine, but I still didn't like that there's a new flag in
THD to mark a statement that has to be logged. So I tried to change to
log_current_statement. I know you tried that and you told me what tests
fails, rpl.create_or_replace_*. I debugged that a bit, and I think th
Hi Sergei!
On Tue, Apr 12, 2022 at 12:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> Basically, it's fine, but I still didn't like that there's a new flag in
> THD to mark a statement that has to be logged. So I tried to change to
> log_current_statement. I know you tried that and you told me
Hi, Aleksey,
> I attached the patch and this still fails rpl.create_or_replace_row.
small mistake in the patch:
> --- a/sql/sql_class.h
> +++ b/sql/sql_class.h
> @@ -2916,7 +2916,7 @@ class THD: public THD_count, /* this must be first */
>
>bool binlog_need_stmt_format(bool is_transactiona
Hi Sergei,
On Sun, Apr 17, 2022 at 8:48 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> > I attached the patch and this still fails rpl.create_or_replace_row.
>
> small mistake in the patch:
>
> > --- a/sql/sql_class.h
> > +++ b/sql/sql_class.h
> > @@ -2916,7 +2916,7 @@ class THD: public THD_coun
Hi, Aleksey,
On Apr 18, Aleksey Midenkov wrote:
> >
> > I have a second patch that renames flags to have a very well-defined
> > meaning and name.
> >
> > OPTION_KEEP_LOG -> OPTION_BINLOG_THIS_TRX
> > log_current_statement -> OPTION_BINLOG_THIS_STMT
>
> Where is your patch?
It's really just
Hi Sergei!
On Tue, Apr 19, 2022 at 11:13 AM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> On Apr 18, Aleksey Midenkov wrote:
> > >
> > > I have a second patch that renames flags to have a very well-defined
> > > meaning and name.
> > >
> > > OPTION_KEEP_LOG -> OPTION_BINLOG_THIS_TRX
> > > log_
Hi, Aleksey,
Okay, sure.
I was going to push it after the release.
And in 10.3 to simplify future merges.
On Apr 20, Aleksey Midenkov wrote:
> Hi Sergei!
>
> On Tue, Apr 19, 2022 at 11:13 AM Sergei Golubchik wrote:
> >
> > Hi, Aleksey,
> >
> > On Apr 18, Aleksey Midenkov wrote:
> > > >
> > > >
Sergei,
I updated the branch accordingly. There is your patch fa444975d0f
where I added log_current_statement().
On Wed, Apr 20, 2022 at 1:12 PM Sergei Golubchik wrote:
>
> Hi, Aleksey,
>
> Okay, sure.
> I was going to push it after the release.
> And in 10.3 to simplify future merges.
>
> On Ap
Hi, Aleksey,
ok to push, thanks!
On Apr 20, Aleksey Midenkov wrote:
> Sergei,
>
> I updated the branch accordingly. There is your patch fa444975d0f
> where I added log_current_statement().
>
> On Wed, Apr 20, 2022 at 1:12 PM Sergei Golubchik wrote:
> >
> > Hi, Aleksey,
> >
> > Okay, sure.
> >
9 matches
Mail list logo