Re: [Maria-developers] 2467eb2d314: MDEV-27743 Remove Lex::charset

2022-03-16 Thread Sergei Golubchik
Hi, Alexander, I'd suggest to rename it the way you want in the server, but keep it in libmariadb as is. It's apparently part of the API and may be (just may be) some clients use it. On Mar 15, Alexander Barkov wrote: > >> + > >> + void set_lex_collation(const Lex_collation_st ) > >> + { > >>

Re: [Maria-developers] 2467eb2d314: MDEV-27743 Remove Lex::charset

2022-03-13 Thread Sergei Golubchik
Hi, Alexander, I had only a couple of questions/comments, see below: On Mar 11, Alexander Barkov wrote: > revision-id: 2467eb2d314 (mariadb-10.6.1-330-g2467eb2d314) > parent(s): 61b72ed3dde > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2022-02-10 10:27:55 +0400 > message: