Re: [Maria-developers] 903ae1c03ae: Fix running without binlog

2021-11-15 Thread Sergei Golubchik
Hi, Nikita! On Nov 15, Nikita Malyavin wrote: > revision-id: 903ae1c03ae (mariadb-10.5.2-479-g903ae1c03ae) > parent(s): a5fca9a6e30 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2021-01-27 17:28:05 +1000 > message: > > Fix running without binlog Strange. With such a comment

Re: [Maria-developers] 903ae1c03ae: Fix running without binlog

2021-11-23 Thread Nikita Malyavin
indeed, maybe something's mixed up I really think this should be a part of this fix (from "[6/8] store cache managers in a list") : > diff --git a/sql/handler.cc b/sql/handler.cc > index 8b95653e69f..8b22167e729 100644 > --- a/sql/handler.cc > +++ b/sql/handler.cc > @@ -6660,7 +6660,16 @@ static i

Re: [Maria-developers] 903ae1c03ae: Fix running without binlog

2021-11-24 Thread Sergei Golubchik
Hi, Nikita! On Nov 24, Nikita Malyavin wrote: > > The way to test with and without binlog is to rename .test in .inc and make > a new test: one that sources have_binlog.inc, and one that doesn't. > > I don't like putting tests in .inc, so decided to leave only one version of > it. Maybe that's w