Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-23 Thread Sergei Golubchik
Hi, Alexander! On Mar 23, Alexander Barkov wrote: > >>> On Feb 20, Alexander Barkov wrote: > please review a fix for MDEV-5689. > > It also fixes > MDEV-5709 ExtractValue() with XPath variable references returns wrong > result. > > I pushed my patch to 10.0. > But the rep

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-23 Thread Alexander Barkov
Hi Sergei, On 03/20/2014 12:04 PM, Sergei Golubchik wrote: Hi, Alexander! On Mar 20, Alexander Barkov wrote: On 03/19/2014 12:03 AM, Sergei Golubchik wrote: On Feb 20, Alexander Barkov wrote: please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable refe

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-20 Thread Sergei Golubchik
Hi, Alexander! On Mar 20, Alexander Barkov wrote: > On 03/19/2014 12:03 AM, Sergei Golubchik wrote: > > On Feb 20, Alexander Barkov wrote: > >> please review a fix for MDEV-5689. > >> > >> It also fixes > >> MDEV-5709 ExtractValue() with XPath variable references returns wrong > >> result. > >> >

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-19 Thread Alexander Barkov
Hi Sergei, Thanks for review. Please see my comments inline: On 03/19/2014 12:03 AM, Sergei Golubchik wrote: Hi, Alexander! On Feb 20, Alexander Barkov wrote: please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable references returns wrong result. Desc

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-18 Thread Sergei Golubchik
Hi, Alexander! On Feb 20, Alexander Barkov wrote: > please review a fix for MDEV-5689. > > It also fixes > MDEV-5709 ExtractValue() with XPath variable references returns wrong > result. > > Description: > > 1. The main problem was that that nodeset_func->fix_fields() was > called in Item_func

[Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-02-20 Thread Alexander Barkov
Hi Sergei, please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable references returns wrong result. Description: 1. The main problem was that that nodeset_func->fix_fields() was called in Item_func_xml_extractvalue::val_str() and Item_func_xml_update: