Re: [Maria-developers] A mess with sql_alloc() ?

2009-10-09 Thread Alexi1952
Thanks for your comments! In any case extern declarations like this should be avoided, much better to only have the declaration in one place in some *.h file. I agree. Currently, we have: mysql_priv.h: #ifndef MYSQL_CLIENT ... void *sql_alloc(size_t); ...

Re: [Maria-developers] A mess with sql_alloc() ?

2009-10-09 Thread Kristian Nielsen
Alexi1952 alexi1...@yandex.ru writes: Thanks for your comments! In any case extern declarations like this should be avoided, much better to only have the declaration in one place in some *.h file. I agree. Currently, we have: mysql_priv.h: #ifndef MYSQL_CLIENT ...

[Maria-developers] A mess with sql_alloc() ?

2009-10-08 Thread Alexi1952
I need to use sql_string.* and sql_list.* in MYSQL_CLIENT context (mysqlbinlog.cc). sql_list.h refers to sql_alloc() function which originally has THD dependent implementation: mysql_priv.h: #ifndef MYSQL_CLIENT ... (1)void *sql_alloc(size_t); ... #endif