Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

2018-04-16 Thread Alexander Barkov
On 04/16/2018 10:38 AM, Alexander Barkov wrote: > - Adds a function relink_hack() to properly bind st_select_lex containing > an IN/EXISTS subselect to thd->lex->builtin_select. This is needed for > the cases when the statement does not do main_select_push(). > I does not know this code

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

2018-04-10 Thread Oleksandr Byelkin
Hi, Alexander! Am 10.04.2018 um 15:00 schrieb Alexander Barkov: Hello Sanja, [skip] Can you give an example of a query that is not parsed by the current 10.3 parser, but is parsed in 10.3-MDEV-11953 ? There is mysql-test/main/brackets.test ___

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

2018-04-10 Thread Alexander Barkov
Hello Sanja, On 04/10/2018 03:37 PM, Oleksandr Byelkin wrote: > Am 10.04.2018 um 10:58 schrieb Alexander Barkov: >>Hello Sanja, >> >> >> I reviewed your recent changes in "10.3-MDEV-11953" >> (and the attached additional patch for sql_yacc_ora.yy) >> >> I have some proposals: >> >> >> >> 1.

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

2018-04-10 Thread Oleksandr Byelkin
Am 10.04.2018 um 10:58 schrieb Alexander Barkov: Hello Sanja, I reviewed your recent changes in "10.3-MDEV-11953" (and the attached additional patch for sql_yacc_ora.yy) I have some proposals: 1. Can you please move huge pieces of the code from sql_yacc.yy to LEX or other relevant

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

2018-04-10 Thread Alexander Barkov
Hello Sanja, I reviewed your recent changes in "10.3-MDEV-11953" (and the attached additional patch for sql_yacc_ora.yy) I have some proposals: 1. Can you please move huge pieces of the code from sql_yacc.yy to LEX or other relevant classes? It makes the grammar much more readable