Re: [Maria-developers] InnoDB blob for primary key

2016-06-06 Thread Sachin Setia
yes sir https://github.com/SachinSetiya/server regards sachin On Mon, Jun 6, 2016 at 12:39 PM, Sachin Setia wrote: > yes sir > https://github.com/SachinSetiya/server > regards > sachin > > On Mon, Jun 6, 2016 at 12:31 PM, Oleksandr Byelkin > wrote: > >> Are there there in github? >> Am 06.06.20

Re: [Maria-developers] InnoDB blob for primary key

2016-06-05 Thread Sachin Setia
Hello Sir Weekly Report for second week of gsoc 1. Implemented unique in the case of null 2. Implemented unique(A,b,c) Currently working on tests , field hiding Regards sachin On Tue, May 31, 2016 at 10:49 PM, Sergei Golubchik wrote: > Hi, Sachin! > > On May 31, Sachin Setia wrote: > > Hel

Re: [Maria-developers] InnoDB blob for primary key

2016-05-19 Thread Sergei Golubchik
Hi, Sachin! First, it's *very* good that you commit often and ask me to review early. This way we can do adjustments early on. See below my first review of your patch. To summarize it here, there're three main points: 1. Coding style. Look at how the rest of the code base look like, particula

Re: [Maria-developers] InnoDB blob for primary key

2016-05-19 Thread Sachin Setia
Hello Sir! Today I made some progress related 1st project MariaDB [a]> create table tbl(abc blob unique); Query OK, 0 rows affected (0.03 sec) MariaDB [a]> insert into tbl values('sachin'); Query OK, 1 row affected, 1 warning (0.01 sec) MariaDB [a]> insert into tbl values('setiya'); Query OK, 1 r

Re: [Maria-developers] InnoDB blob for primary key

2016-05-16 Thread Sachin Setia
Hello Sergei! Sir please review the prototype at https://github.com/SachinSetiya/server/tree/unique_index_sachin this is half code I guess it will be complete by tomorrow Regards sachin On Mon, May 2, 2016 at 8:42 PM, Sergei Golubchik wrote: > Hi, Sachin! > > On May 02, Sachin Setia wrote: > > H

Re: [Maria-developers] InnoDB blob for primary key

2016-05-02 Thread Sergei Golubchik
Hi, Sachin! On May 02, Sachin Setia wrote: > Hi Sergei! > > As i told you i was prototyping for hash table > It is done around 90% apart from one thing when hash is same > how to get record from .myd file when i have offset of record > so currently i am skipping it > But it is very fast i do not

Re: [Maria-developers] InnoDB blob for primary key

2016-05-02 Thread Sachin Setia
Hi Sergei! As i told you i was prototyping for hash table It is done around 90% apart from one thing when hash is same how to get record from .myd file when i have offset of record so currently i am skipping it But it is very fast i do not know why this is so fast here are results of employee data

Re: [Maria-developers] InnoDB blob for primary key

2016-04-23 Thread Sergei Golubchik
Hi, Sachin! On Apr 23, Sachin Setia wrote: > Hello Sergei! > Actually I am confused about first project. Should I do it for myisam or do > i need to do > it on upper level (change in sql/ directory) > Regards > sachin Let's do it on the upper level. I wrote in the earlier email: >> Let's rather

Re: [Maria-developers] InnoDB blob for primary key

2016-04-23 Thread Sachin Setia
Hello Sergei! Actually I am confused about first project. Should I do it for myisam or do i need to do it on upper level (change in sql/ directory) Regards sachin On Sat, Apr 23, 2016 at 2:25 PM, Sergei Golubchik wrote: > Hi, Sachin! > > On Apr 23, Sachin Setia wrote: > > Hello Sergei! > > Thank

Re: [Maria-developers] InnoDB blob for primary key

2016-04-23 Thread Sergei Golubchik
Hi, Sachin! On Apr 23, Sachin Setia wrote: > Hello Sergei! > Thanks for selecting me in gsoc. You're welcome. That was well deserved. > Actually Recently I was reading about redis database. > I found it very fast ,can we do something like in maridb > to make it fast. Like adding a new transacti

Re: [Maria-developers] InnoDB blob for primary key

2016-04-22 Thread Sergei Golubchik
Hi, Sachin! On Apr 19, Sachin Setia wrote: > Hello Sergei! > I am sorry , I pressed Ctrl + Enter so first message is an incomplete > message Actually first I was thinking instead of storing hash as b+tree > store it in hash table But then i come to know that we can have range > query in blob field

Re: [Maria-developers] InnoDB blob for primary key

2016-04-18 Thread Sergei Golubchik
Hi, Sachin! On Apr 18, Sachin Setia wrote: > Hi Actually I was thinking about how to implement blob as a foreign > key.Foreign has to be unique which we can already implement. To make > it foreign key we can either store unique hash or the whole blob > column. But I am not sure much people want

Re: [Maria-developers] InnoDB blob for primary key

2016-04-18 Thread Sergei Golubchik
Hi, Sachin! On Apr 16, Sachin Setia wrote: > Hi Sergei! > As I already told you i was building prototype.It is some what > completed apart from one thing comparing of two field values. the > difficulty is how to get data length of field from table->record[1]. > I will try to solve it. Do you mea

Re: [Maria-developers] InnoDB blob for primary key

2016-04-18 Thread Sergei Golubchik
Hi, Sachin! On Apr 15, Sachin Setia wrote: > Hi Sergei! > > Actually I was going through the mysql source code for unique long > constraints in file sql_tmp_table.cc in function create_tmp_table they > make a new field and a new key(hash_key) and pass this table obejct to > storage engine.They ac

Re: [Maria-developers] InnoDB blob for primary key

2016-04-18 Thread Sachin Setia
Hello Sergei! Hi Actually I was thinking about how to implement blob as a foreign key.Foreign has to be unique which we can already implement. To make it foreign key we can either store unique hash or the whole blob column. But I am not sure much people want to copy so long blob data in reference

Re: [Maria-developers] InnoDB blob for primary key

2016-04-16 Thread Sachin Setia
Hi Sergei! As I already told you i was building prototype.It is some what completed apart from one thing comparing of two field values. the difficulty is how to get data length of field from table->record[1]. I will try to solve it. One more thing actually i got how mysql hide field. For example

Re: [Maria-developers] InnoDB blob for primary key

2016-04-15 Thread Sachin Setia
Hi Sergei! Actually I was going through the mysql source code for unique long constraints in file sql_tmp_table.cc in function create_tmp_table they make a new field and a new key(hash_key) and pass this table obejct to storage engine.They actually refer this field as a hash field On the time of i

Re: [Maria-developers] InnoDB blob for primary key

2016-04-13 Thread Sachin Setia
Hello Sergei Sorry I did not see your mail. Actually i was thinking something like this before implementing the prototype but if i am more closer to innodb the more performance i will i get. I will definitively think about it. Regards sachin On Wed, Apr 13, 2016 at 9:17 PM, Sachin Setia wrote: >

Re: [Maria-developers] InnoDB blob for primary key

2016-04-13 Thread Sachin Setia
Hello Jan! Actually I was going through the problems raised by you 1>Firstly, existing tables will not have that column Yes Sir, you are right that existing table woudn't have DB_BLOB_HASH column, but this is fine because they indexed there blob column then they must have provided blob length, a

Re: [Maria-developers] InnoDB blob for primary key

2016-04-12 Thread Jan Lindström
Hi, Sachin, naturally you may continue, this is open source, please read https://mariadb.com/kb/en/mariadb/community-contributing-to-the-mariadb-project/ From InnoDB point of view there is issue if you add a new system generated column to the row. Firstly, existing tables will not have that colum