Re: [Maria-developers] Item_func_group_concat::fix_fields - indentation and check positioning?

2017-04-18 Thread Sergei Golubchik
Hi, Daniel! On Mar 01, Daniel Black wrote: > > I came across the following gcc warning (6.3.1) > > > sql/item_sum.cc: In member function ‘virtual bool > Item_func_group_concat::fix_fields(THD*, Item**)’: > sql/item_sum.cc:3478:5: warning: this ‘if’ clause does not guard... >

[Maria-developers] Item_func_group_concat::fix_fields - indentation and check positioning?

2017-02-28 Thread Daniel Black
I came across the following gcc warning (6.3.1) sql/item_sum.cc: In member function ‘virtual bool Item_func_group_concat::fix_fields(THD*, Item**)’: sql/item_sum.cc:3478:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if ((!args[i]->fixed && ^~