Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-13 Thread Alexey Botchkov
The Json_table_nested_path lives only inside the Table_function_json_table and that last one is the only class that manipulates the Json_table_nested_path internals. Using methods in your version, but it's the only class using these methods anyway. So to me it's seems more honest to declare classes

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-11 Thread Sergey Petrunia
On Sat, Mar 06, 2021 at 01:13:53AM +0400, Alexey Botchkov wrote: > Hi, Sergei! > > I pushed the patch to the feature branch for you to take a look. > The patch you proposed > http://lists.askmonty.org/pipermail/commits/2021-March/014492.html > I liked and adapted with one exception. The nested pa

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-10 Thread Alexey Botchkov
forgot about the embedded server. Fixed. On Wed, Mar 10, 2021 at 12:47 PM Sergey Petrunia wrote: > Hi Alexey, > > > On Sat, Mar 06, 2021 at 01:13:53AM +0400, Alexey Botchkov wrote: > > Hi, Sergei! > > > > I pushed the patch to the feature branch for you to take a look. > > > This broke CI, pleas

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-10 Thread Sergey Petrunia
Hi Alexey, On Sat, Mar 06, 2021 at 01:13:53AM +0400, Alexey Botchkov wrote: > Hi, Sergei! > > I pushed the patch to the feature branch for you to take a look. This broke CI, please fix: http://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos74-amd64/builds/18427/steps/compile/logs/stdio

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-05 Thread Alexey Botchkov
Hi, Sergei! I pushed the patch to the feature branch for you to take a look. The patch you proposed http://lists.askmonty.org/pipermail/commits/2021-March/014492.html I liked and adapted with one exception. The nested paths list is built using the **last_sibling_hook instead of *cur_last_sibling.

[Maria-developers] MDEV-17399: JSON_TABLE: final input

2021-03-04 Thread Sergey Petrunia
Hi Alexey, Please find below final bits of input. After these are addressed the patch will probably be good to push (But I'll need a final pass before giving ok to push). == json_table_mysql* tests == * Please remove one of the json_table_mysql and json_table_mysql2 tests. * Please move the re