Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-27 Thread Sergey Vojtovich
Hi Sergei, I will submit updated patch soon. Comments inline. On Sun, Jan 26, 2014 at 09:40:33PM +0100, Sergei Golubchik wrote: Hi, Sergey! On Jan 22, Sergey Vojtovich wrote: + +# Prepare test +delimiter |; +CREATE PROCEDURE p_install(x INT) +BEGIN + DECLARE CONTINUE

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-27 Thread Sergey Vojtovich
Sergei, On Mon, Jan 27, 2014 at 12:32:19PM +0400, Sergey Vojtovich wrote: ...skip... I'd suggest to remove plugin_mem_root at all. We can store plugin structures on dynamic arrays instead (instead of storing just pointers). Hmm. Interesting. In a separate changeset then. Can you

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-22 Thread Sergei Golubchik
Hi, Sergey! Looks ok, see a couple of question (and minor style-related comments) below. On Dec 27, Sergey Vojtovich wrote: At lp:maria/5.5 revno: 4009 revision-id: s...@mariadb.org-20131227101419-ahpdahcundclr6gv parent:

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-22 Thread Sergey Vojtovich
Hi Sergey, thanks for your review. Answers inline. On Wed, Jan 22, 2014 at 06:51:11PM +0100, Sergei Golubchik wrote: Hi, Sergey! Looks ok, see a couple of question (and minor style-related comments) below. On Dec 27, Sergey Vojtovich wrote: At lp:maria/5.5

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES and INSTALL PLUGIN

2013-12-04 Thread Sergei Golubchik
Hi, Sergey! On Dec 04, Sergey Vojtovich wrote: SHOW VARIABLES looks correct. So I have only two ideas: - Fix INSTALL PLUGIN so it releases LOCK_plugin before registering variables. Sounds like the best solution, but there are a few more things to fix, e.g. UNINTALL PLUGIN.

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES and INSTALL PLUGIN

2013-12-03 Thread Sergey Vojtovich
Hi Sergei, thanks for your feedback. Comments/questions inline. On Fri, Nov 29, 2013 at 01:57:13PM +0100, Sergei Golubchik wrote: Hi, Sergey! On Nov 27, Sergey Vojtovich wrote: Hi Sergei, I'm afraid I couldn't find easy fix for this deadlock. The question is if it is worth to spend

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES and INSTALL PLUGIN

2013-11-29 Thread Sergei Golubchik
Hi, Sergey! On Nov 27, Sergey Vojtovich wrote: Hi Sergei, I'm afraid I couldn't find easy fix for this deadlock. The question is if it is worth to spend time for more complex (and possibly less stable) solution. Details below. Locking profile --- INSTALL PLUGIN: LOCK_plugin

[Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES and INSTALL PLUGIN

2013-11-27 Thread Sergey Vojtovich
Hi Sergei, I'm afraid I couldn't find easy fix for this deadlock. The question is if it is worth to spend time for more complex (and possibly less stable) solution. Details below. Locking profile --- INSTALL PLUGIN: LOCK_plugin- LOCK_system_variables_hash (w) SHOW