Re: [Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Sergei Golubchik
Hi, Alexander! Fair enough. Ok to push On Nov 16, Alexander Barkov wrote: > On 11/16/2017 08:27 AM, Sergei Golubchik wrote: > > On Nov 15, Alexander Barkov wrote: > >> diff --git a/sql/partition_info.cc b/sql/partition_info.cc > >> index 512bf29..740e508 100644 > >> --- a/sql/partition_info.cc >

Re: [Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Alexander Barkov
Hi Sergei, On 11/16/2017 08:27 AM, Sergei Golubchik wrote: > Hi, Alexander! > > On Nov 15, Alexander Barkov wrote: >> diff --git a/sql/partition_info.cc b/sql/partition_info.cc >> index 512bf29..740e508 100644 >> --- a/sql/partition_info.cc >> +++ b/sql/partition_info.cc >> @@ -2221,6 +2239,8

Re: [Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Sergei Golubchik
Hi, Alexander! On Nov 15, Alexander Barkov wrote: > diff --git a/sql/partition_info.cc b/sql/partition_info.cc > index 512bf29..740e508 100644 > --- a/sql/partition_info.cc > +++ b/sql/partition_info.cc > @@ -2221,6 +2239,8 @@ int partition_info::fix_parser_data(THD *thd) > part_elem= it++;

[Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Alexander Barkov
Hello Sergei, Can you please review a patch for MDEV-13788, for 5.5? Thanks! diff --git a/mysql-test/suite/parts/inc/part_alter_values.inc b/mysql-test/suite/parts/inc/part_alter_values.inc new file mode 100644 index 000..f56d81d --- /dev/null +++