Hi Sergei,
Thanks for review.
On 05/09/2016 10:30 PM, Sergei Golubchik wrote:
Hi, Alexander!
TL;DR: looks fine. Few minor comments, see below.
On Apr 08, Alexander Barkov wrote:
diff --git a/include/m_ctype.h b/include/m_ctype.h
index c892d576..bb633f8 100644
--- a/include/m_ctype.h
+++
Hi, Alexander!
TL;DR: looks fine. Few minor comments, see below.
On Apr 08, Alexander Barkov wrote:
> diff --git a/include/m_ctype.h b/include/m_ctype.h
> index c892d576..bb633f8 100644
> --- a/include/m_ctype.h
> +++ b/include/m_ctype.h
> @@ -1010,11 +1009,19 @@ int my_charlen(CHARSET_INFO
Hello Sergei,
On 03/30/2016 08:41 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 30, Alexander Barkov wrote:
>> commit 4ab28aca964fa646aa55676db813dbed66b83093
>> Author: Alexander Barkov
>> Date: Mon Mar 28 11:05:51 2016 +0400
>>
>> MDEV-6353 my_ismbchar() and
Hi, Alexander!
On Mar 30, Alexander Barkov wrote:
> commit 4ab28aca964fa646aa55676db813dbed66b83093
> Author: Alexander Barkov
> Date: Mon Mar 28 11:05:51 2016 +0400
>
> MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring, part 1.
> Fixing the debug_sync and
Hi Sergei,
Please review a partial patch for MDEV-6353.
It removes my_mbcharlen() in all remaining pieces of the code,
except LOAD DATA and SELECT INTO OUTFILE.
I'll do LOAD DATA and SELECT INTO OUTFILE in a separate patch.
Thanks.
commit 4ab28aca964fa646aa55676db813dbed66b83093
Author:
Hi Sergei,
Please review a partial patch for MDEV-6353.
It removes my_mbcharlen() in all remaining pieces of the code,
except LOAD DATA and SELECT INTO OUTFILE.
I'll do LOAD DATA and SELECT INTO OUTFILE in a separate patch.
Thanks.
___
Mailing
6 matches
Mail list logo