Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-02-03 Thread Alex Budovski
Hi, > We set the mysys_var->id to thread_id in store_globals() to allow > MySQL to bind a user connection to different threads during execution > of one query.  We need to change mysys->thread_id so that all reports > (like dbug_print) are printed with the same logical thread id. > > The bug in qu

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-02-03 Thread Michael Widenius
Hi! > "Alex" == Alex Budovski writes: Alex> Re: my_thread_init Alex> I tried reverting my change and looking at the code again -- perhaps Alex> we have a different bug. Alex> The function does indeed set 'id' to a non-zero value (tmp->id = Alex> ++thread_count), but then it is reset to 0 b

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-02-03 Thread Michael Widenius
Hi! > "Alex" == Alex Budovski writes: Alex> Hi, >> I looked at the original bug report and can't see how this bug fix >> have anything to the with the real problem. >> >> I have now done a proper fix for this. Can you please test that things >> reported in http://bugs.mysql.com/bug.php?id=

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-01-29 Thread Alex Budovski
Re: my_thread_init I tried reverting my change and looking at the code again -- perhaps we have a different bug. The function does indeed set 'id' to a non-zero value (tmp->id = ++thread_count), but then it is reset to 0 by someone else. Let me show you: First of all, we hit a verifier stop tel

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-01-29 Thread Alex Budovski
Hi, > I looked at the original bug report and can't see how this bug fix > have anything to the with the real problem. > > I have now done a proper fix for this. Can you please test that things > reported in http://bugs.mysql.com/bug.php?id=31173 now works > on windows ? > Yes, looks like the cha

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-01-29 Thread Michael Widenius
Hi! > "Alex" == Alex Budovski writes: Alex> Hi, Alex> I've implemented a few things for the Windows port of SHOW PROFILE ( Alex> IO read/writes, user/kernel times, page faults) which you may want to Alex> consider looking at. There's also a few miscellaneous fixes in there. Alex> The commit

Re: [Maria-developers] SHOW PROFILE enhancements for Windows

2010-01-17 Thread Michael Widenius
Hi! > "Alex" == Alex Budovski writes: Alex> Hi, Alex> I've implemented a few things for the Windows port of SHOW PROFILE ( Alex> IO read/writes, user/kernel times, page faults) which you may want to Alex> consider looking at. There's also a few miscellaneous fixes in there. Alex> The commit

[Maria-developers] SHOW PROFILE enhancements for Windows

2010-01-16 Thread Alex Budovski
Hi, I've implemented a few things for the Windows port of SHOW PROFILE ( IO read/writes, user/kernel times, page faults) which you may want to consider looking at. There's also a few miscellaneous fixes in there. The commit log has the details. See: https://launchpad.net/~abudovski/maria/robust