Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-09-01 Thread Sergei Golubchik
Hi, Nikita, On Aug 30, Nikita Malyavin wrote: > revision-id: b1b38b64598 (mariadb-10.5.17-4-gb1b38b64598) > parent(s): 3b656ac8c17 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2022-08-23 00:27:39 +0300 > message: > > MDEV-29181 Potential corruption on FK update on a table w

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-09-01 Thread Nikita Malyavin
Hello, Sergei! On Thu, 1 Sept 2022 at 15:23, Sergei Golubchik wrote: > Hi, Nikita, > > On Aug 30, Nikita Malyavin wrote: > > revision-id: b1b38b64598 (mariadb-10.5.17-4-gb1b38b64598) > > parent(s): 3b656ac8c17 > > author: Nikita Malyavin > > committer: Nikita Malyavin > > timestamp: 2022-08-23 0

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-09-26 Thread Nikita Malyavin
Sergei, I have reworded the commit message, please see it here: https://github.com/MariaDB/server/commit/3a3064e355bac20ed56ae807e790068e16dd16f3 On Thu, 1 Sept 2022 at 19:59, Nikita Malyavin wrote: > Hello, Sergei! > > On Thu, 1 Sept 2022 at 15:23, Sergei Golubchik wrote: > >> Hi, Nikita, >> >

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-10-05 Thread Sergei Golubchik
Hi, Nikita, On Sep 27, Nikita Malyavin wrote: > Sergei, I have reworded the commit message, please see it here: > https://github.com/MariaDB/server/commit/3a3064e355bac20ed56ae807e790068e16dd16f3 Same thing. I still cannot understand from the comment what the problem was. >> > This new solution

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-10-09 Thread Sergei Golubchik
Hi, Nikita, On Sep 01, Sergei Golubchik wrote: > > > This new solution simply does the following: > > * Sets up a referenced table list in TABLE instance (sql_base.cc) > > * Iterates through it along with dict_table_t::referenced_set > > (row_upd_check_references_constraints) > > * Passes corre

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-10-10 Thread Marko Mäkelä
Sergei, On Sun, Oct 9, 2022 at 2:03 PM Sergei Golubchik wrote: > I've spent more time on this issue, and it looks like there is no > structure in InnoDB with the life time till the end of the statement > (or, at least, nothing easily usable). Would ha_innobase::m_prebuilt fill that purpose? Its

Re: [Maria-developers] b1b38b64598: MDEV-29181 Potential corruption on FK update on a table with vcol index

2022-10-10 Thread Sergei Golubchik
Hi, Marko, On Oct 10, Marko Mäkelä wrote: > On Sun, Oct 9, 2022 at 2:03 PM Sergei Golubchik wrote: > > I've spent more time on this issue, and it looks like there is no > > structure in InnoDB with the life time till the end of the statement > > (or, at least, nothing easily usable). > > Would h