Hi Alexander,
This is the patch for rpad/lpad with 2 args (call of make_empty_string() in
val_str() is to prepare MDEV-10574).
Regard,
Jérôme.
PS : I share this code under terms of MCA.
> -Message d'origine-
> De : Alexander Barkov [mailto:b...@mariadb.org]
> Envoyé : mercredi 26 avril
Hi Jerome,
Thanks for your contribution!
The patch generally looks good.
This piece of code is not fully correct though:
+Item *param_3= new (thd->mem_root) Item_string(thd,
+
param_1->collation.collation
+ " ", 1);
There are two problems he
Hello Alexander,
Thanks for the review.
I have already moved code of text_literal into lex in my last patch
(empty_strings.diff).
I will change it to use your new method.
Do you have news from Monty for the patch on stacktrace as notes ?
Best regards,
Jérôme.
> -Message d'origine-
> De
On 05/02/2017 11:53 AM, jerome brauge wrote:
> Hello Alexander,
> Thanks for the review.
> I have already moved code of text_literal into lex in my last patch
> (empty_strings.diff).
> I will change it to use your new method.
Thanks.
>
> Do you have news from Monty for the patch on stacktrace
Hello Jerome,
On 05/02/2017 11:53 AM, jerome brauge wrote:
> Hello Alexander,
> Thanks for the review.
> I have already moved code of text_literal into lex in my last patch
> (empty_strings.diff).
> I will change it to use your new method.
I have pushed a patch adding THD::make_string_literal()
5 matches
Mail list logo