Re: [Maria-developers] review of MDEV-10177 Hidden columns

Hi Serg! Thanks for the review. On Fri, Nov 24, 2017 at 3:06 AM, Sergei Golubchik wrote: > Hi, Sachin! > > On Nov 22, Sachin Setiya wrote: >> Hi Serg! >> >> Thanks for the review. >> Please review the updated patch , at bb-hidden-test branch >> I am currently working on this , only 2 things are l

Re: [Maria-developers] review of MDEV-10177 Hidden columns

Hi, Sachin! On Nov 22, Sachin Setiya wrote: > Hi Serg! > > Thanks for the review. > Please review the updated patch , at bb-hidden-test branch > I am currently working on this , only 2 things are left. > Changes apart from comments. > Rebased to latest 10.3. > Completely_invisible, or HA_INVISIBL

Re: [Maria-developers] review of MDEV-10177 Hidden columns

Hi Serg! Thanks for the review. Please review the updated patch , at bb-hidden-test branch I am currently working on this , only 2 things are left. Changes apart from comments. Rebased to latest 10.3. Completely_invisible, or HA_INVISIBLE_INDEX is only deleted when same name column/ index is creat

[Maria-developers] review of MDEV-10177 Hidden columns

Hi, Sachin! Here's a review of all changes between 474f51711b1 and f0e2cf3e6c8: > diff --git a/include/my_base.h b/include/my_base.h > index b93300d7562..68c828d5f74 100644 > --- a/include/my_base.h > +++ b/include/my_base.h > @@ -277,7 +277,8 @@ enum ha_base_keytype { >This flag can be calcu